From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9905AC433F5 for ; Sat, 23 Apr 2022 14:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tlCHwpIEEbkjFayWCeDxXvSvJkNKJb/bhc/2mIez1vA=; b=kwKeHnaj04ASzko6r2CABa0G+p HTdgfk94jYgNJJ+RqZffYv7YqeKeDKnl94eqPaU+aoQeTO4NcG+QasJuPvEXPFuexWKRA+nvSyFeZ z+1OFaoTWEXMyboY5BESqGJ+JXZKa8IIE/tCqZ6tsh4SxBbWuKI85mI0j5Ptpnx/OLafYvlmBYCEN KFakPo/+CIIf3lYbtUL52BVvRQ3R4YpsduXclNQ3L5gP7+k1SM54WTRhMlgL+cPa5uZFRWZ/FK2qu DSA9c77LVMi4hwGMz+AEzfuYS8POAfLzBdgUKl1JqF/eBsz7iWoQR+alWKC4p5RfsrrPwsnxdZxeD tYYfVjnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1niGtf-004TZ6-J3; Sat, 23 Apr 2022 14:38:03 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1niGtc-004TYB-8E for linux-arm-kernel@lists.infradead.org; Sat, 23 Apr 2022 14:38:01 +0000 Received: by mail-lf1-x12e.google.com with SMTP id x17so18961679lfa.10 for ; Sat, 23 Apr 2022 07:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=9Q3pZjqL2YRbxMi3ZEZPC+BgttCsWqeK314Feyp4SQ4=; b=O6lRTdmyP9SYSA3U8hfLl6p8PcytluSsbHwEFXxwQ+ubIxxSVZKbp9ABI4a104ybmE 4B0KpBf9zDgnV1i4oYkJNepeB9/rfyra7k5PI9DZqHke1VwN6482HV8XrLngsjtfpsFr 6bM8w36eLRa4VwfIxnHVhQfOZg/AaPvpoW8tB1wDHi0T7pELIli9N4UTO8TGcKuvFaKm eOZaalv2Z8+00j28i8eI7dMT0V4YIeOFmc8x7xswIRAT1Q9HRGUBVnLTfkM6C5KtYtu2 I9VW/XbIJHjaJqcC0s3p2b54l8r+mGP1Bv8UyPsSSwS8lK/HSTCCWDhUQlDqrMwBzC0h BFLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=9Q3pZjqL2YRbxMi3ZEZPC+BgttCsWqeK314Feyp4SQ4=; b=a19JQdQpCgS24qdXZnLLYHbsPosncSBQqLrc19MqpGuGfV4z4RzR6mixJEIHdzaOSZ HglTxe0+slaqMOLCvv/eb4yDC5ozTv3yj3PI2aEeDP8s1QL8t76ye8WeREsvK9raI298 /sRUcLo27cK7pItC717o6Y2gRXavE3YKxGDkXobr/dhk1q1Rb8JAjJ7IBO0iQbqPzFaA vG+AXzGMuDoNUeth+qrsuDEt01nNqlJkRg3wcqxqUQWS2AtbdlIST5d2XFQkYpvIOo+n YdVLGjIj5OQOldEDDKrzyprnFlz1FWji6+I9NqAb/kRZ62YQRvIsYZsCN1jHu03rdZln sRDA== X-Gm-Message-State: AOAM531ByGwokudaLMgUIHVVr6W+Pr9bzfTVZQC5GN89xPu8zBdSH+Ae HzA5V/zkIKP85qXtVzNpOss= X-Google-Smtp-Source: ABdhPJx8PYPHNf3hIYDk6xxcUZ5Cz4AjHRjZCng72eHk60GDl8rPACcXENIApaJQbCkMeAProiKKeA== X-Received: by 2002:a05:6512:150f:b0:45d:ccac:c43c with SMTP id bq15-20020a056512150f00b0045dccacc43cmr7231892lfb.604.1650724677772; Sat, 23 Apr 2022 07:37:57 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k11-20020a196f0b000000b00471c56b7a3dsm641075lfc.74.2022.04.23.07.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Apr 2022 07:37:57 -0700 (PDT) Subject: Re: [PATCH V1 4/6] dt-bindings: Add xen, dev-domid property description for xen-grant DMA ops To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oleksandr Tyshchenko , Jason Wang , Rob Herring , Krzysztof Kozlowski , Julien Grall , Juergen Gross , "Michael S. Tsirkin" , Christoph Hellwig References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-5-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <638a5b09-ce9e-ab7e-0a5e-d81afe851cc1@gmail.com> Date: Sat, 23 Apr 2022 17:37:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220423_073800_350328_AAB5BF2B X-CRM114-Status: GOOD ( 25.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23.04.22 02:00, Stefano Stabellini wrote: Hello Stefano > On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> Introduce Xen specific binding for the virtualized device (e.g. virtio) >> to be used by Xen grant DMA-mapping layer in the subsequent commit. >> >> This binding indicates that Xen grant mappings scheme needs to be >> enabled for the device which DT node contains that property and specifies >> the ID of Xen domain where the corresponding backend resides. The ID >> (domid) is used as an argument to the grant mapping APIs. >> >> This is needed for the option to restrict memory access using Xen grant >> mappings to work which primary goal is to enable using virtio devices >> in Xen guests. >> >> Signed-off-by: Oleksandr Tyshchenko > Looks OK to me. Just a couple of grammar improvements below. Aside from > those, I have no further comments. thank you, I agree with proposed comments, will update > > >> --- >> Changes RFC -> V1: >> - update commit subject/description and text in description >> - move to devicetree/bindings/arm/ >> --- >> .../devicetree/bindings/arm/xen,dev-domid.yaml | 37 ++++++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> new file mode 100644 >> index 00000000..ef0f747 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/xen,dev-domid.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/xen,dev-domid.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Xen specific binding for the virtualized device (e.g. virtio) > NIT: Xen specific binding for virtualized devices (e.g. virtio) > > >> +maintainers: >> + - Oleksandr Tyshchenko >> + >> +select: true >> + >> +description: >> + This binding indicates that Xen grant mappings scheme needs to be enabled >> + for that device and specifies the ID of Xen domain where the corresponding >> + device (backend) resides. This is needed for the option to restrict memory >> + access using Xen grant mappings to work. > NIT: > > This binding indicates that Xen grant mappings need to be enabled for > the device, and it specifies the ID of the domain where the > corresponding device (backend) resides. The property is required to > restrict memory access using Xen grant mappings. > > >> +properties: >> + xen,dev-domid: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The domid (domain ID) of the domain where the device (backend) is running. >> + >> +additionalProperties: true >> + >> +examples: >> + - | >> + virtio_block@3000 { >> + compatible = "virtio,mmio"; >> + reg = <0x3000 0x100>; >> + interrupts = <41>; >> + >> + /* The device is located in Xen domain with ID 1 */ >> + xen,dev-domid = <1>; >> + }; -- Regards, Oleksandr Tyshchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel