From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49265C10F14 for ; Fri, 12 Apr 2019 10:41:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A35F20675 for ; Fri, 12 Apr 2019 10:41:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SWT7cgSP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A35F20675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e/fMLyg/UHAtGKP3usxu6Ow6rqXFEvedt+kCFWB8huM=; b=SWT7cgSPohQuH2yyU3s4KOpVp stA32Z3pShSVYQrIYK1svNxQYc7OSuW6Etecz7MpI4wMawrYBIUZWlB68KyBCguPc9d0B2BzZT5Xz 6FrN0XJR+XTuZC2SjTnlT4K5Wn6z7SjKrg7VTb39uwWcDqW0TLiKJJHQR74uVX9ertntg9n4hexZg a42Y0+Jz+ghCeAOHZG4bMsmhhC9UBzXxfUeR4HAV2lA/bz57Fv4+fgGp5GI9jXusc58DBYcvfePSL 7vM4QqxpVjQOjYTqsFBBOLDNEoA4KhCpkgpeOy1Dc+V83zjdMTqGQTU0zCWspXcn3TJ0jPw6qcPNT wInVZgCrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEtcJ-0000Br-VO; Fri, 12 Apr 2019 10:41:07 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEtcH-0000BL-M0 for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2019 10:41:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0123B15AB; Fri, 12 Apr 2019 03:41:05 -0700 (PDT) Received: from [10.37.13.120] (unknown [10.37.13.120]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E10173F718; Fri, 12 Apr 2019 03:41:02 -0700 (PDT) Subject: Re: [PATCH v5 3/4] dt-bindings: arm: coresight: Unify funnel DT binding To: leo.yan@linaro.org, mathieu.poirier@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190412102738.12679-1-leo.yan@linaro.org> <20190412102738.12679-4-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: <63901a4c-2f34-a688-48b3-77b3dd8bb5d9@arm.com> Date: Fri, 12 Apr 2019 11:43:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20190412102738.12679-4-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_034105_726214_D18A3714 X-CRM114-Status: GOOD ( 26.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shiwanglai@hisilicon.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/12/2019 11:27 AM, Leo Yan wrote: > Following the same fashion with replicator DT binding, this patch is to > unify the DT binding for funnel to support static and dynamic modes; > finally we get the funnel DT binding as below: > > Before patch: > > Static funnel, aka. non-configurable funnel: > Not supported; > > Dynamic funnel, aka. configurable funnel: > "arm,coresight-funnel", "arm,primecell"; > > After patch: > > Static funnel: > "arm,coresight-static-funnel"; > > Dynamic funnel: > "arm,coresight-dynamic-funnel", "arm,primecell"; > "arm,coresight-funnel", "arm,primecell"; (obsolete) > > At the end of this patch, it gives an example for static funnel DT > binding, and updates the dynamic funnel example. > > Cc: Mathieu Poirier > Cc: Suzuki K Poulose > Cc: Wanglai Shi > Signed-off-by: Leo Yan > --- > .../devicetree/bindings/arm/coresight.txt | 53 +++++++++++++++++-- > 1 file changed, 48 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > index d02d160fa8ac..8a88ddebc1a2 100644 > --- a/Documentation/devicetree/bindings/arm/coresight.txt > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > @@ -8,7 +8,8 @@ through the intermediate links connecting the source to the currently selected > sink. Each CoreSight component device should use these properties to describe > its hardware characteristcs. > > -* Required properties for all components *except* non-configurable replicators: > +* Required properties for all components *except* non-configurable replicators > + and non-configurable funnels: > > * compatible: These have to be supplemented with "arm,primecell" as > drivers are using the AMBA bus interface. Possible values include: > @@ -24,8 +25,10 @@ its hardware characteristcs. > discovered at boot time when the device is probed. > "arm,coresight-tmc", "arm,primecell"; > > - - Trace Funnel: > - "arm,coresight-funnel", "arm,primecell"; > + - Trace Programmable Funnel: > + "arm,coresight-dynamic-funnel", "arm,primecell"; > + "arm,coresight-funnel", "arm,primecell"; (OBSOLETE. For > + backward compatibility and will be removed) > > - Embedded Trace Macrocell (version 3.x) and > Program Flow Trace Macrocell: > @@ -65,7 +68,7 @@ its hardware characteristcs. > "stm-stimulus-base", each corresponding to the areas defined in "reg". > > * Required properties for devices that don't show up on the AMBA bus, such as > - non-configurable replicators: > + non-configurable replicators and non-configurable funnels: > > * compatible: Currently supported value is (note the absence of the > AMBA markee): > @@ -74,6 +77,9 @@ its hardware characteristcs. > "arm,coresight-replicator"; (OBSOLETE. For backward > compatibility and will be removed) > > + - Coresight Non-configurable Funnel: > + "arm,coresight-static-funnel"; > + > * port or ports: see "Graph bindings for Coresight" below. > > * Optional properties for ETM/PTMs: > @@ -203,8 +209,45 @@ Example: > }; > }; > > + funnel { > + /* > + * non-configurable funnel don't show up on the AMBA > + * bus. As such no need to add "arm,primecell". > + */ > + compatible = "arm,coresight-static-funnel"; > + clocks = <&crg_ctrl HI3660_PCLK>; > + clock-names = "apb_pclk"; > + > + out-ports { > + port { > + combo_funnel_out: endpoint { > + remote-endpoint = <&top_funnel_in>; > + }; > + }; > + }; > + > + in-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + combo_funnel_in0: endpoint { > + remote-endpoint = <&cluster0_etf_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + combo_funnel_in1: endpoint { > + remote-endpoint = <&cluster1_etf_out>; > + }; > + }; > + }; > + }; > + > funnel@20040000 { > - compatible = "arm,coresight-funnel", "arm,primecell"; > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > reg = <0 0x20040000 0 0x1000>; > > clocks = <&oscclk6a>; > Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel