From: "Arnd Bergmann" <arnd@arndb.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Ard Biesheuvel" <ardb@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: FUNCTION_GRAPH_TRACER + UNWINDER_FRAME_POINTER broken on arm
Date: Mon, 27 May 2024 15:33:44 +0200 [thread overview]
Message-ID: <63d3a41d-227b-436d-a5e6-93438f47ad0c@app.fastmail.com> (raw)
In-Reply-To: <tqocmnkjgci3whkmqwgoneqsnusp6vf6fjw5lq77zc6u7u6mkm@o5ibt5uuvoy3>
On Mon, May 27, 2024, at 14:25, Uwe Kleine-König wrote:
> On Mon, May 27, 2024 at 11:18:32AM +0200, Arnd Bergmann wrote:
>> On Sat, May 25, 2024, at 09:59, Uwe Kleine-König wrote:
>>
>> You added this in 4bf1fa5a34aa ("[ARM] 5613/1: implement
>> CALLER_ADDRESSx") 15 years ago, and it appears nobody ever
>> got around to finish the job for return_address() if I read
>> this correctly. Is this something we should finally add,
>> and then make the frame pointer unwinder specific to OABI
>> kernels?
>
> Oh, now you mention it I remember, but only on a high level and not the
> deep details. I guess nobody came around finishing it because having the
> dummy implementation for return_address doesn't hurt?
>
> Completing it would mean adding the numerous __notrace annotions??
I only know what I could see in the changelog, so that
is my best guess as well. It does look like there are
only a couple of CALLER_ADDR1 and CALLER_ADDR2 sites
in the tree, and CALLER_ADDR0 should already work
as intended even without an unwinder.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-27 13:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 7:59 FUNCTION_GRAPH_TRACER + UNWINDER_FRAME_POINTER broken on arm Uwe Kleine-König
2024-05-27 8:39 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-27 8:42 ` Thorsten Leemhuis
2024-05-27 9:18 ` Arnd Bergmann
2024-05-27 12:25 ` Uwe Kleine-König
2024-05-27 13:33 ` Arnd Bergmann [this message]
2024-05-27 22:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d3a41d-227b-436d-a5e6-93438f47ad0c@app.fastmail.com \
--to=arnd@arndb.de \
--cc=ardb@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=rostedt@goodmis.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox