From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A887C61DA4 for ; Fri, 3 Feb 2023 16:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K/AmwaOINP1sMZVhivXQ+3KlrEiMxQ02UK3YlGZOyRs=; b=r3R4EtcyDBZI2d BziDkhzzjfCCkpkmIE+xsFWDwXi3ujARQRB0iPDj3xXn5Ylg2lU/QXW22NGwcI8Fkv3uXtWe5bHHq ZaRQ74qTRDXvRq2CDgPE/0XQfaUbfgu44g4xJT88ZHtKvnv+VGr/F6cLcF7Ah8BF4LD0xWnXaKBnA VvVp5pNK0MO6B4eCUJIRHoCAEbZe/JxEBUXtABc3ddXlJarOE/nTf5WfTO0N5Xvuvmcm6Vei3RsAP 3p5y3VdPCs8Tsm4cOmlIcf8S+hSTMmg22UPYLpUPOzhTvUOGADb2i1AwrtV0V0096CE5huRQgxpEG x3CbLaOi/0O+u+XNk86w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyzB-002w1j-DW; Fri, 03 Feb 2023 16:32:25 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyz7-002w0N-Hd for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 16:32:22 +0000 Received: by mail-pl1-x630.google.com with SMTP id r8so5772727pls.2 for ; Fri, 03 Feb 2023 08:32:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=kpK6KgZXQ54pBMdUsHP+HUpnEsKdgQDEGB4BNBeZB9M=; b=gEmQGizGKZQHCA1ytHRM6UDGT97glHo2J7W9naosZ1VMVQbEFAURGR1sGpP6uwVbvt 4FjCWBQ64s0+iMVMRk/Pdg87ZmByxjnhEqBvknvFlw31g48ojNq2Q0J04MnoArHb71ip WlF5qPrqDiZDdq6oiyt694Dpp6cDfmOXnqHQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kpK6KgZXQ54pBMdUsHP+HUpnEsKdgQDEGB4BNBeZB9M=; b=7a6/Oq2v/2qiRHx/N33eVokbV/n51TVz4Nfhvzxcek0gnUTi4Wf6G3rxvpUJRVahJy HsaJq029nO16BP2WBEGT6KtKkRtCEnN8KdP928BKxJm+mpxBKf+K8DxrW3VwOCQE0rm7 di0KvlDHsgC233ZxtbZRUwMvHToYeO+V135qu2vyuY/fleMh/6RRCSv+/jFSMT2yeY3J W0ZGR/X7dJZdN+ZiF6JXxXibkcyD9Wbv6o/GSyQ6Pk6m9XVVnMGtHJcXzw8V4R6z3Oh4 xYVCLqEvA5+5cUDIKtDfmGseAm2SLWMj0WZPAJtRMgHk/E5qU3NVTZhktU2EQUFvLA/R wZHg== X-Gm-Message-State: AO0yUKWzmk/LePQU06Lg+k8ty05/yRA/sRES7x54asTsPSNbjeYmGqAo ESuUQPDMDptEfOW6gmG/PN0Www== X-Google-Smtp-Source: AK7set8qwbVjBH5W+V+grJP9ndtfdT04u2cUvUjM4C67XgmP2kzzkMLxlD4daBx8I9135CQ3ShRNSQ== X-Received: by 2002:a05:6a20:8bb0:b0:b8:5f00:bbdc with SMTP id m48-20020a056a208bb000b000b85f00bbdcmr10653610pzh.50.1675441937646; Fri, 03 Feb 2023 08:32:17 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id b9-20020a1709027e0900b00198ac2769aesm1803803plm.135.2023.02.03.08.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 08:32:17 -0800 (PST) Message-ID: <63dd3711.170a0220.c22c8.349c@mx.google.com> X-Google-Original-Message-ID: <202302031631.@keescook> Date: Fri, 3 Feb 2023 16:32:16 +0000 From: Kees Cook To: Mark Rutland Cc: Catalin Marinas , Will Deacon , John Stultz , Yongqin Liu , Sami Tolvanen , Ard Biesheuvel , Yury Norov , Andrey Konovalov , Marco Elver , linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Tom Rix , Alexander Potapenko , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] arm64: Support Clang UBSAN trap codes for better reporting References: <20230202223653.never.473-kees@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_083221_600473_9F183B42 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 09:58:26AM +0000, Mark Rutland wrote: > On Thu, Feb 02, 2023 at 10:36:57PM +0000, Kees Cook wrote: > > On arm64, Clang encodes the UBSAN check type in the esr. Extract this > > and actually report UBSAN traps with some specificity when building with > > CONFIG_UBSAN_TRAP. Before: > > Really minor nit, but could we mention CONFIG_UBSAN_TRAP at the start, e.g. > change that first sentence to: > > | When CONFIG_UBSAN_TRAP=y on arm64, Clang encodes the UBSAN check type into a > | BRK immediate, which is reported in the ESR. > > I was initially confused since I was aware that there are usually direct > function calls for the reporting. Sure, I can rearrange the commit log. > > Other than that, this looks fine to me, and regardless of the above: > > Acked-by: Mark Rutland Thanks! -Kees -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel