From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B609CD5BDF for ; Thu, 5 Sep 2024 16:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gH2m8z07VyC9Rs4uG0Uvl0zZaPASslF/e9Q/tX9hoOk=; b=Px63b1MpTbRVy9Aiko1PpK8RyG fJmnfI10uaK49lN2Nes9ybbOoxLd5ftqLJtSayUVwcvPmmx7LcKlIvtNsVMNFnj2CDVLKOmwbi9y9 7kii6E1H2q1c8zrQvdiGZESrVc4+GN7fTNTXyPxHTGahlzOp9v0taFs1FnVBnBgEGsripD9ShqVjb R9AoWnBu82og0Iu3o3gMVht+UW7+zMuMUEJ7gz0RQ/MeRl6XuQLjNVyLRzbx7vz2snKH1Byg/PpjI vHtLYocuaXWMQ2g3YPm1zdpEdCtVQvFdyf+mP/NXVv+9oWuStOrZugIWZZ5ikstacMvi4KnGnAxT2 30MtvJfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smFcp-00000009BUm-08LU; Thu, 05 Sep 2024 16:46:27 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smFbq-00000009BDz-12YJ for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 16:45:27 +0000 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 485974JZ016158; Thu, 5 Sep 2024 16:40:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gH2m8z07VyC9Rs4uG0Uvl0zZaPASslF/e9Q/tX9hoOk=; b=nerlkPCYZhbbBpBr NSScHB2ruGVyMU95nTcKEy0ov3a15xf+EL/4EkQVy2x2jk6QiHENXdA3nRD8sM2g t8LR2skwquCdUa8Wcmy6aApm20yGV0zO7V7NEUVKiyUKQjKjyqxNFfjNu6fdBXC4 yc+nNrkQN5ErZhn8q7JWuScM0KiAP2JM+SDJtkaiKrZYx6DkkeZ7HOYPxL8B5PCn XTivXST2ASE0Eb4RfwykgJk6eTUEZolAQ5OHpi6dglMdc5u+2CUS8SnxoyMWc7xc KxqLtZeX+V1pbKCEYC6iW/oKwWiM/fvwlMqeg3LLwpJkuMIKFDlp+h3U7KTb/N21 PVEkHw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41egmrn4rf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Sep 2024 16:39:59 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 485GdwfI007444 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Sep 2024 16:39:58 GMT Received: from [10.110.102.234] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 5 Sep 2024 09:39:55 -0700 Message-ID: <63f988eb-e638-48fa-b566-3df39588bf7c@quicinc.com> Date: Thu, 5 Sep 2024 09:39:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 16/21] dt-bindings: spi: document support for SA8255p To: Andrew Lunn CC: Krzysztof Kozlowski , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Praveen Talari References: <9a655c1c-97f6-4606-8400-b3ce1ed3c8bf@kernel.org> <516f17e6-b4b4-4f88-a39f-cc47a507716a@quicinc.com> <2f11f622-1a00-4558-bde9-4871cdc3d1a6@lunn.ch> <204f5cfe-d1ed-40dc-9175-d45f72395361@quicinc.com> <70c75241-b6f1-4e61-8451-26839ec71317@kernel.org> <75768451-4c85-41fa-82b0-8847a118ea0a@quicinc.com> <4896510e-6e97-44e0-b3d7-7a7230f935ec@quicinc.com> <515a2837-69c3-47b2-978b-68ad3f6ad0fc@quicinc.com> <0ba03b8e-4dd5-4234-823e-db4c457fa292@lunn.ch> Content-Language: en-US From: Nikunj Kela In-Reply-To: <0ba03b8e-4dd5-4234-823e-db4c457fa292@lunn.ch> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: l_oq1IAyrxiZBlBS8JOfAaNdh9tdibTi X-Proofpoint-ORIG-GUID: l_oq1IAyrxiZBlBS8JOfAaNdh9tdibTi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-05_12,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2409050124 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_094526_322952_D3D625CC X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/5/2024 9:23 AM, Andrew Lunn wrote: >> If the QUPs yaml changes are not included in the same series with >> i2c,serial yaml changes, you see these errors: >> >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@9c0000: serial@990000:compatible:0: 'qcom,sa8255p-geni-uart' is not one of ['qcom,geni-uart', 'qcom,geni-debug-uart'] >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dtb: geniqup@9c0000: i2c@984000:compatible:0: 'qcom,sa8255p-geni-i2c' is not one of ['qcom,geni-i2c', 'qcom,geni-i2c-master-hub'] > So you have a couple of options: > > 1) It sounds like you should get the QUP changes merged first. Then > submit the i2c,serial changes. Is there a reason you cannot do > this? Is there a mutual dependency between these two series, or > just a one way dependency? The ask in this thread is to create new yaml files since existing one is using generic compatibles. With new yaml, we would need to provide example and can't avoid it. If we have to provide example of QUP node, IMO, we should provide a few subnodes as well since just QUP node without subnodes(i2c/serial/spi)  will not be very useful. We can possibly skip all 3 subnode and only keep one subsystem(e.g. serial) so QUP and UART yaml can go together(still need two subsystems) while SPI and I2C can go independently after QUP series is accepted. Not sure if that is acceptable to maintainers though. QUP node in actual DT will have all 3 types of subnodes(i2c,spi, serial) so example in this case won't be complete. > > 2) Explain in the commit message that following errors are expected > because ... And explain in detail why the dependency cannot be > broken to avoid the errors. > > Andrew