From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0869CC6FA99 for ; Tue, 7 Mar 2023 23:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cQfy1aztb0fp4McZDh2JNoczgz5mGfido1jbyOnLTBY=; b=l7VIFgT36se+e/ GsLUNQW4mpks7gMnVw+Y//5FCz38MuQOSWNiKNqZ1wfx+zPd4rGmNzlRxezwoG1HLPnBiN89QdHg2 OXSxgLoSjd/QxuD3m4+7W1147Q0OvsqhN30xdYD2kZ2+jkyop5J+1SwiFBSo/I9VUMccmQAsXAlGo tE56M2f72qsREGJw1piUtWxW4KwRcndNjcVqwi4vGKGhWSSd2JtVUfAlPD+oCpu5TCmbTvqMjGr08 5dUQt8F0iOISHRN9Z0NG8R8BgL20bscfQ/OKY8fKjbgpcPEOT48T8j7X4LD3fcpZxFdlfa9LE1EVN xOIHp2Uuk+iXwQVf+nhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZgiM-002raU-0y; Tue, 07 Mar 2023 23:27:26 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZgiJ-002rYk-4p for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 23:27:24 +0000 Received: by mail-wr1-x42d.google.com with SMTP id bx12so13724434wrb.11 for ; Tue, 07 Mar 2023 15:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678231639; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=K+UgCiSf5tvja4WISBu0Ta5QgChkgCAANPe7dzhw5bU=; b=kCz/N25pmJ5A1YBfpdlM80BJCQzCzFxI0ec1N42sO+yTjzBKAqeeB7rE4DYtnxUsH0 zvxkZTIjnHn4xAr6fcAIZTGcjEg9iNtZBGWy1KXzFwbz4PjUrp3zqEIcmnvklKRh4/K+ u4slt4gkAaZfZreX90uPnd+olGHNicQGHnovFqDAJqczafcCI76oPZfT+nfGHElCr2Vn VkNchbe1LdS1ZIwgTxVTYWQ49wFVlMM01VOtU6YY0loOKa6GIT/ycJo9mCzb80Ej2GHe gFdkvhW0d2w9WitjC3HtdU+UIyvriL0m6v3mDcEKzyA+imw7WFMi5+ZCvwGm0copO78o aWGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678231639; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K+UgCiSf5tvja4WISBu0Ta5QgChkgCAANPe7dzhw5bU=; b=6CwqZZvtIXXF+DTxx6KsCnBCjnVck/T2yVsamhcgzfcGlGsuR8Mklmp6DZh3jxj2yp iEjtCxd4r0hnXlTWH1YrmPeNVzaZw1L6DwKjHHFr1jDEQ4pOem8A6Yqsl4ZX/Ug0Uf8b DYxB9/pQQVu7NoOKEz/A62N9YH4V6OOKJQJEHiRjuzjtDoGUk0SkfgxKFcG8MWSEt+2V 9CxC1gc24kPC7ZHZP4Gb05A6vaHARqRrzHh5s0PkiOKno2tHM/smvU9g05D0UCxTaww0 Hpd6XTCxrlkTvjgmlY0mR6tNz337m7a7WN56BvuIwHJvtIvnHZU7UW+xr45KKGNmKMnT L1MA== X-Gm-Message-State: AO0yUKX3oLTEc0AsE6NrwFMSssqE+nOD94FG0I5q5tSOCSO/S39gzIa5 MPMemMD/hVbYu0pllwpaYluWAwuR1kc= X-Google-Smtp-Source: AK7set9aVNolSfZ5B7wY+yU2TBtltPuGvaaQxhNm58gbkUNfVSUWQzncSkD6DTmMoniaMFroX1++Pw== X-Received: by 2002:adf:e9d0:0:b0:2c9:12dc:260 with SMTP id l16-20020adfe9d0000000b002c912dc0260mr9447826wrn.33.1678231639172; Tue, 07 Mar 2023 15:27:19 -0800 (PST) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id e5-20020a5d5945000000b002c3f9404c45sm13575585wri.7.2023.03.07.15.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 15:27:18 -0800 (PST) Message-ID: <6407c856.5d0a0220.af5c8.50f9@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 7 Mar 2023 19:03:45 +0100 From: Christian Marangi To: Andrew Lunn Cc: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH 11/11] arm: mvebu: dt: Add PHY LED support for 370-rd WAN port References: <20230307170046.28917-1-ansuelsmth@gmail.com> <20230307170046.28917-12-ansuelsmth@gmail.com> <70a38eb2-7ade-4474-8e1a-f18e99d45977@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70a38eb2-7ade-4474-8e1a-f18e99d45977@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_152723_228826_C6B177A6 X-CRM114-Status: GOOD ( 19.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 08, 2023 at 12:20:17AM +0100, Andrew Lunn wrote: > On Tue, Mar 07, 2023 at 06:00:46PM +0100, Christian Marangi wrote: > > From: Andrew Lunn > > > > The WAN port of the 370-RD has a Marvell PHY, with one LED on > > the front panel. List this LED in the device tree. > > > > Set the LED default state to "keep" to not change any blink rule > > set by default. > > Hi Christian > > What board are you using for testing? It would be good to patch its > .dts file to enable its LEDs. We don't normally had new code without a > user. > ipq806x, my specific device is not present upstream but we have a rb3011 that currently use the qca8k dsa switch upstream. If needed I can add support there by checking the leds supported... Also looking at the dt I think I need to use "port - 1" after all since it does use legacy way... Sad me... -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel