From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74B61C74A44 for ; Wed, 8 Mar 2023 19:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rJxj+l5KIFa+9YQ4ALSvodzTyAOSWYMhCyU718/odMo=; b=azOtPg9iN3W87q A+s4e+CD3ysIaa2wRUw0V3xBZfIgcug+g5GUJrZsAIlepmT6xYrgqGKefQY5ztKMaqmHCuckAg0VK 24UolgNbvwz3RmB6sqcnntcW2Gvp/6JeunCHnxW+NEaVpF4o0QR5bCnUfc2C9tFoy5v2bfyAe6nox aYVZCq3WzRe6j5Q6qDueybCdbJAeaPIJ8NqLkwXp7BIILtloe01BMgekefSEuNhBq3/Y7L6TFZYk1 80qe5WfKlqiReTuu5LD4kdc++VlZNhn4pQ6zupUbiRxdfaaj0dBj5ThWUFG6rjQIiBhGGcoqY74u1 08pHxYVVcu34Ir7wgdsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZz3X-006T5g-RJ; Wed, 08 Mar 2023 19:02:32 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZz3Q-006T2J-OB for linux-arm-kernel@lists.infradead.org; Wed, 08 Mar 2023 19:02:29 +0000 Received: by mail-wm1-x333.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso2041091wmb.0 for ; Wed, 08 Mar 2023 11:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678302141; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=05QzLCa5h8/aBiXa5wFiBBm9rgGF1oYVgKluk4jSojQ=; b=jRN+w1BizFV7AwJHwQ1qGQ7AE8UH2M0msGXp50Cyr7labckXet1D1eQ7IiYUKN+e/h RF/oE1CWGx4Y9OjHJBc6fvXPK/E3NPjdZLI99Z548YUtMEHyxP69ZyJ19+LF7aMK0hXu 3C2COWA1wyrd9tmF7SYmUekJhYam9V+tcgS5kp58R49RM/hqPVOjLpWP/N/l9FqEcGAY lLmGrBlvGp60bJ8H6uRIP0KrXIHliZqxQI86zJZ09vJQ5H7/I7dQkL9SQMFqf3FjN5R7 L23P16SUPomcoLK+msyy5ViCIAk+SvIaFjKECqL+6pY+CpNahGYSdvca5SN+QdFFbtS0 hhTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678302141; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=05QzLCa5h8/aBiXa5wFiBBm9rgGF1oYVgKluk4jSojQ=; b=XAJwxd+4oDwkFaoI1F6S4OD8/U0nQlvXs8CqVR2PsiCDYwvzxN1thvp7UQA1nANMJg xya+z+XryyiO8x0LRNfpzdLtM/i6UDQIwUNgp2t2AshgASqhttemptJzmBtIjZsh4WjE CbjXuLMQ+/T7Xsy8kHCsIvxxxW75TOEclElxKUb+3p18YnOlftWJwXJkBwkMyYjX3qvY hKG9esSUKNRuLzAWRPNa04rjqoxgj8cpVXz6/ZF1JM5JqoCb6V+ExxhPyKY1Om/kK0To 9uC69SoZumgkO04y22cioPKQzE6y0/VEOP2+Pz7/XR3HlsGgXjPT4thd7fwvv+3DpD3p jrdA== X-Gm-Message-State: AO0yUKXNBlkOlOS6b9ieCf1vyy2gQwy27b49ydu/FKhBK/OOF7IDCnNL u+vjoICxJHtDvfzVQh7DxVQ= X-Google-Smtp-Source: AK7set9hoVq9qbS24mVE0Dp6UKPSHIlBpzT3sWahFNF0J3P+44HP9t0tKqS27UMLF8wN68SNGI6VqQ== X-Received: by 2002:a05:600c:4fc5:b0:3ea:f0d6:5d37 with SMTP id o5-20020a05600c4fc500b003eaf0d65d37mr16838323wmq.8.1678302140499; Wed, 08 Mar 2023 11:02:20 -0800 (PST) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id a14-20020a1cf00e000000b003e21f20b646sm278516wmb.21.2023.03.08.11.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 11:02:19 -0800 (PST) Message-ID: <6408dbbb.1c0a0220.a28ce.1b32@mx.google.com> X-Google-Original-Message-ID: Date: Wed, 8 Mar 2023 20:02:17 +0100 From: Christian Marangi To: Krzysztof Kozlowski Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH 09/11] dt-bindings: net: dsa: qca8k: add LEDs definition example References: <20230307170046.28917-1-ansuelsmth@gmail.com> <20230307170046.28917-10-ansuelsmth@gmail.com> <5992cb0a-50a0-a19c-3ad1-03dd347a630b@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5992cb0a-50a0-a19c-3ad1-03dd347a630b@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_110224_843313_48F2F6F0 X-CRM114-Status: GOOD ( 24.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 08, 2023 at 07:49:26PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2023 14:57, Andrew Lunn wrote: > > On Wed, Mar 08, 2023 at 11:58:33AM +0100, Krzysztof Kozlowski wrote: > >> On 07/03/2023 18:00, Christian Marangi wrote: > >>> Add LEDs definition example for qca8k Switch Family to describe how they > >>> should be defined for a correct usage. > >>> > >>> Signed-off-by: Christian Marangi > >> > >> Where is the changelog? This was v8 already! What happened with all > >> review, changes? > > > > Did you read patch 0? > > > > We have decided to start again, starting small and working up. This > > patchset just adds plain, boring LEDs. No acceleration, on hardware > > offload. Just on/off, and fixed blink. > > Sure, but the patch is carried over. So what happened with all its > feedback? Was there or was not? How can we know? > The history of the old series is a bit sad, not enough review, another dev asking for a different implementation and me doing an hybrid to reach a common point (and then disappear intro oblivion)... Short story is that this current series have nothing related to the HW offload feature and only in v7 it was asked to put the LED nodes in ethernet-phy.yaml I can put in the cover letter of v2 of this series the changelog of the previous series but they would only be related to other part that are not related to this. Just to give you some context and explain why the changelog was dropped. > > > > What do you think makes the patchset is not bisectable? We are happy > > to address such issues, but i did not notice anything. > > I didn't write anything like that here... > -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel