From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00D5AC74A5B for ; Fri, 17 Mar 2023 14:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0n3JkITZWuidUyxiuw+1nDP+9UKsHjk9Qqi1RrhBIVc=; b=lv/JbiqAd4fdRg nxM5dpoLwqJtp+cj9gYu/AoH/6tdWNl8kiN0HRSKILWijLzAuDYxGgZOdf5T9iACKZzX0QgZv68fM YJqyUE1mxCviT+B1gPsecDPVzsYUDIdkOsWBbBdEwgdrIlAsiFjoX0L3SNtc06WgfQF65ST5W0hdC x2Qg+4w2ERVuJODGfxmmRmecYuKOpDd4120hfOG4vhvSDQLauIB23nCZ8vdSkOVeZ6sGY9dyeZmfO BVVDKytGKVO5yr3g4hOTMXrgdAxC5lkuWHQWgnXK2++jEjwCVGcLNqXocl7ftLJ5L9aeF61rwuElS 07lzepOlutKOgv3qsYCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdAg2-002OZA-0m; Fri, 17 Mar 2023 14:03:26 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdAfw-002OXW-2i for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 14:03:25 +0000 Received: by mail-wr1-x436.google.com with SMTP id h17so4520944wrt.8 for ; Fri, 17 Mar 2023 07:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679061796; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=woQ7p/4j+dQV7W5qSwH4t85I/oQFLj6/QY2SjRB5cNM=; b=AxtYotNPPWcqMRyYqJgOFK0siL7A02+6sg45DxspnTvvIlbsL/wSTtQfkF1yiKDRNT 75L2lVXLSIVEuTBF2AopU5XNrOXNPyo4J778wFYo5j9nAxFxYCLynDstBIXuc2RgpxUD vGcue06i/6v4BysQnqt9Y+fueAih5NnJbCKVrVu901pWYJVTWH/6xV19WAYoclS99IIs Nf7n5Dok+n6xfHUwjO8pnFkD5hmM2tDFgj/bpjCRWv4qtmXqS7IZfA5pN0h+rjJhp2pu 3UsbAeBt3OLbOOn0k2EdgwVseIqGz/7cWEPP64mjha0gGyAqSdE9KPIS6/eGJe1MITIq IVYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679061796; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=woQ7p/4j+dQV7W5qSwH4t85I/oQFLj6/QY2SjRB5cNM=; b=f3mNVfrpVryKA9cXFSK1lH1BZMYQ78cNqNe4sZGm0PUvBimLMuGtJ/Cez8TxhS1udl JkqEIH3Fb4KVXO+UG0gnsSt2k9zDddXxYfPZI8vDLJBlMsrX5NuGyF6v0eMnawJF3FrW lB6azlDdTycVy+KW3ZBQhg8SvjVIeVRns3br4DBLKh93DOoCS7gixHK04kYo6y9Xmzue YjkfzGBJoHynBtKYIqUpu0fUOVcHLAaCeIcz/ifxQWO+scZE5gDhI6n6Fk/LFK1OvWAc u6EChxexfPfldfjTtFuhNeS2HkDS0q5Gqeox9YfetpDluRv0oOWKnVgaB9FEbVuJ7+78 TukA== X-Gm-Message-State: AO0yUKVgf7gDbPBD8DrTPJRnygDhXSJby3AhffE03DsjlhaXn4HrGS7L i8An0wqmbPUaQxKuvN9E88Q= X-Google-Smtp-Source: AK7set8kqOMFiLuMAuGl1FLmfafbrSpiyxgdZ/tzXHkg0A5VEQEx5qi5dDb/E7Y2WsepFWS/CVk2Cg== X-Received: by 2002:adf:de90:0:b0:2ce:aed4:7f22 with SMTP id w16-20020adfde90000000b002ceaed47f22mr7667054wrl.50.1679061795678; Fri, 17 Mar 2023 07:03:15 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id c10-20020adffb0a000000b002c70c99db74sm2024167wrr.86.2023.03.17.07.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 07:03:15 -0700 (PDT) Message-ID: <64147323.df0a0220.5d6df.c863@mx.google.com> X-Google-Original-Message-ID: Date: Fri, 17 Mar 2023 15:03:12 +0100 From: Christian Marangi To: Michal Kubiak Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v4 03/14] net: dsa: qca8k: add LEDs blink_set() support References: <20230317023125.486-1-ansuelsmth@gmail.com> <20230317023125.486-4-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_070320_884388_432CC08E X-CRM114-Status: GOOD ( 26.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 12:54:09PM +0100, Michal Kubiak wrote: > On Fri, Mar 17, 2023 at 03:31:14AM +0100, Christian Marangi wrote: > > Add LEDs blink_set() support to qca8k Switch Family. > > These LEDs support hw accellerated blinking at a fixed rate > > of 4Hz. > > > > Reject any other value since not supported by the LEDs switch. > > > > Signed-off-by: Christian Marangi > > Reviewed-by: Andrew Lunn > > --- > > drivers/net/dsa/qca/qca8k-leds.c | 38 ++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/drivers/net/dsa/qca/qca8k-leds.c b/drivers/net/dsa/qca/qca8k-leds.c > > index adbe7f6e2994..c229575c7e8c 100644 > > --- a/drivers/net/dsa/qca/qca8k-leds.c > > +++ b/drivers/net/dsa/qca/qca8k-leds.c > > @@ -92,6 +92,43 @@ qca8k_led_brightness_get(struct qca8k_led *led) > > return val == QCA8K_LED_ALWAYS_ON; > > } > > > > +static int > > +qca8k_cled_blink_set(struct led_classdev *ldev, > > + unsigned long *delay_on, > > + unsigned long *delay_off) > > +{ > > + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev); > > + u32 mask, val = QCA8K_LED_ALWAYS_BLINK_4HZ; > > + struct qca8k_led_pattern_en reg_info; > > + struct qca8k_priv *priv = led->priv; > > + > > + if (*delay_on == 0 && *delay_off == 0) { > > + *delay_on = 125; > > + *delay_off = 125; > > + } > > + > > + if (*delay_on != 125 || *delay_off != 125) { > > + /* The hardware only supports blinking at 4Hz. Fall back > > + * to software implementation in other cases. > > + */ > > + return -EINVAL; > > + } > > + > > + qca8k_get_enable_led_reg(led->port_num, led->led_num, ®_info); > > + > > + if (led->port_num == 0 || led->port_num == 4) { > > + mask = QCA8K_LED_PATTERN_EN_MASK; > > + val <<= QCA8K_LED_PATTERN_EN_SHIFT; > > + } else { > > + mask = QCA8K_LED_PHY123_PATTERN_EN_MASK; > > + } > > Could you add a comment as to why the HW requires different approaches for > inner and outer ports? > Will add some comments, but for reference, it's really just how the switch regs setup these and provide access and configuration from them. phy0 and phy4 are in a reg, phy1-2-3 are in a separate table with different shift and mask. > > + > > + regmap_update_bits(priv->regmap, reg_info.reg, mask << reg_info.shift, > > + val << reg_info.shift); > > + > > + return 0; > > +} > > + > > static int > > qca8k_parse_port_leds(struct qca8k_priv *priv, struct fwnode_handle *port, int port_num) > > { > > @@ -149,6 +186,7 @@ qca8k_parse_port_leds(struct qca8k_priv *priv, struct fwnode_handle *port, int p > > > > port_led->cdev.max_brightness = 1; > > port_led->cdev.brightness_set_blocking = qca8k_cled_brightness_set_blocking; > > + port_led->cdev.blink_set = qca8k_cled_blink_set; > > init_data.default_label = ":port"; > > init_data.devicename = "qca8k"; > > init_data.fwnode = led; > > -- > > 2.39.2 > > > > > Thanks, > Michal -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel