From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4296EC7618A for ; Sun, 19 Mar 2023 01:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=guqT+HNIigH/JRBfTK2l9F3z6pAyU+Qi6ICdu0J2fVg=; b=i1RpoNeauk7tTQ qOOvTCLdkaW9a3UP5FA8/KxgLV627FASCpXufDaZFnxrjlsRKJ9GEzrCUhtR0dQI3w9xMC82ic27L I7rp83u5E/lerDIO0MAElB+J5x0sXIxTRkB2QVn7gwNngwyresILBgwJ4GeEeEwyx4DeAvtdi+Z0q m/u5fBpBg+Dej+TjGA8qNUbIPXXKug8pTNGn4yVj13gNY3qtSu5ft375gtvvDI1YZvkaeQFB5wDkL QPweS+RHFQCvcFH4uk3xpUt/Itg1MfhrmTwFXMttzwGuVNvcciEfGQXq6I2tUHvxMZtMkz7A4kdkY Vp2o5P5aFhpaztA+ygOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pdhru-005muP-2r; Sun, 19 Mar 2023 01:29:54 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pdhrs-005mtz-08 for linux-arm-kernel@lists.infradead.org; Sun, 19 Mar 2023 01:29:53 +0000 Received: by mail-wr1-x42a.google.com with SMTP id m2so7436069wrh.6 for ; Sat, 18 Mar 2023 18:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679189390; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=7lNKLSglj57JGHjYbKgUGYzeLKtJa3XagCtxeH4Gxm4=; b=g5O17/yYiF7MsLnYQxK8bZe0LAwOuHzL5sr6eFbXNwSyGweCfmV7ILJSe2i+6tpD2p zcXXRYps38ph7UNfwn2SUMseog4RyFZrAwDEHkZJBpbAigXbIZkFN0tAhgtSQz2cpchX +GKvf5rRiWpvhSfEzjlsS3k7Xp2FJexXDZ070kebeE8ejTm3P0Sd5x4xGfS9Bk/Jt59o drC+12zQtDlakn1NT6UysdZWoW/A/jHqwDsoZI86k8kFE86bUWxSP62zR7SiQW58dDlc q9tAFMso5QlvOOcR0V3LWddCRodHxt5KMGSbkofM3qH1o5HTyy1dFHu8q8R6skbtdvyZ 2H4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679189390; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7lNKLSglj57JGHjYbKgUGYzeLKtJa3XagCtxeH4Gxm4=; b=Fzubqu0ZTkudG3t+ktX5nWsMU3xzrjO+0cnZ4vhSIrdjmr1JzE/lEq/4Ihk7COtXyi OgjURUS2vkrD5KIIPccY3jRjg7F7cVKN3cyzXohNmmys4ryxY8pwcuWCng7BMv2OVz4u pPxp3W2n4xg4CTrigj9R3yoOTsWiTmqrrDWAgkDdUhU5v3QK6vY6Ve6F+2GoNyMzZV5o jyH/6/HLm2jmJ2Ng2KiEOYCkhB4av3LuY0YugzoM5LKCxHGw91D0OXYcGivmf4o2v3P+ 7DwD5NTbC+AhbVDJ2I/rTJJdZD8sZ/8KFCjSYjh4kXcApmzleAQG+MZHWT0R8Yw4VwZH 27sw== X-Gm-Message-State: AO0yUKW0muNs3sYsXWH1ULK1LKSVdQjpws4wMokOmA6iiZpesn8AzI13 A74ISIGLbbx7aWnHBjHe13I= X-Google-Smtp-Source: AK7set/9UCz7mWqjurM1eC1cM6R+T7hiebwpTUU846InJ+Uk33AlEslf61PrYT3Hy0tDT6LDr31DuA== X-Received: by 2002:a5d:4ed0:0:b0:2d2:22eb:824a with SMTP id s16-20020a5d4ed0000000b002d222eb824amr6706787wrv.34.1679189389654; Sat, 18 Mar 2023 18:29:49 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id b18-20020adff912000000b002c567881dbcsm5440215wrr.48.2023.03.18.18.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 18:29:49 -0700 (PDT) Message-ID: <6416658d.df0a0220.cb6f6.f5d2@mx.google.com> X-Google-Original-Message-ID: Date: Sat, 18 Mar 2023 20:14:21 +0100 From: Christian Marangi To: Michal Kubiak Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v4 03/14] net: dsa: qca8k: add LEDs blink_set() support References: <20230317023125.486-1-ansuelsmth@gmail.com> <20230317023125.486-4-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230318_182952_105218_3864CDED X-CRM114-Status: GOOD ( 26.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 17, 2023 at 12:54:09PM +0100, Michal Kubiak wrote: > On Fri, Mar 17, 2023 at 03:31:14AM +0100, Christian Marangi wrote: > > Add LEDs blink_set() support to qca8k Switch Family. > > These LEDs support hw accellerated blinking at a fixed rate > > of 4Hz. > > > > Reject any other value since not supported by the LEDs switch. > > > > Signed-off-by: Christian Marangi > > Reviewed-by: Andrew Lunn > > --- > > drivers/net/dsa/qca/qca8k-leds.c | 38 ++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/drivers/net/dsa/qca/qca8k-leds.c b/drivers/net/dsa/qca/qca8k-leds.c > > index adbe7f6e2994..c229575c7e8c 100644 > > --- a/drivers/net/dsa/qca/qca8k-leds.c > > +++ b/drivers/net/dsa/qca/qca8k-leds.c > > @@ -92,6 +92,43 @@ qca8k_led_brightness_get(struct qca8k_led *led) > > return val == QCA8K_LED_ALWAYS_ON; > > } > > > > +static int > > +qca8k_cled_blink_set(struct led_classdev *ldev, > > + unsigned long *delay_on, > > + unsigned long *delay_off) > > +{ > > + struct qca8k_led *led = container_of(ldev, struct qca8k_led, cdev); > > + u32 mask, val = QCA8K_LED_ALWAYS_BLINK_4HZ; > > + struct qca8k_led_pattern_en reg_info; > > + struct qca8k_priv *priv = led->priv; > > + > > + if (*delay_on == 0 && *delay_off == 0) { > > + *delay_on = 125; > > + *delay_off = 125; > > + } > > + > > + if (*delay_on != 125 || *delay_off != 125) { > > + /* The hardware only supports blinking at 4Hz. Fall back > > + * to software implementation in other cases. > > + */ > > + return -EINVAL; > > + } > > + > > + qca8k_get_enable_led_reg(led->port_num, led->led_num, ®_info); > > + > > + if (led->port_num == 0 || led->port_num == 4) { > > + mask = QCA8K_LED_PATTERN_EN_MASK; > > + val <<= QCA8K_LED_PATTERN_EN_SHIFT; > > + } else { > > + mask = QCA8K_LED_PHY123_PATTERN_EN_MASK; > > + } > > Could you add a comment as to why the HW requires different approaches for > inner and outer ports? > Since they are really the same thing, I added a big comment that explain how the thing mask shift and reg works and why in the brightness_set function. > > + > > + regmap_update_bits(priv->regmap, reg_info.reg, mask << reg_info.shift, > > + val << reg_info.shift); > > + > > + return 0; > > +} > > + > > static int > > qca8k_parse_port_leds(struct qca8k_priv *priv, struct fwnode_handle *port, int port_num) > > { > > @@ -149,6 +186,7 @@ qca8k_parse_port_leds(struct qca8k_priv *priv, struct fwnode_handle *port, int p > > > > port_led->cdev.max_brightness = 1; > > port_led->cdev.brightness_set_blocking = qca8k_cled_brightness_set_blocking; > > + port_led->cdev.blink_set = qca8k_cled_blink_set; > > init_data.default_label = ":port"; > > init_data.devicename = "qca8k"; > > init_data.fwnode = led; > > -- > > 2.39.2 > > > > > Thanks, > Michal -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel