From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E46D0C6FD1D for ; Mon, 20 Mar 2023 17:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YgH1OqqmBLogH3TZCmMwQrN3ZoUBs4TpWiAgxAcM2SE=; b=YXzQiC+Kz6asjF 9J1qfUBtUjfg/bJjQrcMQhjj9taRMRAMvdADjsxa0eIU86q8GrkHgogSXjXrVSAyO9Tblrogy4u3W vgisY6IJjzp6cLoGOpruOWqbHKb+HrtHFQwg9SAGlZQz9H7YekUL9kB/vTIEVtrDRhanVP4qC8ixG DOiTww+UHilUQnsSOCJp0hetw1VBuXnyYRqacDHz4FThrJCmj6qF9+Hj+1EsxL+TDFMDaQI0rH0Bh SgOmOw6f6krqWfkyWPreQ9LVisxi7Kmenu0TBo0H3p6TXm9esdOPkz3Bdqhlgc599OhSkYENvLUDU IaXzGJVf/MwOmuDgpRAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peJgm-00A3Dt-1n; Mon, 20 Mar 2023 17:52:56 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peJgj-00A3B8-1a for linux-arm-kernel@lists.infradead.org; Mon, 20 Mar 2023 17:52:54 +0000 Received: by mail-lf1-x12e.google.com with SMTP id j11so15937811lfg.13 for ; Mon, 20 Mar 2023 10:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679334771; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=gjtrDHad5ipWXlVxyz0QsRXZabwmk49CGaT/vOXTHf0=; b=p3/toevd5cdAOFepc8U00wh0VujMAkg5H7hvY28RJO9BNGcXHu3xtQrR7NEQi87jVs fkinGfek9kZf9uraGEp9BXsdLLKyFT2O9mHG6tZE12ujpH0ckqd2PShBcKvtgOtbg0Cl S2ROq9DrNBEy4ic071UXERs0rTz0lyUdDBHyHW9Biapd/rTkmSgtlad5e9XC2kAce1xF C9MyghrxNHFppuaXg5ZY1LKBioZKaTNPHJbSvG5sge9pEl0JFptIBDfpg9tqO8013rO+ CM3dtBJbTMG++uwx2ntapkpECg6C3vDD+GWUoGmqw/KHFK80czd8KPXiku5ofw45xiu3 MrKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679334771; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gjtrDHad5ipWXlVxyz0QsRXZabwmk49CGaT/vOXTHf0=; b=jiDSwnaxz0zxsbd9xMVXkcxJTN2+1vwHNYoJ6y3OjcyBA0mzpXq3sf8Tv904n08OdY nqot8lWRXvbsr13DxVlzzQUAh3DxqjgqF0pxBbjraH8sI2SwHzf5UcaeqqP0PjGZRq6w F705dL2iWzfCw/08VLOtTPQaBuzGLiTfZeVciDmrlaC8uGDCu9upEIhsfKPFStzda8EK D7kTn38tx1jzw1kyTgwxWi0XfpdAez6YVtUsGiU7H/4ZfcVFXblKNEGIpn4SWMM5C5O7 5bCcCYA4wOGPmmESfq+1ImpH+HIufatzdzhKPyqB0htKdhk9tUVj10K4WoRRlrvfyake deKQ== X-Gm-Message-State: AO0yUKUGl4t+uEbcQaZ6ixCxHBkENlEZI7J4DZMR8icA2vroliqDOjx9 QGTYC2u5T+QhTvZXfRn15Fs= X-Google-Smtp-Source: AK7set9IgQpjLnKLnivs0dm+tDOD+Xi6seUQ4pg7hGKKZTtq+nmT30KTq7k4NiYmLFVewzs6Fr/zNw== X-Received: by 2002:ac2:4830:0:b0:4e9:cfd2:e2d with SMTP id 16-20020ac24830000000b004e9cfd20e2dmr192306lft.65.1679334770529; Mon, 20 Mar 2023 10:52:50 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id t8-20020a19ad08000000b004a9b9ccfbe6sm1802168lfc.51.2023.03.20.10.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 10:52:50 -0700 (PDT) Message-ID: <64189d72.190a0220.8d965.4a1c@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 20 Mar 2023 18:52:47 +0100 From: Christian Marangi To: Andrew Lunn Cc: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 04/15] leds: Provide stubs for when CLASS_LED is disabled References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-5-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_105253_548958_DA77D06F X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 19, 2023 at 11:49:02PM +0100, Andrew Lunn wrote: > > +#if IS_ENABLED(CONFIG_LEDS_CLASS) > > enum led_default_state led_init_default_state_get(struct fwnode_handle *fwnode); > > +#else > > +static inline enum led_default_state > > +led_init_default_state_get(struct fwnode_handle *fwnode) > > +{ > > + return LEDS_DEFSTATE_OFF; > > +} > > +#endif > > 0-day is telling me i have this wrong. The function is in led-core.c, > so this should be CONFIG_NEW_LEDS, not CONFIG_LEDS_CLASS. > Any idea why? NEW_LEDS just enable LEDS_CLASS selection so why we need to use that? Should not make a difference (in theory) Anyway hoping every other patch and Documentation patch gets some review tag, v6 should be last revision I hope? (so we can move to LEDs stuff) -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel