From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A174AC74A5B for ; Tue, 21 Mar 2023 15:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iTFhZRbt2t1zTxot8qEVoVbiMc0s6PPdr5e2NTwBnv0=; b=fLROmbvUJalIhk Z7fyRq1VcaLQYInfLcUcKCpHaeII2dZGaxnpOHX5JeKfTmAiikW2eFxSxXhtH7CVj2wuTntoYpKD5 Mh9qn9rHNqV9nVYd+OibxmW+yLB7tQ7IQyowbbPACsG45cqgAU3lkcpcZyVlAhR/2ZiMExVFY1ivu KnCBf+P5g1ag5Snq0BzQ5TpHZkHx1DwO9aZfYO0A0Kz9dLsOb9w1GPcCP6i155K0YmfF3zSZag4HI zezkZ9LJqpjyKEkrN5TuMBn0stnWRa4DuxpC90jDRQpQUN7114KiMKJlz6EHgkYOASF9rGl65TACy MHkfxsc9b0/JO9OgCwrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peeB7-00CyZW-2Z; Tue, 21 Mar 2023 15:45:37 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peeB4-00CyYx-09 for linux-arm-kernel@bombadil.infradead.org; Tue, 21 Mar 2023 15:45:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bgXEnYwzn/S6BlOb++Eaqru+i6YXyzKGwwPJBmaxtD4=; b=EGO7QRn1uAZHVNcUkBol5pmk6q rM9xp3inWkRytqefa7aYAFAj9A3sXI/Mey+gDlJZ/2TuK6iOirUg4Xdscd/cM4PtSkOqe0she1oqX RXdcG1e10iKxfJWjmWYLNDbU3Eux3fygZpla5/zlcWWU6pJ/0VedwHNElmyB1ocBfLHw8NbXC35Xq H8qhNX1eOl0cyVkYtWcs0Wjr2VLD6S66MWhO/BVzMdNkkYxhI4Rpz5idOQ6//WEFbDc7phEd7Fmwm eTtBGzzkecQXy+Mx8OUTaGAw4WM++LHgQ5wKyq2Hze9L16HX8qhLqpB5Goh8sdZ9J0nTvh57iprJF mZmAi3pw==; Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pedRX-004HpW-1x for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 14:58:33 +0000 Received: by mail-wr1-x42a.google.com with SMTP id i9so14005022wrp.3 for ; Tue, 21 Mar 2023 07:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679410703; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=bgXEnYwzn/S6BlOb++Eaqru+i6YXyzKGwwPJBmaxtD4=; b=ga4YMD0irqHN4ilQrJ2QMVEbWHArwcWv2PG1FGLGI3et3uRUC94zk6BZpYLXtYwFfq Ww9fw7+pA7jFvc7QMMl9umhdWEA/kXceI4gCT4ZS+u6cf5+k8wZDH1mBjOQF2IZwG0eP BbF2RgvFUaLtqL8bqcA2Zc3372cO+99MGl3tVQ4B1oDiwwkK2/0cyJ9S8MYkfaLa2oaM 7HxJWl67A3Jb7WSMyAi9EIoCBfiTwvWCOacUirjCW8pP1pNszz6QJU7mkI3miHldqUgt Enrh0ZOQr8wcVepDFsJOkm3WoNuy9MeBo+P0WBP6DG/Eu1lLdMhF71YyTtIOzp8Xc7lc HGpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679410703; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bgXEnYwzn/S6BlOb++Eaqru+i6YXyzKGwwPJBmaxtD4=; b=A7l5XOYhAuX0MSvgArSLMDfpWzgNgJjUMjT5HZ7KYzaH5sM58KF63dExcnqh/UExh0 dNnRTWy8Gslao5CFH4bMzsrKmktNXbf5zmEXPUIxOL73rnnI17C4CxEv/TJ/5Ya6aDQc htxi48NAZZXVtjWWlgcxeXR6ZZy3o5cMU3KWL94jjGT3LVs5BlJ2hCqn8eZkbU4OAH3t G2FOwAiCk8m3riFeyDT1AAN3KCAIziYk1gjKZwH63FrsIt1n8Q9cgRl/aaHy6ADmPmeg dFexaxExfJohwe2n/ceQ3Qs8GAFW+ggRcPd58bWjCeeNF2ubKUuADK8MwIsZcQfLSPLs r4Xw== X-Gm-Message-State: AO0yUKWvHogGcM7eJv9vA6Hyb9FH1WnkZ4c1o9hdJ14shp7ivjI++CZG DWiF8U3q4A8vw+YJVbP4wbQINravPQ8= X-Google-Smtp-Source: AK7set+K7ppr5kVHCtHkrUaYjB+7uxp7G1eEctUkA+c9/tYtmX8WRNtLlnpL/VsrO7ZBl1mm/ABfEA== X-Received: by 2002:adf:f2c8:0:b0:2d2:22eb:824a with SMTP id d8-20020adff2c8000000b002d222eb824amr2419295wrp.34.1679410702538; Tue, 21 Mar 2023 07:58:22 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id d5-20020adfef85000000b002cfed482e9asm11556989wro.61.2023.03.21.07.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:58:22 -0700 (PDT) Message-ID: <6419c60e.df0a0220.1949a.c432@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 21 Mar 2023 08:55:14 +0100 From: Christian Marangi To: Andrew Lunn Cc: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 04/15] leds: Provide stubs for when CLASS_LED is disabled References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-5-ansuelsmth@gmail.com> <64189d72.190a0220.8d965.4a1c@mx.google.com> <5ee3c2cf-8100-4f35-a2df-b379846a8736@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5ee3c2cf-8100-4f35-a2df-b379846a8736@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_145831_762247_BA9822F2 X-CRM114-Status: GOOD ( 23.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 20, 2023 at 08:31:36PM +0100, Andrew Lunn wrote: > On Mon, Mar 20, 2023 at 06:52:47PM +0100, Christian Marangi wrote: > > On Sun, Mar 19, 2023 at 11:49:02PM +0100, Andrew Lunn wrote: > > > > +#if IS_ENABLED(CONFIG_LEDS_CLASS) > > > > enum led_default_state led_init_default_state_get(struct fwnode_handle *fwnode); > > > > +#else > > > > +static inline enum led_default_state > > > > +led_init_default_state_get(struct fwnode_handle *fwnode) > > > > +{ > > > > + return LEDS_DEFSTATE_OFF; > > > > +} > > > > +#endif > > > > > > 0-day is telling me i have this wrong. The function is in led-core.c, > > > so this should be CONFIG_NEW_LEDS, not CONFIG_LEDS_CLASS. > > > > > > > Any idea why? NEW_LEDS just enable LEDS_CLASS selection so why we need > > to use that? Should not make a difference (in theory) > > 0-day came up with a configuration which resulted in NEW_LEDS enabled > but LEDS_CLASS disabled. That then resulted in multiple definitions of > led_init_default_state_get() when linking. > > I _guess_ this is because select is used, which is not mandatory. So > randconfig can turn off something which is enabled by select. > > I updated my tree, and so far 0-day has not complained, but it can > take a few days when it is busy. > BTW yes I repro the problem. Checked the makefile and led-core.c is compiled with NEW_LEDS and led-class is compiled with LEDS_CLASS. led_init_default_state_get is in led-core.c and this is the problem with using LEDS_CLASS instead of NEW_LEDS... But actually why we are putting led_init_default_state_get behind a config? IMHO we should compile it anyway. So my suggestion is to keep the LEDS_CLASS and just remove the part for led_init_default_state_get. Also why IS_ENABLED instead of a simple ifdef? (in leds.h there is a mix of both so I wonder if we should use one or the other) -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel