From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFE36C6FD1D for ; Tue, 21 Mar 2023 16:15:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9TCKOBE48YlO/kceKY8viKvQ8sZnnpHCs4OGKy3spdM=; b=Gh6FH1oDKg3ltB 2TiHTH7o/6D9pX4ihuzRXrN1y/km9LmTM6FElV2jD7C2GUjLvw7kuc6YWIkHpZ9BIiJ+51Yv4ZATx fOtubpVDTdq7y+JuQxP6SAptjnwm/6d81XHW3LF/y6w3RT8yRgp4sQvzpeK/VRzP/PBD4GvMRjUEz r9Ha8HDgsg5YjofK7Q6HGraGM8tpQaiLGcBod/KgMLPrMavsYk0SFeMiKZIJwd/QPDj9bw0qMA5Qk kv1Lnkhd8ySsdw67rtmzicEJYBXwij1mN9OVgEorQUjKvpWm5TLs8ipnKqI/bb+S49GuYs5M51HA4 +xGcP0mWK7sLZF/fdTgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peebs-00D2fZ-16; Tue, 21 Mar 2023 16:13:16 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peebn-00D2el-1M for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 16:13:14 +0000 Received: by mail-wm1-x329.google.com with SMTP id t17-20020a05600c451100b003edc906aeeaso926337wmo.1 for ; Tue, 21 Mar 2023 09:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679415188; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Pk7IjbqaJIEEKsGiYXSoq0xQcxrVnoZL7rQBDJ5gFyo=; b=JJlheVt73rKm0X/Gw5EvGnFVdk8pxIjDe6hawHWy6HG0j14Ml9yuCNNiCiGS1ElkJ4 FDwK7ikjHVH6cQbl9wbP0xFexbFxsKBHs4SD8312/HTB3efNEDVXoujQRUHFQbbQZNVr MyLoeXM5qvmqSdc0OV9luJJVf+TYLpfTBehyE96zatjk+fTa5/fG08zOWBqdzbeCV9HL almVUq1eF/p3WcHexcp36GQIGPzSz0to6oS51bS0uh995l9xehQQ3S0pdFNg81EmDprn OUicM5QjBLbRyR2KJ63JojA0PyGYFrWwHr7LbTDeEVU3icNgYAQwJeu2JMEfYTxYGB5e doTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679415188; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pk7IjbqaJIEEKsGiYXSoq0xQcxrVnoZL7rQBDJ5gFyo=; b=FSO6hld0BVffRUCFwkF/IpcEFNb4qehcbFntBYVbD/0T1om4+xaY0Jqi3oAyuCbAWh CGyMwpTXBFp7/9HLWcLDZKp3TwGZV93/018Rdb2289ZeD7X7E3Pon/YqlYMaBWq7K808 y+KUi2r3vV1RLDqLWjcfPl56YQb69Xd6y2EiY/rT7o7ZDf2y5dCNTTCY1TNWuxzmuGYB XEZXeqFxcQsj3k2OctP2OqsmOFlEbpM9kUONueJQYzDmoq0oalbGZ56rjxlp5/cEA7gS /pCNvQF7fvC6M1e0QBfb5lnsV6chB/Kxy0Uqz3idbQ5HgLc4q3B1tAHII7vTkmu+hDiJ 4XCA== X-Gm-Message-State: AO0yUKU8lATjBQkkaItGwJ49dzcwn+h2j2Y3SwgbViit9qXN+52AbQv9 KGT1zpvLWXTo5wxrXj6AydU= X-Google-Smtp-Source: AK7set/UHc3VryuQe4vmOCNthOI8y5hUPmcaxq9SL3XP9hauniO7Ssi4Bsnu4r6WzLO5iry5I/3gqg== X-Received: by 2002:a05:600c:2148:b0:3ed:af6b:7fb3 with SMTP id v8-20020a05600c214800b003edaf6b7fb3mr2942703wml.2.1679415188348; Tue, 21 Mar 2023 09:13:08 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id f26-20020a7bc8da000000b003ed2d7f9135sm13812938wml.45.2023.03.21.09.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 09:13:07 -0700 (PDT) Message-ID: <6419d793.7b0a0220.f0640.a82c@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 21 Mar 2023 17:13:06 +0100 From: Christian Marangi To: Andrew Lunn Cc: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 04/15] leds: Provide stubs for when CLASS_LED is disabled References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-5-ansuelsmth@gmail.com> <64189d72.190a0220.8d965.4a1c@mx.google.com> <5ee3c2cf-8100-4f35-a2df-b379846a8736@lunn.ch> <6419c60e.df0a0220.1949a.c432@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_091312_970180_831A85F0 X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 21, 2023 at 05:02:42PM +0100, Andrew Lunn wrote: > > BTW yes I repro the problem. > > > > Checked the makefile and led-core.c is compiled with NEW_LEDS and > > led-class is compiled with LEDS_CLASS. > > > > led_init_default_state_get is in led-core.c and this is the problem with > > using LEDS_CLASS instead of NEW_LEDS... > > > > But actually why we are putting led_init_default_state_get behind a > > config? IMHO we should compile it anyway. > > It is pointless if you don't have any LED support. To make it always > compiled, you would probably need to move it into leds.h. And then you > bloat every user with some code which is not hot path. > Ok think just to be safe we should wait one more day for the 0 day bot and then finally send v6? -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel