From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65C12C6FD20 for ; Tue, 21 Mar 2023 23:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R4dEedSJkdMn6c3IpdqvAdBJEoxfBpncSdjxBInIMMk=; b=lOkMuanNMgi9A8 h3AmVX2fjbLLW0imK/gOTZvnGCyHgt0O1oznnyttBGv/EX/gu3xi5oqI7YhLbPgUWhnIpVH7Wjp3w lotQ3cEud5pJeTVvj6RyGpGa2NVo0yS76vHFhkDyEN7UA31/UuDJkAXDXwpyhdO1ko50Fxp8NN8sI MDJR7RtuZMNTq6k7mdvtkwReYBv9o2YaCmjn/fzKcLqYLQKr9RPls2TnzD1yzx29sT0Qot7W681tf Xsv58SMwFlecbpyo6A9RqHV12019eMIWmpvxOWEc9J5jnglCUVnD597p8/WhbM2ns0odM53iny/Go bpcocE3WHZ3QKX6tlmyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pela9-00E5NJ-1g; Tue, 21 Mar 2023 23:39:57 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pela7-00E5MH-0q for linux-arm-kernel@lists.infradead.org; Tue, 21 Mar 2023 23:39:56 +0000 Received: by mail-wm1-x32b.google.com with SMTP id o40-20020a05600c512800b003eddedc47aeso4930077wms.3 for ; Tue, 21 Mar 2023 16:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679441991; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=jwfMZ6FsDD8+QlFgG9YSGQ+zSUs+XYTprVxYaYY4xCs=; b=bkBHelgXJwSgw9NZ5DcQ/rAeODyT2QbCZQWqLR3yhQe7qk2WtbX3WlX//JoMlB0gX0 lfalGUbwfgFGT4ELFVIjA759O+kKuqGQtJS87Vk0JPkszPWrW7TnHebl6ei2+oorMVhd Lc98meTC4oaHoutzsVkMwR95MIwhSE9MwDhFyknkqQPJcwG7O5IR8GeQyHr9MTD/9SGU pxFGpcTlofPElg4Phc7kkGzdUqKwVaBFHVxGp3tGJeLa84o6nDOEeypP1oikHYn+q7wR Jrtu2GEePEQfegjd54V3W5o2sm98uxNpYUTvOBLoOV3Ny09R0J74nwQSogF+VMIzc3FY 26XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679441991; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jwfMZ6FsDD8+QlFgG9YSGQ+zSUs+XYTprVxYaYY4xCs=; b=sYYmUTj6wvmG++8sn3t6vLmYmGRYFyoFzMup8VxAvK31irhAHG+rXxOr0km+cMPmsF JrI/9N/X4DIGJw0j3rUpSIkd7RLLjRePjYihpAKHbCHKLFI68XhtSyxMafbpozzettuT WEe35ohzRKYo01kjcanUNj06Qn1dBMl+FyhtYDAWtT7P3FZJvOZQbKhyNRy3V+CvOZX2 XFsXJpamZzmLHzL0JMmBsPlCVqijmM1fQO8HVPXIqYfPdojmna6UkaD+y118vrvjLFzW Pkmg7JkkQQPjpNzQvew8WjHRCvY70eo4UEL+Sq6K+Gcz1F0R37A2e1yzKoNc3uLbyk0t JbCg== X-Gm-Message-State: AO0yUKX/qJPzC/uUXaKgi1jYnTJ58tVEgsGFDVZG1GOXss1FocpEpoBN XUDYUY+jZaFk9GMVfruL90M= X-Google-Smtp-Source: AK7set/s45oboY6J1DqDB/0FL+87KkEyElGWJ9yuDvg1P5AEXq8dYBcKJ3L/B1aVpUVe1ob2ikoHEg== X-Received: by 2002:a7b:c7c4:0:b0:3ea:ed4d:38f6 with SMTP id z4-20020a7bc7c4000000b003eaed4d38f6mr3681988wmk.4.1679441991057; Tue, 21 Mar 2023 16:39:51 -0700 (PDT) Received: from Ansuel-xps. (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.gmail.com with ESMTPSA id l15-20020a7bc44f000000b003edef091b17sm7840916wmi.37.2023.03.21.16.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 16:39:50 -0700 (PDT) Message-ID: <641a4046.7b0a0220.44d4e.95d4@mx.google.com> X-Google-Original-Message-ID: Date: Wed, 22 Mar 2023 00:39:48 +0100 From: Christian Marangi To: Andrew Lunn Cc: Rob Herring , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Lee Jones , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v5 10/15] dt-bindings: net: ethernet-controller: Document support for LEDs node References: <20230319191814.22067-1-ansuelsmth@gmail.com> <20230319191814.22067-11-ansuelsmth@gmail.com> <20230321211953.GA1544549-robh@kernel.org> <641a35b8.1c0a0220.25419.2b4d@mx.google.com> <38534a25-4bb3-4371-b80b-abfc259de781@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <38534a25-4bb3-4371-b80b-abfc259de781@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_163955_298569_21BBC6FB X-CRM114-Status: GOOD ( 34.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 22, 2023 at 12:23:59AM +0100, Andrew Lunn wrote: > > > Are specific ethernet controllers allowed to add their own properties in > > > led nodes? If so, this doesn't work. As-is, this allows any other > > > properties. You need 'unevaluatedProperties: false' here to prevent > > > that. But then no one can add properties. If you want to support that, > > > then you need this to be a separate schema that devices can optionally > > > include if they don't extend the properties, and then devices that > > > extend the binding would essentially have the above with: > > > > > > $ref: /schemas/leds/common.yaml# > > > unevaluatedProperties: false > > > properties: > > > a-custom-device-prop: ... > > > > > > > > > If you wanted to define both common ethernet LED properties and > > > device specific properties, then you'd need to replace leds/common.yaml > > > above with the ethernet one. > > > > > > This is all the same reasons the DSA/switch stuff and graph bindings are > > > structured the way they are. > > > > > > > Hi Rob, thanks for the review/questions. > > > > The idea of all of this is to keep leds node as standard as possible. > > It was asked to add unevaluatedProperties: False but I didn't understood > > it was needed also for the led nodes. > > > > leds/common.yaml have additionalProperties set to true but I guess that > > is not OK for the final schema and we need something more specific. > > > > Looking at the common.yaml schema reg binding is missing so an > > additional schema is needed. > > > > Reg is needed for ethernet LEDs and PHY but I think we should also permit > > to skip that if the device actually have just one LED. (if this wouldn't > > complicate the implementation. Maybe some hints from Andrew about this > > decision?) > > I would make reg mandatory. > Ok will add a new schema and change the regex. > We should not encourage additional properties, but i also think we > cannot block it. > > The problem we have is that there is absolutely no standardisation > here. Vendors are free to do whatever they want, and they do. So i > would not be too surprised if some vendor properties are needed > eventually. > Think that will come later with defining a more specific schema. But I honestly think most of the special implementation will be handled to the driver internally and not with special binding in DT. -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel