From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D355C77B61 for ; Thu, 13 Apr 2023 14:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZZ51yjVEml0QRNnK4qvw0xQtylRrhfeiVHbCliG3Qkg=; b=CoOQXccRRSKlMc lpqP9GxzWY4/UvyE0r5vHsjFtTWXzi69XKHucB4OZayW3Hi8kqcHZvjgHpyEl7Nuvx5E9VNhGBpID 0JJMVIsc1Bn03GAL1TflADRjsdG66t1rX+3b4NgxK2QwGCYYxIQXjPd53rU52H+H6L9M892JoAcC8 gIwDszJ9TFDlIkNSR0DS1bUy1Xb5wumoKTzQxjqfs73pMWXgDElvhE9hJQSBLIadZjD1hRNvL1c8+ ONi4S9YlImIxMNoF/Cb9icGMVUZxFxIr2nvjIhVmO7GOFSrbX2hWnC0SBxxsdurxYH8RQeoUZBnzw jbrjfBD5Z032LDrz4D8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmxWJ-006Kwq-08; Thu, 13 Apr 2023 14:01:51 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmxWG-006KvR-1K for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2023 14:01:49 +0000 Received: by mail-wm1-x32a.google.com with SMTP id he13so13593592wmb.2 for ; Thu, 13 Apr 2023 07:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681394504; x=1683986504; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=uOHTamwKNL40GhmSChgfj+zLAbo8CbA29L61cgq0bpE=; b=G845KAhU6xI8AzEGleuaSgyKc/tkw+0l10Pgl2ql2iERI016euWl0ztj2Jtku9EWjE XzgnPXYm2rJ5Z6MWj7nAYfC0TKlTVvu7bv4z2MqcWqrmetcjpIngUnp/cep2byHpZyYy wlgwVKJvF7k2/EDrncZLO2rFwkZAogjbddoEBeGYvu6o0Qt2ztmcWk4RNW8DLOcKnIK3 wfWN5QSsuK82eE17Ihl+xdy7oZFgAyCUMSRmAUTwxWQ7A1LgOU7NiKfhUcyIPRxR7+WT w79ZWayhGjAHDH+kh6FgI26OuDeliCOPiPiMeY81WyzZd8y0tmrAOQb0oo6BPUmj+3d6 OJ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681394504; x=1683986504; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uOHTamwKNL40GhmSChgfj+zLAbo8CbA29L61cgq0bpE=; b=dCytFRo55BUK2/tUID1mC3kANSs5PpeWW/z2IeOkHOvi/KcXHMwTBEThC5pOXrYURM yqCKbBHz7gb4c+CdXuiV1ORD5RGVcMon3opUa1ugC9Y7dO2I+cuW8kO5+dc/iK48Xs2g lqMRh4G1BOvxr+OmdStlJoEhWTvVaOBh9h/w+4B5136A/ObE++qTW5vPij1D895LBIoB C1ekS8Rm5mH8m6DyVPsD0zbBYN9EIloKuQlvjYmWvRgOLw/iMpQ6bPn75k103Z0esyCS 6nj3bFqzU9PDvAArAq8HBXGRV9Zx/VY+EIwBazzg3hzNWMi7xheCm51gQlrKniqkUNbD cMIQ== X-Gm-Message-State: AAQBX9fHGHuNPYIfpKP+0lpU16QIIZy49/puW6ho7qs1IvHWMU7nQR57 fL+VVR/EQsP13nf50OGhOc8= X-Google-Smtp-Source: AKy350aCOeLGVdCGwcMkMytZAVJF3k2hKosfOFGhq5NwBEjscTYcs49JjHc5JD4A851zKXAccyv3nw== X-Received: by 2002:a05:600c:2304:b0:3f0:7f07:e617 with SMTP id 4-20020a05600c230400b003f07f07e617mr1969779wmo.8.1681394503378; Thu, 13 Apr 2023 07:01:43 -0700 (PDT) Received: from Ansuel-xps. (host-87-7-13-196.retail.telecomitalia.it. [87.7.13.196]) by smtp.gmail.com with ESMTPSA id k17-20020a7bc411000000b003f09fe8312csm1909489wmi.20.2023.04.13.07.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 07:01:42 -0700 (PDT) Message-ID: <64380b46.7b0a0220.978a.1eb4@mx.google.com> X-Google-Original-Message-ID: Date: Thu, 13 Apr 2023 01:11:17 +0200 From: Christian Marangi To: Florian Fainelli Cc: Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [net-next PATCH v6 06/16] net: phy: phy_device: Call into the PHY driver to set LED brightness References: <20230327141031.11904-1-ansuelsmth@gmail.com> <20230327141031.11904-7-ansuelsmth@gmail.com> <202ae4b9-8995-474a-1282-876078e15e47@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202ae4b9-8995-474a-1282-876078e15e47@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_070148_451054_0FD023F5 X-CRM114-Status: GOOD ( 15.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 13, 2023 at 06:57:51AM -0700, Florian Fainelli wrote: > > > On 3/27/2023 7:10 AM, Christian Marangi wrote: > > From: Andrew Lunn > > > > Linux LEDs can be software controlled via the brightness file in /sys. > > LED drivers need to implement a brightness_set function which the core > > will call. Implement an intermediary in phy_device, which will call > > into the phy driver if it implements the necessary function. > > > > Signed-off-by: Andrew Lunn > > Signed-off-by: Christian Marangi > > Reviewed-by: Florian Fainelli > > > + int (*led_brightness_set)(struct phy_device *dev, > > + u32 index, enum led_brightness value); > > I think I would have made this an u8, 4 billion LEDs, man, that's a lot! If andrew is ok we can still consider to reduce it. (but just to joke about it... A MAN CAN DREAM OF A FULL HD SCREEN ON THEIR OWN SPECIAL PORT) -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel