From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2A09C27C4F for ; Wed, 26 Jun 2024 07:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ruHiaKvsrC7Ybqki7GjnyIxjUjfx6YRMgvQ1BGmF5z0=; b=vtxf9gYVMtN/HS YRrADDQhWNZQ0rrPuH/eRSNUwTMh4Oz3W7xk22wfOumH7CansWOrTfJqEI6azjDREwaOeqWwr/zkl WNlVPdtJ9BF30J+XkQtSnMyAl0TOAbUtf4r8gnLfgeg82N3Ir28FId3wRMDZmmybxkn49B+3imY4M VhUO+gfmFIDotbJT7Z5SExLplB92bNmvNw0uvg55TkCGe1ktDUCo3Ebv4Gl1dFqLJNVG1iFNx+pRE 77IZhvQl0t1MYZzud+sNpZaEZ46x0bXmIQZzojZTz/RasvqH67SlLgsgZnfGxp7UG+1+CjJCNFHUz 8N8FuNCm2XSQ5rtN92ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMN9z-00000005l08-0tOB; Wed, 26 Jun 2024 07:33:43 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMN9r-00000005kzS-1KNZ for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 07:33:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8129660AC9; Wed, 26 Jun 2024 07:33:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ED2EC32789; Wed, 26 Jun 2024 07:33:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719387214; bh=6jirXN/OoV3yU2W+vvPXeYDV0BuubNdjDGTAIzsegyk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AMuIKT0FsA3zYaek6ZuV4Rv2nj52/QzU0o/VJ1ynExVwcXIx8xsPgwnUndpcIvZFB eW6NO4znE4RngRgmPF6Vdi5fWwztON7c21xLH3TWDnK7N5sqz2xPVNHdSxcB5hW7ZQ PyIcKhaM8f7kCDx+YtSlDBbNFNjYDm1RCIUi3AwstfxokKnVAlYouh5dcqbCvCvh6I GMRYQgQUNq3syT2aQjBn1M4hNi/GzyVsYwlqG6M8UYW064RzMH0qsocV8EGU1+u9WU 44Z4ct+ZRsQR6OLQJW75lAOcWmI3ArEKBLClibeRFBQZ89I1rQTs5bYImuNwvV0Lfo cDo9nOlUapPVA== Message-ID: <643ad6b3-3bbc-4a5d-ac47-6368f2171e87@kernel.org> Date: Wed, 26 Jun 2024 09:33:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: soc: ti: pruss: allow ethernet controller in ICSSG node To: Matthias Schiffer References: <20240619112406.106223-1-matthias.schiffer@ew.tq-group.com> <89880cda-1140-4ed5-a67f-2201c2825447@kernel.org> <99cc7afbb891de890ff051606f7a120f796e0fbc.camel@ew.tq-group.com> <14bebdc5-3239-47fe-b8cc-68daba278d73@kernel.org> <7adcd6789fb33fef10b7349934374e2cfb5ad164.camel@ew.tq-group.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <7adcd6789fb33fef10b7349934374e2cfb5ad164.camel@ew.tq-group.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_003335_526686_C9952EB1 X-CRM114-Status: GOOD ( 24.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Rob Herring , Conor Dooley , Vignesh Raghavendra , Tero Kristo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/06/2024 10:48, Matthias Schiffer wrote: > On Thu, 2024-06-20 at 10:29 +0200, Krzysztof Kozlowski wrote: >> >> >> On 20/06/2024 10:26, Matthias Schiffer wrote: >>> On Thu, 2024-06-20 at 09:24 +0200, Krzysztof Kozlowski wrote: >>>> On 19/06/2024 13:24, Matthias Schiffer wrote: >>>>> While the current Device Trees for TI EVMs configure the PRUSS Ethernet >>>>> controller as a toplevel node with names like "icssg1-eth", allowing to >>>>> make it a subnode of the ICSSG has a number of advantages: >>>> >>>> What is ICSSG? The sram or ti,prus from the ethernet schema? >>> >>> ICSSG (Industrial Communication Subsystem (Group?)) is the main device described by the >>> ti,pruss.yaml binding (ICSS and PRUSS are different variants of similar IP cores); it is the >>> container for the individual PRU, TXPRU and RTU cores which are referenced by the ti,prus >>> node of the Ethernet schema. >>> >>> The entirety of PRU, TXPRU and RTU cores of one ICSSG, each with its own firmware, forms one >>> Ethernet controller, which is not quite a hardware device, but also not a fully virtual software >>> device. >> >> So it is not really child of ICSSG. >> >>> >>> The Ethernet controller only exists through the various ICSS subcores, so it doesn't have an MMIO >>> address of its own. As described, the existing Device Trees define it as a toplevel non-MMIO node; >>> we propose to allow it as a non-MMIO child node of the ICSSG container instead. >>> >>> If you consider moving the ethernet node into the ICSSG node a bad approach, we will drop this patch >>> and try to find a different solution to our issue (the Ethernet device staying in deferred state >>> forever when the ICSSG node is disabled on Linux). >> >> Just disable the ethernet. That's the expected behavior, I don't get >> what is the problem here. > > If the disabling happens as a fixup in the bootloader, it needs to know the name of the Ethernet > controller node (or iterate through the DTB to find references to the disabled ICSSG node). Which is already solved for several such cases, including ethernet devices? Aliases? > > The name is currently not used for anything, and not specified in the binding doc; the example uses > "ethernet", which is too unspecific, as there can be multiple ICSSG/PRUs, with each running a > separate Ethernet controller. Use existing solutions - aliases. > > Existing Device trees use "icssgX-eth" for an Ethernet controller running on the ICSSG with label > "&icssgX", but labels are a source concept and don't exist in the compiled DTB by default. > > I do have an idea for an alternative approach that does not need changes to the DT bindings: The PRU > Ethernet driver could detect that the referenced ti,prus are disabled and not just waiting to be > probed and then fail with ENODEV instead of EPROBE_DEFER. Sorry, but re-shuffling nodes into incorrect hardware description is not the workaround for your problem. Best regards, Krzysztof