From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15A3ACD128A for ; Wed, 3 Apr 2024 12:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0mJtLvvmx/Km/lF5xxJePFeI6DIhuWCUiuxjjDKzcu4=; b=y2yQDksMIzyurH OVgD18lir3j8P2oCdAHk+0MDWOzjHXMDUB0lxgif8YLT9j0Eo0/BRqAogKA5V7BoiQXA8RvtFsDNo evqJPBod0ceox7UhngKrRY0tZ5dFZeIs3VZNcGkSVYRYShxIh+j97RfayoIou18SV6xJv3ej2XpGl A4FGfqSwUw9a0RvjmtWlQeAs8+wzrqr/LLZsapHam0+tLhvvO4NFYk/n2nmYpa9R+UsudMlbkCOBB 3JS6/cmhzYD+Y1khu63XA7QmaNa4OknzLAKuGtn64l0Pzdmr0mdHLLAcw4t1/WlNMstyWL3D0zpuO 1VMiwYQ/0Tz6lGg+2YKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrzPM-0000000FtC1-0Spi; Wed, 03 Apr 2024 12:08:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrzPJ-0000000FtAN-38Z3 for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 12:07:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 659001007; Wed, 3 Apr 2024 05:08:28 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 503973F64C; Wed, 3 Apr 2024 05:07:55 -0700 (PDT) Message-ID: <6445e850-fe24-4eb2-86f0-217b62b9001d@arm.com> Date: Wed, 3 Apr 2024 14:07:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Content-Language: en-US To: Lukasz Luba , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org References: <20240402155822.505491-1-lukasz.luba@arm.com> <20240402155822.505491-5-lukasz.luba@arm.com> From: Dietmar Eggemann In-Reply-To: <20240402155822.505491-5-lukasz.luba@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_050757_884339_74B2E053 X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/04/2024 17:58, Lukasz Luba wrote: [...] > @@ -97,9 +98,17 @@ static int exynos_asv_update_opps(struct exynos_asv *asv) > last_opp_table = opp_table; > > ret = exynos_asv_update_cpu_opps(asv, cpu); > - if (ret < 0) > + if (!ret) { > + /* > + * When the voltage for OPPs could be changed, > + * make sure to update the EM power values, to > + * reflect the reality and not use stale data. > + */ Maybe shorter? /* * Update EM power values since OPP * voltage values may have changed. */ [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel