From mboxrd@z Thu Jan 1 00:00:00 1970 From: john.garry@huawei.com (John Garry) Date: Mon, 30 Jan 2017 08:57:09 +0000 Subject: [PATCH V6 3/5] OF: Add missing I/O range exception for indirect-IO devices In-Reply-To: <20170127220357.3lpavvyeymlhvlfg@rob-hp-laptop> References: <1485241525-201782-1-git-send-email-yuanzhichang@hisilicon.com> <1485241525-201782-4-git-send-email-yuanzhichang@hisilicon.com> <20170127220357.3lpavvyeymlhvlfg@rob-hp-laptop> Message-ID: <645d40d8-0db6-1737-88f4-fd839933b2ea@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 27/01/2017 22:03, Rob Herring wrote: > On Tue, Jan 24, 2017 at 03:05:23PM +0800, zhichang.yuan wrote: >> There are some special ISA/LPC devices that work on a specific I/O range where >> it is not correct to specify a 'ranges' property in DTS parent node as cpu >> addresses translated from DTS node are only for memory space on some >> architectures, such as Arm64. Without the parent 'ranges' property, current >> of_translate_address() return an error. >> Here we add special handlings for this case. >> During the OF address translation, some checkings will be perfromed to >> identify whether the device node is registered as indirect-IO. If yes, the I/O >> translation will be done in a different way from that one of PCI MMIO. >> In this way, the I/O 'reg' property of the special ISA/LPC devices will be >> parsed correctly. >> >> Signed-off-by: zhichang.yuan >> Signed-off-by: Gabriele Paoloni >> Signed-off-by: Arnd Bergmann > > Shouldn't this be Reviewed-by? > The background is that Zhichang is following a sketch of a re-worked driver from Arnd, which Arnd gave Signed-off-by. But this patch does not follow it verbatim. I think this patchset should be resent without Arnd's signature. Or Arnd may kindly review and say it's ok. John > Otherwise, looks fine to me. > > Acked-by: Rob Herring > >> --- >> drivers/of/address.c | 87 ++++++++++++++++++++++++++++++++++++++++++---------- >> 1 file changed, 71 insertions(+), 16 deletions(-) >> > > . >