From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07ADCC636CC for ; Thu, 16 Feb 2023 11:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HB5QoJZPVW+kHW6GSI6NHd13PcpkvaTdyve5awhWDXY=; b=BxGWHpAtQup6CH QkKhJmJyEmWtKHRBjWF3ru58kFhbHFBamd4sDP8TyEGMcL5SrwJz3Q2B/AExQP0pBpiCvC1F7GStw JvcFpOsdq753ZldiD0uoBLr46XjMQ5piMu7RJKr77Hz33ZsjvuDtcwOGR14tZIWglW/rCv4NNDxbY T2Cav6ucz6xva0ZN0b+xYboov7B+Ll4aduHfEYpHWqyjtv4Z3MDA2HJXO1EteVXwQ76njiMgGAQ8C xEaHfP9s+7ZoDjGObW40GfDZKqpAbS8JUORxNO1m35Ivq5NVWTik1Nl88Mb6OErJllkV7yV7fYEJB Okw9gki63aK18B2IceuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSc2N-009oUD-9k; Thu, 16 Feb 2023 11:02:51 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSc2G-009oPS-2R for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 11:02:45 +0000 Received: by mail-ed1-x532.google.com with SMTP id n20so2405715edy.0 for ; Thu, 16 Feb 2023 03:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ea7TLkXH9nH4DA//1th+Z+4aboDPChuuD0jgIfj0RCw=; b=H1baVUnJRcg8cDc1YjHMX5yBmKVB2yuz7kOfaFXzi2M87JnaU3ZH7ZFmSYmqmioNiY L5NydmwgfDVfi1bon2+jot0meHsl3BYpV0o2/eQzfEdy63bOv+s7f/422AoDnb9kyF9Q GEMIr23IMOsksGGdtc9KoJqd/GvjHE8QZhQmWg8Txwh7mw/mSa2IGdir2zCRa5Yt69Nk Y05jarUZjiTC7KJNHqNBgyFRB+u4B5v9oPTPb+tYqojbfLU2fiJ09sgyhDe8CS/TMem8 3Apo17N1y0wFe10mh038/JL0BG9nlzeD9e9OWHtVG+Q0INccnlCJgj83B6fsBqGjpvOd H3fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ea7TLkXH9nH4DA//1th+Z+4aboDPChuuD0jgIfj0RCw=; b=sstcBmNQxwdK38f5DF5jRJ6DmP9K345Z9jHCZjbcWnBW2q1vOC+p1vzzfxX9Rje+Mt 1KA1NZrx2xrovXZszfe4CMvQi6L8XYBgaQ8nM1x5b3op6r4jBtXQRVOvx3II7pZYz9LC qXBIHPd7XaAxlPBkkuUx699qZr2K4lbf6GPKE371D47x75GzUc/Eu1h5GQxsqWH4wiNy 6eeg3afP27gCuCjY/Qnd/MfhTqODzZCL7vjBAQtF4E2HjW8FRMn9LiAMBNm19X8y1ETS o8gAR4qDSn7IAiLFEYnbwvu6lyKCO/TlUuUpYCp+yMN2YQRk2wnDstPSDz8XvP7jrhqV 5NiA== X-Gm-Message-State: AO0yUKU0Vu5GLzZmfklw3UWwK/bI4SgpAF4pbWq7p6oShjcjC3lBMg6L xuEWIbRe74SwHMRY7Bdzt044hw== X-Google-Smtp-Source: AK7set+G0Y1PwG7+QRividE03emGpRaIuD1Nl9H0Z7JGdPW6YUb7ULVXwZn1OpLNIQkPqQB9Ggh7Pg== X-Received: by 2002:aa7:d846:0:b0:4ab:4c2f:a449 with SMTP id f6-20020aa7d846000000b004ab4c2fa449mr5010022eds.20.1676545359538; Thu, 16 Feb 2023 03:02:39 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id y23-20020a50ce17000000b004acc1374849sm669369edi.82.2023.02.16.03.02.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 03:02:39 -0800 (PST) Message-ID: <649a8d88-0504-5aa9-d167-d25d394f3f26@linaro.org> Date: Thu, 16 Feb 2023 12:02:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 04/16] PCI: samsung: Use clock bulk API to get clocks Content-Language: en-US To: Shradha Todi , lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru, lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com, tglx@linutronix.de, m.szyprowski@samsung.com, jh80.chung@samsung.co, pankaj.dubey@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230214121333.1837-1-shradha.t@samsung.com> <20230214121333.1837-5-shradha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230214121333.1837-5-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_030244_187139_2BA6C076 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/02/2023 13:13, Shradha Todi wrote: > Adopt to clock bulk API to handle clocks. > > Signed-off-by: Shradha Todi > --- > drivers/pci/controller/dwc/pci-samsung.c | 46 ++++++------------------ > 1 file changed, 11 insertions(+), 35 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-samsung.c b/drivers/pci/controller/dwc/pci-samsung.c > index cfe384aee754..6c07d3f151be 100644 > --- a/drivers/pci/controller/dwc/pci-samsung.c > +++ b/drivers/pci/controller/dwc/pci-samsung.c > @@ -54,8 +54,8 @@ > struct exynos_pcie { > struct dw_pcie pci; > void __iomem *elbi_base; > - struct clk *clk; > - struct clk *bus_clk; > + struct clk_bulk_data *clks; > + int clk_cnt; > struct phy *phy; > struct regulator_bulk_data supplies[2]; > }; > @@ -65,30 +65,18 @@ static int exynos_pcie_init_clk_resources(struct exynos_pcie *ep) > struct device *dev = ep->pci.dev; > int ret; > > - ret = clk_prepare_enable(ep->clk); > - if (ret) { > - dev_err(dev, "cannot enable pcie rc clock"); > + ret = devm_clk_bulk_get_all(dev, &ep->clks); > + if (ret < 0) > return ret; > - } > > - ret = clk_prepare_enable(ep->bus_clk); > - if (ret) { > - dev_err(dev, "cannot enable pcie bus clock"); > - goto err_bus_clk; > - } > + ep->clk_cnt = ret; I think this misses check if you got two clocks. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel