Re: [PATCH v7 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188

["Friday Yang (杨阳)" <Friday.Yang@mediatek.com>]

On Sun, 2025-05-04 at 15:42 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 30/04/2025 11:45, Friday Yang wrote:
> > From: "Friday Yang" <friday.yang@mediatek.com>
> > 
> > Add 'resets' and 'reset-names' properties for SMI LARBs to support
> > SMI reset operations.
> > On the MediaTek platform, some SMI LARBs are directly connected to
> > the SMI Common, while others are connected to the SMI Sub-Common,
> > which in turn is connected to the SMI Common. The hardware block
> > diagram can be described as follows.
> > 
> >              SMI-Common(Smart Multimedia Interface Common)
> >                  |
> >          +----------------+------------------+
> >          |                |                  |
> >          |                |                  |
> >          |                |                  |
> >          |                |                  |
> >          |                |                  |
> >        larb0       SMI-Sub-Common0     SMI-Sub-Common1
> >                    |      |     |      |             |
> >                   larb1  larb2 larb3  larb7       larb9
> > 
> > Signed-off-by: Friday Yang <friday.yang@mediatek.com>
> > Tested-by: Friday Yang <friday.yang@mediatek.com>
> 
> That's not possible. Otherwise explain me how do you test bindings
> (and
> using static checkers is not testing).
> 
> 

You are right, I just used static check scripts to test this patch on
my local server. I will remove this tag in the new version.

> > Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> 
> Where? Provide lore link. That's a v7 so I expect all your work to be
> done public.
> 
> 

This tag should be removed too. He just reviewed this patch in our
internal gerrit and did not reply in the public way.
Apology for the miss.

> Best regards,
> Krzysztof