From: Angus Ainslie <angus@akkea.ca>
To: Pavel Machek <pavel@ucw.cz>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
angus.ainslie@puri.sm, Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit
Date: Fri, 24 May 2019 15:20:45 -0700 [thread overview]
Message-ID: <64cc01b6cc6590e328e7b488bedb9dc8@www.akkea.ca> (raw)
In-Reply-To: <1e6c0664949f38452b8f14b901bff513@www.akkea.ca>
Hi Pavel,
On 2019-05-24 15:00, Angus Ainslie wrote:
> Hi Pavel,
>
> On 2019-05-23 12:19, Pavel Machek wrote:
>> Hi!
>>
>>> - LEDs
>>> - gyro
>>> - magnetometer
>>
>>> + leds {
>>> + compatible = "gpio-leds";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_gpio_leds>;
>>> +
>>> + led1 {
>>> + label = "LED 1";
>>
>> So, what kind of LED do you have, and what color is it? label should
>> probably be something like
>> notify:green.
>>
>
> As we don't have a specific use for these yet does it really matter if
> there is a colour or a number associated with them ?
>
>>> + charger@6b { /* bq25896 */
>>> + compatible = "ti,bq25890";
>>> + reg = <0x6b>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_charger>;
>>> + interrupt-parent = <&gpio3>;
>>> + interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
>>> + ti,battery-regulation-voltage = <4192000>; /* 4.192V */
>>> + ti,charge-current = <1600000>; /* 1.6 A */
>>
>> No space before A, for consistency.
>>
>>> + ti,termination-current = <66000>; /* 66mA */
>>> + ti,precharge-current = <1300000>; /* 1.3A */
>>
>> I thought precharge is usually something low, because you are not yet
>> sure of battery health...?
>>
>
> I think I put that in incorrectly. The intention was 130mA.
>
>>> + ti,minimum-sys-voltage = <2750000>; /* 2.75V */
>>
>> Are you sure? Normally systems shut down at 3.2V, 3V or so. Li-ion
>> batteries don't
>> really like to be discharged _this_ deep.
>
> You are correct. I'll fix it for the next version.
>
Looking into it further Sanyo and Panasonic get over 300 cycles bringing
the NCR18650 down to 2.5V so 2.75V should be fine.
http://www.batteryonestop.com/baotongusa/products/datasheets/li-ion/SANYO-NCR18650B-3400mAh.pdf
https://industrial.panasonic.com/ww/products/batteries/secondary-batteries/lithium-ion/cylindrical-type/NCR18650PF
Angus
> Thanks
> Angus
>
>>
>> Pavel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-24 22:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:23 [PATCH v13 0/4] Add support for the Purism Librem5 devkit Angus Ainslie (Purism)
2019-05-20 14:23 ` [PATCH v13 1/4] MAINTAINERS: add an entry for for arm64 imx devicetrees Angus Ainslie (Purism)
2019-05-20 14:23 ` [PATCH v13 2/4] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit Angus Ainslie (Purism)
2019-05-23 19:19 ` Pavel Machek
2019-05-23 21:52 ` Angus Ainslie
2019-05-23 22:06 ` Pavel Machek
2019-05-23 19:19 ` Pavel Machek
2019-05-24 22:00 ` Angus Ainslie
2019-05-24 22:20 ` Angus Ainslie [this message]
2019-05-20 14:23 ` [PATCH v13 3/4] dt-bindings: Add an entry for Purism SPC Angus Ainslie (Purism)
2019-05-20 23:00 ` Rob Herring
2019-05-20 14:23 ` [PATCH v13 4/4] dt-bindings: arm: fsl: Add the imx8mq boards Angus Ainslie (Purism)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64cc01b6cc6590e328e7b488bedb9dc8@www.akkea.ca \
--to=angus@akkea.ca \
--cc=angus.ainslie@puri.sm \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).