public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mike.looijmans@topic.nl (Mike Looijmans)
To: linux-arm-kernel@lists.infradead.org
Subject: [Question] firmware/psci.c: prevent registering pm_power_off
Date: Mon, 27 Mar 2017 15:36:53 +0200	[thread overview]
Message-ID: <64d01077-e2e8-01e2-f763-779a60c0fe68@topic.nl> (raw)

?Problem: The board uses gpio-poweroff to power down, because the "kill" signal 
is controlled by an I2C IO expander. This doesn't work because 
drivers/firmware/psci.c unconditionally registers pm_power_off, resulting in 
the gpio-poweroff driver to refuse to register. The PSCI firmware isn't 
actually capable of really turning off the power, but there appears to be no 
way to tell the psci driver about that.

My current workaround is to patch firmware/psci.c and remove this line:

pm_power_off = psci_sys_poweroff;

However, it would be desirable to have this under, for example, devicetree 
control. The structure of psci.c doesn't really make that an easy option 
though, but I'm willing to create a patch to do so.

Is this an option, or is there some ongoing effort in the kernel to make 
pm_power_off into something more managable?

An alternative approach would be to add a flag to the gpio-poweroff to 
override the pm_power_off value. Would that be a lesser evil?


Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans at topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

             reply	other threads:[~2017-03-27 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27 13:36 Mike Looijmans [this message]
2017-03-27 14:02 ` [Question] firmware/psci.c: prevent registering pm_power_off Sudeep Holla
2017-03-27 16:25   ` Mike Looijmans
2017-03-27 17:17     ` Mark Rutland
2017-03-28  5:50       ` Mike Looijmans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64d01077-e2e8-01e2-f763-779a60c0fe68@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox