From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B74EC74A5B for ; Wed, 29 Mar 2023 16:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yx37s9P15bEOjYyQnQwpBzPTSFfvJVnZdWZWhXA2XVE=; b=cbNL6okBMiBTCR AfyhJiKaLQem87EjucIgIi0KTfx0xgVqZsUoezdWo+TegTJ40PM2kRhjXdXVFXEvGbxxXre6PFp7z wtN+HddDeJ3aE8b2MragbABmrImh580S9N0Ti7qpR9ekoIpF7WfBBHIA32pjD8+z3J5xfBcXhBa0I y1tPlAJGPsf2YwXpVJuVNu8wC5Lv7Bfaxeh3mQGFLLm0pAmyrDLt7pgX7je1pY/4Q/s4c6oNJoUuk HcCtd4kr5IVhmviT3WEIh1I+0OpU/kqNqJLOTN1+N3jrVXEtMrq/o/k7CWMlkz2MV5K7HLdGd5334 A1RnQXrcs9d46jeWyR9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phYM8-0011U3-2u; Wed, 29 Mar 2023 16:09:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1phYM5-0011PA-0A for linux-arm-kernel@lists.infradead.org; Wed, 29 Mar 2023 16:08:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 490751FB; Wed, 29 Mar 2023 09:09:32 -0700 (PDT) Received: from [192.168.1.158] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6C0C63F6C4; Wed, 29 Mar 2023 09:08:46 -0700 (PDT) Message-ID: <64db6d95-8aca-48cc-80e1-e68211922071@arm.com> Date: Wed, 29 Mar 2023 17:08:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [BUG] perf: No samples found when using kcore + coresight Content-Language: en-US To: Leo Yan , Yang Shi Cc: linux-perf-users@vger.kernel.org, LAK , coresight@lists.linaro.org, Linux Kernel Mailing List , mathieu.poirier@linaro.org, adrian.hunter@intel.com, Jiri Olsa , acme@redhat.com, mike.leach@linaro.org, Will Deacon , suzuki.poulose@arm.com References: <8ca2b07e-674e-afb6-ff12-87504f51f252@arm.com> <20230309113851.GF19253@leoy-yangtze.lan> <20230313121420.GB2426758@leoy-yangtze.lan> <20230314003610.GD2426758@leoy-yangtze.lan> From: James Clark In-Reply-To: <20230314003610.GD2426758@leoy-yangtze.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230329_090857_137096_88AA008C X-CRM114-Status: GOOD ( 17.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/03/2023 00:36, Leo Yan wrote: > On Mon, Mar 13, 2023 at 11:15:44AM -0700, Yang Shi wrote: > > [...] > >>> Just a quick summary, here we have two issues: >>> >>> - With command: >>> perf record -e cs_etm/@tmc_etf63/k --kcore --per-thread \ >>> -- taskset --cpu-list 1 uname", >>> >>> perf doesn't enable "text poke" attribution. >> >> No, it enables "text poke" and perf fails to decode coresight trace >> data too. It doesn't matter whether "--kcore" is after or before "-e >> cs/etm/@tmc_etf63/k". > > Understand now. Thanks for correction, if so we can ignore this one. > > Leo To me it looks like it's only --per-thread and --kcore together that cause the issue. I can't see if that was mentioned previously in this thread. If it is --per-thread that's causing the issue then I think I have an idea why it might be. There are some assumptions and different paths taken in decoding in that mode that aren't correct. It causes some other issues to do with ordering and timestamps as well and I wanted to fix it previously. I wouldn't say that the text-poke change has caused a regression, as decoding in this mode was always a bit buggy. Maybe this is another reason to fix it properly. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel