From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72D6C43613 for ; Thu, 20 Jun 2019 18:06:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CCDF2089C for ; Thu, 20 Jun 2019 18:06:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CfBKrkzK"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="X0U61+dC"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="fyIrHi0k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CCDF2089C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Zr0ZYBvcGd6moCaCzfga8Uw/iwpzXMHCgch3nnhTh2Y=; b=CfBKrkzKX/uUexomt3vn14H/e QvGEXRP870EaAwxCtw8/0FMZSB7RC9lSfrhB4VX3zkQ56g8zH+MDkOjcTO1CCfShHyzAycDHP6DYU wW5THRD3C7Tkoj/L5T/KJZlZOMvbCp8UCKQZZ9VhCfv1vZlFY0qQP5aeqFfzLFa6Gxw9+U+9lV0zR fpyzK2GqL6ZfVoJiyO5I+u1LW0/SLC19BrTBnGZAFwLGnyt1cPZIjZbxMECal0qjHuUIROTRf5Smg Qb0Xk2haEtisyxcIUxATqmClCIzQHyDO5VjAiUkCwn/sKOoymB6LyzCMplTbyCb+4juv9UK0CmJih fuX2vtgHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he1Rq-000450-Kh; Thu, 20 Jun 2019 18:06:10 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1he1Rn-00044Y-Ih for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 18:06:08 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 211F860F3E; Thu, 20 Jun 2019 18:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561053966; bh=xqFrw2iEUDGfrGwNGjX8WKf97VfRNbSs18+LFwCkO+4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=X0U61+dCRIEZ4e3yrvA8matSW+ki2E0nLRtV+V7WB65nATw3FSN9LBt0LhuJ/cyko 5ex740qhgIUYou7qbgV4vRNInyrmyhI8ud9gNhxctEVCtKb7A6NoPKoENDhmsynu3b Ew8lPX38M7Qasa/hxqZpBVpjiRioE++j1G45grNU= Received: from [192.168.1.100] (unknown [157.45.245.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CAD5860ACE; Thu, 20 Jun 2019 18:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561053963; bh=xqFrw2iEUDGfrGwNGjX8WKf97VfRNbSs18+LFwCkO+4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fyIrHi0kTh7H+/xl5q7YA4c1k1jZjRQbz+F2RzehTRGhfvuQ2drjAd1ngvj+nt4k2 9PulOeBcArJzpAwwS3mNYhND6rZcuzHwtvppHvqqyto41vw29dwJnOKsKt02AD6Yla kgVpN1slAGcfy/IPYu7CbVk2waSwQJ0fdxDVVoy4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CAD5860ACE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=saiprakash.ranjan@codeaurora.org Subject: Re: [PATCH 1/2] coresight: Set affinity to invalid for missing CPU phandle To: Mathieu Poirier References: <49d6554536047b9f5526c4ea33990b7c904673d3.1561037262.git.saiprakash.ranjan@codeaurora.org> <20190620173908.GA5581@xps15> From: Sai Prakash Ranjan Message-ID: <64f67948-3b7f-422b-0ab7-2393b6083514@codeaurora.org> Date: Thu, 20 Jun 2019 23:35:53 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190620173908.GA5581@xps15> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_110607_660670_AF3909B7 X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rajendra Nayak , Suzuki K Poulose , Alexander Shishkin , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, David Brown , Sibi Sankar , Vivek Gautam , Leo Yan , Andy Gross , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, Thanks for the review comments. On 6/20/2019 11:09 PM, Mathieu Poirier wrote: > Hi Sai, > > On Thu, Jun 20, 2019 at 07:15:46PM +0530, Sai Prakash Ranjan wrote: >> Affinity defaults to CPU0 in case of missing CPU phandle >> and this leads to crashes in some cases because of such >> wrong assumption. Fix this by returning -ENODEV in >> coresight platform for such cases and then handle it >> in the coresight drivers. >> >> Signed-off-by: Sai Prakash Ranjan >> --- >> drivers/hwtracing/coresight/coresight-platform.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c >> index 3c5ceda8db24..b1ea60c210e1 100644 >> --- a/drivers/hwtracing/coresight/coresight-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-platform.c >> @@ -160,15 +160,17 @@ static int of_coresight_get_cpu(struct device *dev) >> >> if (!dev->of_node) >> return 0; > > An error should be returned if the above condition is true. > Will do it, thanks. >> + > > Spurious newline > This was on purpose, the code looks much cleaner. -Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel