From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98860C4829A for ; Tue, 13 Feb 2024 08:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DitRDc3G16CE/1EpJ4f+pGjD/MVwRGVphUZefeD0aI0=; b=KgAPiZTe3GgICs apxnt9OkUorjM8M4gWTykHdNChpr2qAY253zp1dLOPY1FtvTufdMqITkrGGSKraT3Jsv9VGvz8Bh2 UUhFz5PPNzmpwKOhZaoDxbfqTorr2XHifmP4et+pSuSA+2QKFaSsG429IDO5MidXuPHY8/lYfz75c I0wP5fANnUjyB1Kln4ONvc5Xqqa7N3ujMquL8RSq4RKiaZOQE9jXNARGdK7s97EtznX1qVZy2mts9 EFkoNJPA2VUG6BZKD4V5fKRNFznwWaMXe2/5GO/nhQMAWeU6469y+/LoWEjenslz5UJdTDgYsTZsn jB2ek8bQ/orPdVFKUs2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZnlQ-00000008Kca-45F6; Tue, 13 Feb 2024 08:03:36 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZnlO-00000008KcG-2AGG for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 08:03:36 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41D7l4fg014541; Tue, 13 Feb 2024 08:03:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=LwcWrrBeGMk5PEnK2mar74GZ06ybPxBuCLBEY2vNIzw=; b=E9 OdbRPj9ys91T2HS1X5SSlhanUJf2H1SAaNaG31o+WVNimb30XnE6uzkfT3xLPbwq 9w5Sm+CcW3/p3eknvoxLn7uW040ZR292D39ZIwwdcSf2TxXYtyBIyHNK4F4BHxFw jxT9fwt/41X7I9SrAaaBm8GhoFwjODg2Y7iJFmfFOQr7U5H/ZaRyfaoZ6zu/bvno DbdptlX6K+24tEBiReh4/N19XzqVwNIGqWtRw7EehOfs/zHHCfy7Nwpk33WE/FS+ GjftW13tx4DDV3p0mlzOa2wz06O0vbx93QYeT11crliGu7Uq0LlS79pLineilb8n bMaDc08l519H3bm1rn8w== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w7gvjjf60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 08:03:26 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41D83PrE013449 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 08:03:25 GMT Received: from [10.131.33.37] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 13 Feb 2024 00:03:21 -0800 Message-ID: <64fdfa4d-f7ec-a5eb-bfbc-ee35d9cd4722@quicinc.com> Date: Tue, 13 Feb 2024 13:33:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/3] firmware: arm_scmi: Add support for marking certain frequencies as boost Content-Language: en-US To: Sudeep Holla , Pierre Gondois CC: , , , , , , , , , , , , References: <20240117110443.2060704-1-quic_sibis@quicinc.com> <20240117110443.2060704-3-quic_sibis@quicinc.com> <20240131160848.662dhaoiov3trt4i@bogus> From: Sibi Sankar In-Reply-To: <20240131160848.662dhaoiov3trt4i@bogus> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: -UksrDOFRADqZzuw6MQ93VX6tSjWhXt0 X-Proofpoint-ORIG-GUID: -UksrDOFRADqZzuw6MQ93VX6tSjWhXt0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-13_04,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=828 adultscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402130061 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240213_000334_731208_2887720B X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/31/24 21:38, Sudeep Holla wrote: > On Wed, Jan 31, 2024 at 03:29:43PM +0100, Pierre Gondois wrote: >> Hello Sibi, >> >> On 1/17/24 12:04, Sibi Sankar wrote: >>> All opps above the sustained level/frequency are treated as boost, so mark >>> them accordingly. >>> Sudeep/Pierre, Thanks for taking time to review the series. >>> Suggested-by: Sudeep Holla >>> Signed-off-by: Sibi Sankar >>> --- >>> drivers/firmware/arm_scmi/perf.c | 11 ++++++++++- >>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c >>> index e286f04ee6e3..d3fb8c804b3d 100644 >>> --- a/drivers/firmware/arm_scmi/perf.c >>> +++ b/drivers/firmware/arm_scmi/perf.c >>> @@ -811,7 +811,7 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph, >>> struct device *dev, u32 domain) >>> { >>> int idx, ret; >>> - unsigned long freq; >>> + unsigned long freq, sustained_freq; >>> struct dev_pm_opp_data data = {}; >>> struct perf_dom_info *dom; >>> @@ -819,12 +819,21 @@ static int scmi_dvfs_device_opps_add(const struct scmi_protocol_handle *ph, >>> if (IS_ERR(dom)) >>> return PTR_ERR(dom); >>> + if (!dom->level_indexing_mode) >>> + sustained_freq = dom->sustained_perf_level * dom->mult_factor; >>> + else >>> + sustained_freq = dom->sustained_freq_khz * dom->mult_factor; >>> + >>> for (idx = 0; idx < dom->opp_count; idx++) { >>> if (!dom->level_indexing_mode) >>> freq = dom->opp[idx].perf * dom->mult_factor; >>> else >>> freq = dom->opp[idx].indicative_freq * dom->mult_factor; >>> + /* All opps above the sustained level/frequency are treated as boost */ >>> + if (sustained_freq && freq > sustained_freq) >> >> It seems the sustained_freq is not optional since SCMI v1.0, >> is it necessary to check that (sustained_freq != 0) ? >> > > Technically correct, we don't have to. But since day 1, we checked and > handled 0 for perf_level specifically to avoid division by zero. I am > just worried if there are any platforms in the wild with these values as > 0. We can start without the check and add it if someone complains perhaps ? sure will drop the check in the re-spin. -Sibi > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel