From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "debugfs: ->d_parent is never NULL or negative"
Date: Thu, 6 Oct 2016 19:21:33 -0400 [thread overview]
Message-ID: <65156a02-fe6a-611f-907b-85997ee30755@codeaurora.org> (raw)
In-Reply-To: <20161006224117.GP19539@ZenIV.linux.org.uk>
On 10/6/2016 6:41 PM, Al Viro wrote:
> On Thu, Oct 06, 2016 at 11:37:29PM +0100, Al Viro wrote:
>
>> If you ever get NULL in ->d_parent of struct dentry instance, you are
>> practically certain to have a dangling pointer to memory that used to
>> contain a struct dentry at some point but got freed and reused since then.
>
> ... which is what happens in your case, apparently. ->stats is still
> pointing to a dentry that had just been freed and its memory reused.
>
Thanks for explaining the behavior. I posted the change a minute ago
and forgot to include you.
dmaengine: qcom_hidma: remove useless debugfs file removal
I have a very similar problem with sysfs now. It looks like the new kernel
is more assertive than the older ones.
I'll post the sysfs change in a minute.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2016-10-06 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 21:30 [PATCH] Revert "debugfs: ->d_parent is never NULL or negative" Sinan Kaya
2016-10-06 21:37 ` Al Viro
2016-10-06 21:41 ` Sinan Kaya
2016-10-06 21:56 ` Sinan Kaya
2016-10-06 22:11 ` Sinan Kaya
2016-10-06 22:00 ` Al Viro
2016-10-06 22:37 ` Al Viro
2016-10-06 22:41 ` Al Viro
2016-10-06 23:21 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65156a02-fe6a-611f-907b-85997ee30755@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox