From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF5C0EB64DD for ; Fri, 21 Jul 2023 08:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w46evqsmggno397NmZaiR8/fyrTiaXD7INrrGMCe+so=; b=0g5gCUWj4p1W+a 7/A/fM6ukiG6k3XXt57OuS62h8CBUdLIxNn5TXv4FLtxjdhVgMnJfVAxe0jMuXNoqzRSZ9uHnN4AX LhTR9erk9kJ2ye3s8VB3T9J3O85Qck5U/Yz4j6iZQ4+AFckuW6B4fFnbUfcDEsumaH3LjvEtU03g5 UeZqwEkJqvH5HBGMIX+UOT4txxv0BGFjhrPdCsyuPQcfmUzb6LtIFQxtZ0ErSH46IdC/fudRxRqEn gsgkBxJ+K30QaLZnMSPlIXHoOUiEsqLeHLXmcYvIUp76kytSjoW+tdkVTvbfR+RBOvncliSQzqZwe 1Ifw89uNI9HCvh+ElgSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMltg-00DRCz-1D; Fri, 21 Jul 2023 08:54:00 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMltZ-00DR8R-25; Fri, 21 Jul 2023 08:53:55 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C91AA660709A; Fri, 21 Jul 2023 09:53:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1689929632; bh=yDavRhK9bOtXKv6o2o89j6GKJ9ipNjcKAv95IXEuXEc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=U+uYKlW+oeRYXdBzoqAg8CcwKx/rJ4zThVd3T7McdVyA6IkeZcp16SDUw+z8LvIzJ TO5Qg/Fvj6tJEcRSvgyUrMjJw3iR7ZBoQ/AGOhXwPpZWB2Wp+roOg+zZHxjmA75LT0 z9gEGXzHaNzk1r3FQk2P6HYKlo551mqvyV4fLm3nJN1uulH52p8HRwUa7Kke2Q+IVx 8OMHRIb5YBXPP/QxR1AL9mepCOROoVaFLq1x/SYgl2uLw7RlO5xS+7xvwmrOLOyvos z8WMxS+hNvmudlrDqDDi+RlbR4U3ZPHtK92tpyry0cQIycGRsiWmn/Xrn7pSUwFwmh De38lcaHGlVfw== Message-ID: <651da0fc-2654-afb5-d364-31d97715e66f@collabora.com> Date: Fri, 21 Jul 2023 10:53:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH RESEND v2 1/7] mfd: mt6358: Add missing registers for LDO voltage calibration Content-Language: en-US To: Chen-Yu Tsai , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Brown , Liam Girdwood , Matthias Brugger Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230721082903.2038975-1-wenst@chromium.org> <20230721082903.2038975-2-wenst@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20230721082903.2038975-2-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_015353_808665_87C35F50 X-CRM114-Status: GOOD ( 17.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 21/07/23 10:28, Chen-Yu Tsai ha scritto: > Most of the LDOs, except the "VSRAM_*" ones, on the MT6358 and MT6366 > PMICs support a finer output voltage calibration within the range of > +0 mV to +100 mV with 10 mV step. Some of the registers for this > function are missing from the register table. > Please mention that you're doing this addition *because* you're using those new definitions right after, and in the regulator driver: [...] In preparation for adding support for improved output voltage selection in mt6358-regulator, add the relevant missing registers for the same. [...] After which, Reviewed-by: AngeloGioacchino Del Regno > Add the missing ones for MT6358. > > Signed-off-by: Chen-Yu Tsai > --- > include/linux/mfd/mt6358/registers.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/mfd/mt6358/registers.h b/include/linux/mfd/mt6358/registers.h > index 3d33517f178c..5ea2590be710 100644 > --- a/include/linux/mfd/mt6358/registers.h > +++ b/include/linux/mfd/mt6358/registers.h > @@ -262,6 +262,12 @@ > #define MT6358_LDO_VBIF28_CON3 0x1db0 > #define MT6358_VCAMA1_ANA_CON0 0x1e08 > #define MT6358_VCAMA2_ANA_CON0 0x1e0c > +#define MT6358_VFE28_ANA_CON0 0x1e10 > +#define MT6358_VCN28_ANA_CON0 0x1e14 > +#define MT6358_VBIF28_ANA_CON0 0x1e18 > +#define MT6358_VAUD28_ANA_CON0 0x1e1c > +#define MT6358_VAUX18_ANA_CON0 0x1e20 > +#define MT6358_VXO22_ANA_CON0 0x1e24 > #define MT6358_VCN33_ANA_CON0 0x1e28 > #define MT6358_VSIM1_ANA_CON0 0x1e2c > #define MT6358_VSIM2_ANA_CON0 0x1e30 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel