From: Qi Zheng <zhengqi.arch@bytedance.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] arm64: run softirqs on the per-CPU IRQ stack
Date: Thu, 14 Jul 2022 19:50:38 +0800 [thread overview]
Message-ID: <6541e3d2-69cc-2970-c7db-fde4d64a2f09@bytedance.com> (raw)
In-Reply-To: <CAK8P3a2kgVikkKBZLa31XUopEFa9ykLS=qxiH=qiFD8HtUvw=A@mail.gmail.com>
On 2022/7/14 19:32, Arnd Bergmann wrote:
> On Fri, Jul 8, 2022 at 11:49 AM Qi Zheng <zhengqi.arch@bytedance.com> wrote:
>>
>> Currently arm64 supports per-CPU IRQ stack, but softirqs
>> are still handled in the task context.
>>
>> Since any call to local_bh_enable() at any level in the task's
>> call stack may trigger a softirq processing run, which could
>> potentially cause a task stack overflow if the combined stack
>> footprints exceed the stack's size, let's run these softirqs
>> on the IRQ stack as well.
>>
>> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
>
> This seems like a nice improvement, and this version addresses
> my concern I raised on the RFC version.
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Thanks for your review. :)
--
Thanks,
Qi
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-14 11:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 9:49 [PATCH v1 0/2] arm64: run softirqs on the per-CPU IRQ stack Qi Zheng
2022-07-08 9:49 ` [PATCH v1 1/2] " Qi Zheng
2022-07-14 11:32 ` Arnd Bergmann
2022-07-14 11:50 ` Qi Zheng [this message]
2022-07-22 9:04 ` Will Deacon
2022-07-22 9:13 ` Qi Zheng
2022-07-08 9:49 ` [PATCH v1 2/2] arm64: support HAVE_IRQ_EXIT_ON_IRQ_STACK Qi Zheng
2022-07-14 11:37 ` Arnd Bergmann
2022-07-14 11:54 ` Qi Zheng
2022-07-19 7:01 ` Qi Zheng
2022-07-19 11:24 ` Mark Rutland
2022-07-19 12:11 ` Qi Zheng
2022-07-12 6:57 ` [PATCH v1 0/2] arm64: run softirqs on the per-CPU IRQ stack Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6541e3d2-69cc-2970-c7db-fde4d64a2f09@bytedance.com \
--to=zhengqi.arch@bytedance.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox