From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC30EC4345F for ; Tue, 30 Apr 2024 11:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/uq1OuYu4bmQAbRZBg1/4QAFo0T8mM6OIRFsnMD2BEs=; b=t5C576lwV1IOtj 2FBq0Tx5ygxCi5CEv/4+4R+uvXaai1sMxhed/Cbhv8sdPkDN9mS7pADjc3DTTWtQUCkO3F21v4AHa z4dYS6GqGFQMMg+lKH1q9CbWWEJzsKprUzQHvMzaOGp5UopYK5nuMxUjqSsOq1egSFPylQmTrJcxl x+jUW1xq0g1lsubcHGQQTLdVMRTJGyDOuQMowQ4Y6Oh1IQx/IxyObukda+HlmuubPGfH0QKvTKVco inBWSARUMxZg6K7oqx1NDYnTWEWeUJdpdGyC2i9nBNPNBRKCUXtHeinHteVtn1YtM8uWO9Cm9mJsH qPzInOPqwq8gksA8Adrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1lEL-000000066fq-3eOR; Tue, 30 Apr 2024 11:01:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1lEI-000000066dz-3BL8 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 11:01:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 10C772F4; Tue, 30 Apr 2024 04:01:24 -0700 (PDT) Received: from [10.57.1.41] (unknown [10.57.1.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EF2D3F73F; Tue, 30 Apr 2024 04:00:56 -0700 (PDT) Message-ID: <658581c0-eb0f-408d-a32e-c97d948103df@arm.com> Date: Tue, 30 Apr 2024 12:00:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: Properly clean up iommu-dma remnants To: Dmitry Baryshkov Cc: joro@8bytes.org, will@kernel.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: From: Robin Murphy Content-Language: en-GB In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_040058_929136_3E1843EC X-CRM114-Status: GOOD ( 10.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-04-30 11:32 am, Dmitry Baryshkov wrote: > On Tue, 30 Apr 2024 at 13:23, Robin Murphy wrote: >> >> Thanks to the somewhat asymmetrical nature, while removing >> iommu_setup_dma_ops() from the arch_setup_dma_ops() flow, I managed to >> forget that arm64's teardown path was also specific to iommu-dma. Clean >> that up to match, otherwise probe deferral will lead to the arch code >> erroneously removing DMA ops set elsewhere. >> >> Reported-by: Dmitry Baryshkov >> Link: https://lore.kernel.org/linux-iommu/Zi_LV28TR-P-PzXi@eriador.lumag.spb.ru/ >> Fixes: b67483b3c44e ("iommu/dma: Centralise iommu_setup_dma_ops()") >> Signed-off-by: Robin Murphy >> --- >> arch/arm64/Kconfig | 1 - >> arch/arm64/mm/dma-mapping.c | 8 -------- >> 2 files changed, 9 deletions(-) > > > Thanks! > > Tested-by: Dmitry Baryshkov Great! Always nice when the issue is one of simply not deleting *enough* code :) Cheers, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel