From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D9FC433DB for ; Fri, 12 Mar 2021 13:51:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6926A64F9E for ; Fri, 12 Mar 2021 13:51:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6926A64F9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DLDgMmGI8CvG/STMnDMtKc/1E9z27hdOC5Cle5fFvaM=; b=b0UsxS9UKQETK1AFaRqPEuP8i qEbN7fWvX4nQMs7nbRC0clBjJYlYtoE05BeaO8jdsQ+31qA0q/EZH+DIbwcMBrT8Q0VCkyY/TCZ6I e/7sxOi47GHfR4NwP2GhS+nghr5+jWIZq1Zhoo86M34TtDiOI5fx+1IfrtR7ZhwDBMMg6Sb2DtMIu 5vpW9ETZBYmYpPDk+xzUF54iNwUY1VLbdOv2dFrwkT+MZg0f8OnoVVK4169Ml8ztv9JaBtXBtv8vw xJKFMCdb0TqURJQEZGt+Ad60PzFhBDm5nfDOEVDFjLRK62HjYshjquH8nlGXZCmVvHYH191JQTnV4 zAcN4RbQQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKiBA-00BYlq-J3; Fri, 12 Mar 2021 13:50:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKhC8-00BSCm-S2 for linux-arm-kernel@lists.infradead.org; Fri, 12 Mar 2021 12:49:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 43AFC64FA8; Fri, 12 Mar 2021 12:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615553225; bh=tKxo7sljt+pkSDWh1mUmM5NEnGtDl1u9sBRuSQ9gqRc=; h=Subject:List-Id:To:References:From:Date:In-Reply-To:From; b=B3Wff/4KDmmI4bxbuLnCVv/MwYiNVGTqwGqUPpD8YXC6MroBQPb8N+EnosWeJCJ2y Rkp7GdjehEX1HMV3fPxNO7aKArRqwH6TrHVpzL4ryxEl70Lzbax1YbTihd7p+v3wLi F/vgUsvYwllSpTtiN3jZhkOFVNUz2QLObR9b7zLUrx98RXMWrgmD7MB7rebtqDmvOM FVXb6gGhhc78VVIZZlmPvJJqjIh1an/WBxQHhzuE0Q1unaoDjymZt7zaDFiFzoYUbq yaZP/LSuHch01stzO64G9IeE+HgpEIjCVxMIZDa/Xm3msx8lukkNSFJOIykNnOw3TT kYlzkQX5Dj6Nw== Subject: Re: [PATCH v3 01/15] clk: socfpga: allow building N5X clocks with ARCH_N5X List-Id: To: Krzysztof Kozlowski , Russell King , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Vinod Koul , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Moritz Fischer , Tom Rix , Lee Jones , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Jakub Kicinski , Philipp Zabel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, dmaengine@vger.kernel.org, linux-edac@vger.kernel.org, linux-fpga@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20210311152545.1317581-1-krzysztof.kozlowski@canonical.com> <20210311152545.1317581-2-krzysztof.kozlowski@canonical.com> From: Dinh Nguyen Message-ID: <658d380b-c043-06be-a7b9-f96e73aa03f9@kernel.org> Date: Fri, 12 Mar 2021 06:47:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210311152545.1317581-2-krzysztof.kozlowski@canonical.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210312_124909_696958_4A000415 X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/11/21 9:25 AM, Krzysztof Kozlowski wrote: > The Intel's eASIC N5X (ARCH_N5X) architecture shares a lot with Agilex > (ARCH_AGILEX) so it uses the same socfpga_agilex.dtsi, with minor > changes. Also the clock drivers are the same. > > However the clock drivers won't be build without ARCH_AGILEX. One could > assume that ARCH_N5X simply depends on ARCH_AGILEX but this was not > modeled in Kconfig. In current stage the ARCH_N5X is simply > unbootable. > > Add a separate Kconfig entry for clocks used by both ARCH_N5X and > ARCH_AGILEX so the necessary objects will be built if either of them is > selected. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/Kconfig | 1 + > drivers/clk/Makefile | 1 + > drivers/clk/socfpga/Kconfig | 6 ++++++ > drivers/clk/socfpga/Makefile | 4 ++-- > 4 files changed, 10 insertions(+), 2 deletions(-) > create mode 100644 drivers/clk/socfpga/Kconfig > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index a588d56502d4..1d1891b9cad2 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -394,6 +394,7 @@ source "drivers/clk/renesas/Kconfig" > source "drivers/clk/rockchip/Kconfig" > source "drivers/clk/samsung/Kconfig" > source "drivers/clk/sifive/Kconfig" > +source "drivers/clk/socfpga/Kconfig" > source "drivers/clk/sprd/Kconfig" > source "drivers/clk/sunxi/Kconfig" > source "drivers/clk/sunxi-ng/Kconfig" > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > index b22ae4f81e0b..12e46b12e587 100644 > --- a/drivers/clk/Makefile > +++ b/drivers/clk/Makefile > @@ -106,6 +106,7 @@ obj-$(CONFIG_COMMON_CLK_SAMSUNG) += samsung/ > obj-$(CONFIG_CLK_SIFIVE) += sifive/ > obj-$(CONFIG_ARCH_SOCFPGA) += socfpga/ > obj-$(CONFIG_ARCH_AGILEX) += socfpga/ > +obj-$(CONFIG_ARCH_N5X) += socfpga/ > obj-$(CONFIG_ARCH_STRATIX10) += socfpga/ > obj-$(CONFIG_PLAT_SPEAR) += spear/ > obj-y += sprd/ > diff --git a/drivers/clk/socfpga/Kconfig b/drivers/clk/socfpga/Kconfig > new file mode 100644 > index 000000000000..3c30617169bf > --- /dev/null > +++ b/drivers/clk/socfpga/Kconfig > @@ -0,0 +1,6 @@ > +# SPDX-License-Identifier: GPL-2.0 > +config CLK_INTEL_SOCFPGA64 > + bool > + # Intel Agilex / N5X clock controller support > + default (ARCH_AGILEX || ARCH_N5X) > + depends on ARCH_AGILEX || ARCH_N5X > diff --git a/drivers/clk/socfpga/Makefile b/drivers/clk/socfpga/Makefile > index bf736f8d201a..c6db8dd4ab35 100644 > --- a/drivers/clk/socfpga/Makefile > +++ b/drivers/clk/socfpga/Makefile > @@ -3,5 +3,5 @@ obj-$(CONFIG_ARCH_SOCFPGA) += clk.o clk-gate.o clk-pll.o clk-periph.o > obj-$(CONFIG_ARCH_SOCFPGA) += clk-pll-a10.o clk-periph-a10.o clk-gate-a10.o > obj-$(CONFIG_ARCH_STRATIX10) += clk-s10.o > obj-$(CONFIG_ARCH_STRATIX10) += clk-pll-s10.o clk-periph-s10.o clk-gate-s10.o > -obj-$(CONFIG_ARCH_AGILEX) += clk-agilex.o > -obj-$(CONFIG_ARCH_AGILEX) += clk-pll-s10.o clk-periph-s10.o clk-gate-s10.o > +obj-$(CONFIG_CLK_INTEL_SOCFPGA64) += clk-agilex.o > +obj-$(CONFIG_CLK_INTEL_SOCFPGA64) += clk-pll-s10.o clk-periph-s10.o clk-gate-s10.o > Acked-by: Dinh Nguyen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel