From: Markus Elfring <Markus.Elfring@web.de>
To: Liu Ying <victor.liu@nxp.com>,
dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
devicetree@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH 09/10] drm/imx: Add i.MX8qxp Display Controller KMS
Date: Sun, 7 Jul 2024 21:16:16 +0200 [thread overview]
Message-ID: <6595d4fa-2e83-4380-b36e-9c4d910aadea@web.de> (raw)
In-Reply-To: <20240705090932.1880496-10-victor.liu@nxp.com>
…
> registers of the display controller is accessed without command sequencer
…
Wording suggestion:
The registers of … are …
…
> +++ b/drivers/gpu/drm/imx/dc/dc-crtc.c
> @@ -0,0 +1,578 @@
…
> +static irqreturn_t
> +dc_crtc_dec_framecomplete_irq_handler(int irq, void *dev_id)
> +{
…
> + spin_lock_irqsave(&crtc->dev->event_lock, flags);
> + if (dc_crtc->event) {
…
> + }
> + spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
> +
> + return IRQ_HANDLED;
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&crtc->dev->event_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc6/source/include/linux/spinlock.h#L574
Regards,
Markus
next prev parent reply other threads:[~2024-07-07 19:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 9:09 [PATCH 00/10] Add Freescale i.MX8qxp Display Controller support Liu Ying
2024-07-05 9:09 ` [PATCH 01/10] dt-bindings: display: imx: Add some i.MX8qxp Display Controller processing units Liu Ying
2024-07-07 13:58 ` Krzysztof Kozlowski
2024-07-08 6:30 ` Liu Ying
2024-07-08 20:04 ` Rob Herring
2024-07-09 7:36 ` Liu Ying
2024-07-05 9:09 ` [PATCH 02/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-07-07 13:59 ` Krzysztof Kozlowski
2024-07-08 6:40 ` Liu Ying
2024-07-08 14:04 ` Krzysztof Kozlowski
2024-07-08 14:52 ` Maxime Ripard
2024-07-09 6:50 ` Krzysztof Kozlowski
2024-07-18 15:53 ` Maxime Ripard
2024-07-05 9:09 ` [PATCH 03/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-07-07 14:02 ` Krzysztof Kozlowski
2024-07-08 6:47 ` Liu Ying
2024-07-08 14:05 ` Krzysztof Kozlowski
2024-07-09 6:50 ` Liu Ying
2024-07-05 9:09 ` [PATCH 04/10] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-07-07 14:01 ` Krzysztof Kozlowski
2024-07-08 6:51 ` Liu Ying
2024-07-08 14:09 ` Krzysztof Kozlowski
2024-07-09 7:05 ` Liu Ying
2024-07-05 9:09 ` [PATCH 05/10] dt-bindings: display: imx: Add i.MX8qxp Display Controller Liu Ying
2024-07-07 14:03 ` Krzysztof Kozlowski
2024-07-08 7:01 ` Liu Ying
2024-07-05 9:09 ` [PATCH 06/10] drm/imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-07-05 9:09 ` [PATCH 07/10] drm/imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-07-05 9:09 ` [PATCH 08/10] drm/imx: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-07-05 9:09 ` [PATCH 09/10] drm/imx: Add i.MX8qxp Display Controller KMS Liu Ying
2024-07-07 19:16 ` Markus Elfring [this message]
2024-07-08 6:21 ` Liu Ying
2024-07-08 7:09 ` [09/10] " Markus Elfring
2024-07-08 7:33 ` Krzysztof Kozlowski
2024-07-05 9:09 ` [PATCH 10/10] MAINTAINERS: Add maintainer for i.MX8qxp Display Controller Liu Ying
2024-07-05 19:02 ` Frank Li
2024-07-08 6:14 ` Liu Ying
2024-07-05 12:57 ` [PATCH 00/10] Add Freescale i.MX8qxp Display Controller support Francesco Dolcini
2024-07-08 7:03 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6595d4fa-2e83-4380-b36e-9c4d910aadea@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).