From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76746C4706C for ; Fri, 12 Jan 2024 17:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iaFxC2WvMzCwOPZUAD7Uma7588S/CY+VSbxGrjzNVE8=; b=FsAiHB8qN8CHr8 kgQPELvHmUiCGqsu7WWzwxKkryl/rWks6PcNhL0Ffih4P622tjRRwmuooHseUmUrcvugFr6m+EHJc EljWQMq1Vfr4IC73esi+MVnYDiP2wmNMR7K+RQYN1ChTMiI2Y9/fXD8RmjS1rcY7GvA6ODBAlTub8 YbPOcFcoLvUJuVRZ7cRC1Fl7Xq+VnnpHTb5rHWgiJakW/Yt7O7ZKIiJEU4zPPnaHru9z5q+1BoObE FAzhtZbMiDp58rJFEFvlnzXLmrsGQ5sktpB3pNfID6j3LZSlldT2vp98wJBwDp5fmysrnelCXRksu JIduS8loXYGR66PmJjKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rOLmA-003XPZ-2z; Fri, 12 Jan 2024 17:57:02 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rOLm7-003XP8-0k for linux-arm-kernel@lists.infradead.org; Fri, 12 Jan 2024 17:57:00 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-33677fb38a3so6125532f8f.0 for ; Fri, 12 Jan 2024 09:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705082217; x=1705687017; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=JqFsKecuSBrO3jxaxuNvcAexfgq6FB4LiqKsGB+p+Ao=; b=Mq+5G862Z5s8lKbuAEoEKVpFln9PW6SZxmyWGvZj3J3fktuwpDduH4aQRWoa7jKcU+ n3oPAAjHlM3O4aHMrWKNOEEL0eBXjH+S2Pw117BuuTk6AizAJzm/7jjGffjw0r1fE6RP kGZjOTTV5AHpgeygqKqt01C/ADWL5A0DFO4TkXWGo4xCxwhAOhuE1aGQedWlhZqSWV9M jr2N7FGwdKabhmS7DN0F/2K6DRy+nTyiR/J3vQ9OsmtjK5GUQgZ4aScY5cg1pic7paL/ FRly7NSB0EqfoQltRDg992Lx25WzL/nMsdlN8tbcQavtF1ceV10Tm1iW2lSJgKFx3WIJ d2ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705082217; x=1705687017; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JqFsKecuSBrO3jxaxuNvcAexfgq6FB4LiqKsGB+p+Ao=; b=jUxp51rtcK8iVrVU4X4Z0G2jnkx7D88N3Q+KXkeIJznLT6JuxH86XkMoznlVSVB06X +/FCt7rP0TfGLqcSCXj1T6OxMGIjXeF47lt1xOWaY/npkWQ8d2F2WwASavX5U5Wx6/7N BVEInPvfC0SwHbJZqTQXC2ye6osF4tNsaDZN58wgn7QKASIHGL0c6vb/nJeF7ie7v2h/ QVIi8UJ2VQ8eQaWb3SiiCasyeFJUY+OMrWPHX7R3Hc5nrfsBIK0Ge9Fb21jQJvI3HyMW ygt5mNieWRQhQ+62jgCV3MlC4jLcV9zfN6WRbareMboQe3nokeE3DZ+7kV/QAC/Zlypl t8jg== X-Gm-Message-State: AOJu0Yz4G2IM6AWqbcgrGuteyL2/tfebn2Mf8fS6sqGsAJ6YXae8zSsu wHvHvKIFflJxJaBABAB84Qg= X-Google-Smtp-Source: AGHT+IGPZIgGiqiQoRnTNwSkb1n4FM8VBJoZC4UuFdNhrP6t/RZ2bgvGvgxmNKODX86VaJLUmfX0Sw== X-Received: by 2002:a5d:614d:0:b0:336:7b51:63e0 with SMTP id y13-20020a5d614d000000b003367b5163e0mr793114wrt.72.1705082216767; Fri, 12 Jan 2024 09:56:56 -0800 (PST) Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id e13-20020a056000178d00b0033743c2d17dsm4528385wrg.28.2024.01.12.09.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jan 2024 09:56:56 -0800 (PST) Message-ID: <65a17d68.050a0220.cf6ea.e78b@mx.google.com> X-Google-Original-Message-ID: Date: Fri, 12 Jan 2024 18:56:55 +0100 From: Christian Marangi To: Jie Luo Cc: Jakub Kicinski , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, linux@armlinux.org.uk, shannon.nelson@amd.com, anthony.l.nguyen@intel.com, jasowang@redhat.com, brett.creeley@amd.com, rrameshbabu@nvidia.com, joshua.a.hay@intel.com, arnd@arndb.de, geert+renesas@glider.be, neil.armstrong@linaro.org, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, m.szyprowski@samsung.com, u-kumar1@ti.com, jacob.e.keller@intel.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ryazanov.s.a@gmail.com, quic_kkumarcs@quicinc.com, quic_suruchia@quicinc.com, quic_soni@quicinc.com, quic_pavir@quicinc.com, quic_souravp@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com Subject: Re: [PATCH net-next 00/20] net: ethernet: Add qcom PPE driver References: <20240110114033.32575-1-quic_luoj@quicinc.com> <20240110142428.52026d9e@kernel.org> <5ec26378-a5ff-4de3-b69e-806e36907db6@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5ec26378-a5ff-4de3-b69e-806e36907db6@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240112_095659_273309_6EF2A4ED X-CRM114-Status: GOOD ( 28.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 11, 2024 at 11:49:53PM +0800, Jie Luo wrote: > > > On 1/11/2024 6:24 AM, Jakub Kicinski wrote: > > On Wed, 10 Jan 2024 19:40:12 +0800 Luo Jie wrote: > > > The PPE(packet process engine) hardware block is available in Qualcomm > > > IPQ chipsets that support PPE architecture, such as IPQ9574 and IPQ5332. > > > > What's the relationship between this driver and QCA8084? > > The PPE (packet processing engine) is the network processing hardware block > in QCOM IPQ SoC. It includes the ethernet MAC and UNIPHY(PCS). This driver > is the base PPE driver which brings up the PPE and handles MAC/UNIPHY > operations. QCA8084 is the external 2.5Gbps 4-port PHY device, which can be > connected with PPE integrated MAC by UNIPHY(PCS). > > Here is the relationship. > PPE integrated MAC --- PPE integrated UNIPHY(PCS) --- (PCS)QCA8084. > > > > > In the last month I see separate changes from you for mdio-ipq4019.c, > > phy/at803x.c and now this driver (none of which got merged, AFAICT.) > > Are you actually the author of this code, or are you just trying > > to upstream bunch of vendor code? > > Yes, Jakub, there are two authors in these patch series, Lei Wei and me. > The patches are already ready for some time, the code has been verified > on the Qualcomm reference design board. These are not downstream drivers > but drivers re-written for upstream. > > > > > Now you're dumping another 10kLoC on the list, and even though this is > > hardly your first posting you're apparently not aware of our most basic > > posting rules: > > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr > > > > The reviewers are getting frustrated. Please, help us help you. > > Stop throwing code at the list and work out a plan with Andrew > > and others on how to get something merged... > > Sorry for trouble caused, will learn about the guidance provided by > the review comments, and follow up on the guidance and have the full > internal review of the patch updates before pushing the patch series. I renew my will of helping in any kind of manner in this, I love the intention for EDMAv2 to have an upstream driver instead of SSDK, hoping in the future to also have the same treatement for EDMAv1 (it's really a pitty to have a support hole with ipq807x not supported) Feel free to send an email or anything, considering this is massive, an extra eye before sending might make things better than reaching (I can already see this) a massive series with at least 20 revision given the complexity of this thing. -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel