From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08A3DC001DB for ; Tue, 8 Aug 2023 14:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S9VQpf7TU6wlpVYUaL8MMrFM+wxfw1XvVbVo+ERwk0s=; b=ZPfxdoroego+VM GIpqukv4wxDmvCxro0CwZMOnkNnjGXbnwLfRqgr/jSTl6VepCCpaOlvJSLMG8GNfq0IFF3L5tMq0/ Dhf/P95Ar1B+2AiD7A+R2LvNL7F8t5bqKHIfy6BWQ4GTNF0Jigp8s6buODkEMwlb51mAX4ZCAZYMr 3v6P8MoCC7cWejdhxeuk1C7gahpcqitAWr1VFt0XgxRKIErQ1ggX/YnA05dW433QnlLfWPt7Sy0t+ XSiu3d5q2Uj2K+9dz/ZjIrhMsER9ekYYtXbVq3dlqc7HyvjBPQGmeTdSE0P5r/jsPCtMPMSyUNRJ6 cfIm/+UOhxxIKhUt3Rvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTO4L-002mGI-0A; Tue, 08 Aug 2023 14:52:21 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTO4H-002mF2-2b for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 14:52:19 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fe0d5f719dso9525439e87.2 for ; Tue, 08 Aug 2023 07:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691506333; x=1692111133; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vsp33dBf7UhgamzOkYxOzQdC3CHLd9zXwnmRE8U0OWI=; b=FJtsozlXJID1D9qrv6qyAK8dhVKdyrmXizPkKLsdwYe/hWySYS30ckguXka9bDDI/i FI+vDUtFRHmwHUm7nKXgt59pRbe+9bMLRBfJgFgSd6OIbSyyC3tJIBPMdtu+g8jy9SlA W+NN/VF6Luu8VYlphnk+hvxUINN2mzHIxVkN8jMjAHDqIZlwuHUBWQKHCkGie6sQ0o7R nhD8rqkX7qnH2TBcVHCaIyvpvAPodDtx6IT2fn8clUT9zhboRgkUChhTWZlnZ63/Y5Gw QUr87EG2FKmsTmpk+Zk2aG0xJNcMuvGLI0EeXRJ9nu7gOse0Bcpq3/hDxpNrJZLj64y9 rhJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691506333; x=1692111133; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vsp33dBf7UhgamzOkYxOzQdC3CHLd9zXwnmRE8U0OWI=; b=OXL11hkYnCtLampjmil/FzOHeH62y2Vf2ryccJhVwdbDGcUfOitEB4xBh8AnJ1lpgJ aRn8Vv4kqwrz7tPZuetlx/D7V5OhS2hmyTLLGrZ1VZvH+FFR/tNJkwdBmNFf0E2+GSS3 yGVpEZpQsZzCFz0Dej3s346YbM2AMV6s6mB0P+dkVqBXVvPNWH97xFMsD6fjf6s8tv+w uYNhb11bqLuTOXXq8yHJNoFwC2l5J/0HDLdI/fXv45/B63Nju+84v4AqntvZZDTaXWdd +pKjKh88VJvT7FSklwQr5ScYjwAhnhY6sEVLmuaL0rJMJPq4BDNWYS/4KwHmMzK1jRju 0kew== X-Gm-Message-State: AOJu0YxxJhzawuptk4H2Ll+eDN4bgZ0amm/QA2RN2H7Jpjs/47wygxlb y6FaJanPmu8b6SIS+ZcqjC27aA== X-Google-Smtp-Source: AGHT+IHJ3hZ82wubWYBzU8TJVHIOBqyUG04wm6z7DeM5yDPFDtsTGPypfW+gUnZ0OMkFJqxWx8oYeQ== X-Received: by 2002:a2e:7e0b:0:b0:2b6:ed80:15d1 with SMTP id z11-20020a2e7e0b000000b002b6ed8015d1mr8862529ljc.24.1691506333010; Tue, 08 Aug 2023 07:52:13 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id v8-20020a170906180800b009934855d8f1sm6817973eje.34.2023.08.08.07.52.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 07:52:12 -0700 (PDT) Message-ID: <65a57225-43d5-fdfa-c12d-3f33f8e535be@linaro.org> Date: Tue, 8 Aug 2023 16:52:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added nxp secure enclave fw Content-Language: en-US To: Pankaj Gupta , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "clin@suse.com" , "conor+dt@kernel.org" , "pierre.gondois@arm.com" , Jacky Bai , Clark Wang , Wei Fang , Peng Fan , Bough Chen , "festevam@gmail.com" , dl-linux-imx , "davem@davemloft.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Gaurav Jain , "alexander.stein@ew.tq-group.com" , Sahil Malhotra , Aisheng Dong , Varun Sethi References: <20230712121219.2654234-1-pankaj.gupta@nxp.com> <20230712121219.2654234-5-pankaj.gupta@nxp.com> <29cb4426-a15e-7186-1713-427f749bc187@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_075217_851776_BD8CAA92 X-CRM114-Status: GOOD ( 19.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 13:49, Pankaj Gupta wrote: > > >> -----Original Message----- >> From: Pankaj Gupta >> Sent: Tuesday, August 8, 2023 5:04 PM >> To: Krzysztof Kozlowski ; >> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; >> clin@suse.com; conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai >> ; Clark Wang ; Wei Fang >> ; Peng Fan ; Bough Chen >> ; festevam@gmail.com; dl-linux-imx > imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; linux-arm-kernel@lists.infradead.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain >> ; alexander.stein@ew.tq-group.com; Sahil Malhotra >> ; Aisheng Dong ; Varun >> Sethi >> Subject: RE: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added >> nxp secure enclave fw >> >> >> >>> -----Original Message----- >>> From: Krzysztof Kozlowski >>> Sent: Thursday, July 13, 2023 12:38 AM >>> To: Pankaj Gupta ; shawnguo@kernel.org; >>> s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com; >>> conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai >>> ; Clark Wang ; Wei Fang >>> ; Peng Fan ; Bough Chen >>> ; festevam@gmail.com; dl-linux-imx >> imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; >>> krzysztof.kozlowski+dt@linaro.org; >>> linux-arm-kernel@lists.infradead.org; >>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain >>> ; alexander.stein@ew.tq-group.com; Sahil Malhotra >>> ; Aisheng Dong ; >> Varun >>> Sethi >>> Subject: [EXT] Re: [PATCH v4 4/7] arm64: dts: imx93-11x11-evk: added >>> nxp secure enclave fw >>> >>> Caution: This is an external email. Please take care when clicking >>> links or opening attachments. When in doubt, report the message using >>> the 'Report this email' button >>> >>> >>> On 12/07/2023 14:12, Pankaj Gupta wrote: >>>> Added support for NXP secure enclave called EdgeLock Enclave >>>> firmware >>>> (se-fw) for imx93-11x11-evk. >>>> >>>> Signed-off-by: Pankaj Gupta >>>> --- >>>> arch/arm64/boot/dts/freescale/imx93.dtsi | 11 ++++++++++- >>>> 1 file changed, 10 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> index 8643612ace8c..2b0f901d2709 100644 >>>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>> @@ -1,6 +1,6 @@ >>>> // SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>> /* >>>> - * Copyright 2022 NXP >>>> + * Copyright 2022-2023 NXP >>>> */ >>>> >>>> #include @@ -863,5 +863,14 @@ >>>> ddr-pmu@4e300dc0 { >>>> reg = <0x4e300dc0 0x200>; >>>> interrupts = ; >>>> }; >>>> + >>>> + ele_fw: se-fw { >>>> + compatible = "fsl,imx93-ele"; >>>> + mboxes = <&s4muap 0 0 &s4muap 1 0>; >>> >>> This should be two entries. >>> >>>> + mbox-names = "tx", "rx"; >>>> + fsl,mu-did = <3>; >>>> + fsl,mu-id = <2>; >>> >>> Drop both. Since you put it into the DTSI, it means it is compatible specific. >> [Pankaj] Removed the above three entries. > > > [Pankaj] Correction: > I missed to note that in our up-coming SoC(s), there will be multiple MU(s): > Those can only be identified using mu_id. Hence, following two only, will be removed: > + mbox-names = "tx", "rx"; > + fsl,mu-did = <3>; Which SoC? How the bindings are going to look like for that SoC? What is mu-did in such case and how does it relate to different mailboxes? Why it cannot be inferred from compatible? BTW, responding three weeks after my review does not help your case. I totally loose the context. Of course you can reply even after 1 year, it's your right, but it does not help the discussion. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel