From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 00/14] ASoC: Constify local snd_sof_dsp_ops
Date: Tue, 23 Apr 2024 18:06:13 +0200 [thread overview]
Message-ID: <65a5837d-36b3-41bd-b03f-d4f93b30d5c8@kernel.org> (raw)
In-Reply-To: <735d6dbc-86e4-4747-9bd9-2574ead7d039@linux.intel.com>
On 23/04/2024 17:57, Pierre-Louis Bossart wrote:
>
>> Are we talking about basic C now? Of course it does not mean that and I
>> already explained what is the goal of this - the static or global memory
>> in the driver can be moved to rodata.
>
> the dsp_ops used by the Intel drivers cannot be moved to rodata in all
> cases. the baseline is constant, all extensions for TGL+ are dynamically
> allocated and modified.
Yes and these drivers will not benefit. Did I changed them here? I think
I didn't, because then it would not compile.
Can we discuss specific patches in this patchset? Which constifying of
static or global data is not correct, is misleading or is not beneficial
at all?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-23 16:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 18:47 [PATCH 00/14] ASoC: Constify local snd_sof_dsp_ops Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 01/14] ASoC: SOF: debug: " Krzysztof Kozlowski
2024-04-26 2:09 ` Mark Brown
2024-04-26 7:58 ` Krzysztof Kozlowski
2024-04-26 8:00 ` Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 02/14] ASoC: SOF: ipc3: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 03/14] ASoC: SOF: pcm: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 04/14] ASoC: SOF: Constify stored pointer to snd_sof_dsp_ops Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 05/14] ASoC: SOF: intel: pci-tng: Constify snd_sof_dsp_ops Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 06/14] ASoC: SOF: intel: hda: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 07/14] ASoC: SOF: amd: acp: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 08/14] ASoC: SOF: imx8: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 09/14] ASoC: SOF: imx8m: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 10/14] ASoC: SOF: imx8ulp: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 11/14] ASoC: SOF: intel: bdw: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 12/14] ASoC: SOF: intel: byt: " Krzysztof Kozlowski
2024-04-14 18:47 ` [PATCH 13/14] ASoC: SOF: mediatek: mt8186: " Krzysztof Kozlowski
2024-04-15 10:49 ` AngeloGioacchino Del Regno
2024-04-14 18:47 ` [PATCH 14/14] ASoC: SOF: mediatek: mt8195: " Krzysztof Kozlowski
2024-04-15 10:49 ` AngeloGioacchino Del Regno
2024-04-15 14:19 ` [PATCH 00/14] ASoC: Constify local snd_sof_dsp_ops Pierre-Louis Bossart
2024-04-22 5:43 ` Krzysztof Kozlowski
2024-04-22 15:52 ` Pierre-Louis Bossart
2024-04-22 19:45 ` Krzysztof Kozlowski
2024-04-22 20:42 ` Pierre-Louis Bossart
2024-04-22 20:47 ` Krzysztof Kozlowski
2024-04-22 21:24 ` Pierre-Louis Bossart
2024-04-23 9:42 ` Krzysztof Kozlowski
2024-04-23 15:57 ` Pierre-Louis Bossart
2024-04-23 16:06 ` Krzysztof Kozlowski [this message]
2024-04-25 16:12 ` Pierre-Louis Bossart
2024-05-01 13:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65a5837d-36b3-41bd-b03f-d4f93b30d5c8@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).