From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C8FC433DB for ; Wed, 23 Dec 2020 15:39:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE9572222D for ; Wed, 23 Dec 2020 15:39:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE9572222D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SEioG/BBZVhAJXKdbPwkAw4L8ADknItTSZAMTmdUZ/I=; b=VTZ4jyz4iiGlsNUJxiVBR+tiT 116DDYleLD43N1IxAWd4kwkJpVpoQ5M/ksBJ2b5Lyh2NtPvrLmDoDIW8z8jwJS8MJH4Xpqa+dCAH/ e5WLwJ3R+ZkVkOsw2BwbcQ8CmjnP+zea7eY6Juf7gGew4xJm5UiJS1XtNaq6Ht1gAKsAsMfj/E1j2 Fi143XoBditpNyp+VBbwwgiWEWUY6jsY8GravP7q3joHFVglYwlmspnDGGbYZwMYLyPKhJqL9fvn7 Pb8QSKOiJOm6iIL11q/oZvudneKHGg9bD/Y+hstREEtdS0njAQwLtXZEXMBPJrdkY30GVqXG29LnI rwwF7XIlQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ks6Db-0000EN-5R; Wed, 23 Dec 2020 15:38:27 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ks6DY-0000Dl-OM for linux-arm-kernel@lists.infradead.org; Wed, 23 Dec 2020 15:38:25 +0000 Received: by mail-wm1-x333.google.com with SMTP id r4so6493062wmh.5 for ; Wed, 23 Dec 2020 07:38:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=FLK03MoPTeVjiiFwNtS1OJi+2ld8fgev60+sqAPXpLo=; b=aC3XOqzY6SoQTeia6KLuOxot8sYnDpr+WcX5Gf8TnqSRzAGywSgSslZ3koDvjM6ib3 Pdi8mTDstbmvSu74oQEOtEGOcaGapMdnt2guYjiyiuNyI9a0TublPIgvHTytVaRBjlZT P6j/dMWOfY+mTZFcmLTsQreejEnkaqN7T3glvlvOKrKRJBytjK48P5nyy1ekeQIxEJAB gda50nuPKtQTzYWtUjJf88582ql+s/mzHL29B5zze3o1y6CijcBcwgJuKKQ8+HjIiYYF PGpvC72eJLuyXVCZV+q1RrmtxpKoco3/pXOVOVNIk2k/ntzBIAeEEqbwtGUoGa90XnNF ZrPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FLK03MoPTeVjiiFwNtS1OJi+2ld8fgev60+sqAPXpLo=; b=oDJ54Jbg0EnaoyhnOnDaNBWrw2WjwZaIj+cYVYfklxxKFycOvAFlWDgzM3L1XPSTmV Kmnk+SdKbRFLNE3ujF1BClCKCo44sHwOfHwlwtyDMvrCC2iuMKZe7INwhiCvbYY/grLu HiByBGME6Z30uN7fuftgjSxPPonIPFnamN3dscN8fwghgKdsIu6+fOwg8p7DvXqH1BVT wDekXK130rg4jaSBbrOzCVSv/aaDtPOz5EDY4zfpreVcU+MdjaeGXOT40uy+d3Ga+xs8 wkzWE1CmAWp5NrQLu5qyG+blPHBvuztddBDNX1P/lqnV8uA9tfsY9yZDYHEVzMIGWkp2 belw== X-Gm-Message-State: AOAM530OSMh8sMPQt+kSoXnE1VP3mMLUerUcnE0EhKcL12mlSvfqUI/5 uhAmHvpsVG8HOtkcnAlT3FSMrQ== X-Google-Smtp-Source: ABdhPJytXmL1Uj/jup8IDzFLZKwpMK6mZxS/1lbVrDQSOq3KCd2Df1ttM6R0Ksfu/w1e0jCslBiSlA== X-Received: by 2002:a7b:cb93:: with SMTP id m19mr301307wmi.128.1608737901527; Wed, 23 Dec 2020 07:38:21 -0800 (PST) Received: from MacBook-Pro.local ([212.45.64.13]) by smtp.googlemail.com with ESMTPSA id y11sm212109wmi.0.2020.12.23.07.38.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 07:38:20 -0800 (PST) Subject: Re: [PATCH v2 1/7] iommu/io-pgtable: Introduce dynamic io-pgtable fmt registration To: "Isaac J. Manjarres" , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org References: <1608597876-32367-1-git-send-email-isaacm@codeaurora.org> <1608597876-32367-2-git-send-email-isaacm@codeaurora.org> From: Georgi Djakov Message-ID: <65b5382c-c7a9-0f18-96da-fe49e92e3b00@linaro.org> Date: Wed, 23 Dec 2020 17:38:19 +0200 MIME-Version: 1.0 In-Reply-To: <1608597876-32367-2-git-send-email-isaacm@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201223_103824_876143_25D4ACF4 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: will@kernel.org, pdaly@codeaurora.org, kernel-team@android.com, joro@8bytes.org, robin.murphy@arm.com, pratikp@codeaurora.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Isaac, On 22.12.20 2:44, Isaac J. Manjarres wrote: > The io-pgtable code constructs an array of init functions for each > page table format at compile time. This is not ideal, as this > increases the footprint of the io-pgtable code, as well as prevents > io-pgtable formats from being built as kernel modules. > > In preparation for modularizing the io-pgtable formats, switch to a > dynamic registration scheme, where each io-pgtable format can register > their init functions with the io-pgtable code at boot or module > insertion time. > > Signed-off-by: Isaac J. Manjarres > --- > drivers/iommu/io-pgtable-arm-v7s.c | 34 +++++++++++++- > drivers/iommu/io-pgtable-arm.c | 90 ++++++++++++++++++++++++++---------- > drivers/iommu/io-pgtable.c | 94 ++++++++++++++++++++++++++++++++------ > include/linux/io-pgtable.h | 51 +++++++++++++-------- > 4 files changed, 209 insertions(+), 60 deletions(-) > > diff --git a/drivers/iommu/io-pgtable-arm-v7s.c b/drivers/iommu/io-pgtable-arm-v7s.c > index 1d92ac9..89aad2f 100644 > --- a/drivers/iommu/io-pgtable-arm-v7s.c > +++ b/drivers/iommu/io-pgtable-arm-v7s.c > @@ -28,6 +28,7 @@ [..] > +static int __init arm_lpae_init(void) > +{ > + int ret, i; > + > + for (i = 0; i < ARRAY_SIZE(io_pgtable_arm_lpae_init_fns); i++) { > + ret = io_pgtable_ops_register(&io_pgtable_arm_lpae_init_fns[i]); > + if (ret < 0) { > + pr_err("Failed to register ARM LPAE fmt: %d\n"); I guess we want to print the format here? Thanks, Georgi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel