From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33524C4828D for ; Sat, 3 Feb 2024 17:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kD5zu9Xt+IqD9ypalGCuY15JEM11pCrjWUQQqD72op4=; b=FCCd6+E13wCAXk 2W/jGCxFNCCOmMJvHyINyjQdJSYK+uDuy9UNPCqL5P/pHERxaLnHBsWQN8o1JS6nYerVAXcA3w7Iz +55I41Thn85wIj1dVZ8l6l9Tf4xBJbfdzLi62u9x/HLCucx1qJhRE4Y1pLsxFmwwRoBWC0AVEXOt9 mC3CuelJIqjWU7/0XTt0Mzh6uz27alqjcgNDRUyGpon3vRXRfjsyWScct1UBS1IUHxYb7sby70pMk BprAdznXgjgOyjlfVzEC5GxFoGsH4YV5eCbtXYnZGuAYbTKt+Pl0EtcOlMXeDZRC5yOkxAFkfMv+p SuXEAJzPXTyc/i1kk9gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWJRI-0000000GsVs-2eWn; Sat, 03 Feb 2024 17:04:24 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWJRF-0000000GsV9-1PhK for linux-arm-kernel@lists.infradead.org; Sat, 03 Feb 2024 17:04:22 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-337cc8e72f5so2120718f8f.1 for ; Sat, 03 Feb 2024 09:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706979859; x=1707584659; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=TBi/Nc1i2t/W1SgnYyQ4Q7g6GmRkbvT5WO516nweNOI=; b=EzkgbSyYJJrw32kRpdmkSewctAc/IlwQD0DZbjT51rtNzyeGgz6Ytf6rtUqXq92N8A ZEF9wCbk5Gg3YVuUZcjS3eFB9SRag0jsEoL19DfaBef4nlpxfVLeVYfjvQlL5Xv57WDM gmDCZVU+gaOm/8aJmTFLP37+2xk+OsO03JqB6UHaKhai9N8qSDTf/mMetTd4Mr6+Echt Jc9Px7S4silCLXuxxtnLi/eJU3NVI30nYwV7/UnI4wX/XPEBuqh9HUQvS+mnz5vav5C9 G2Jnlj3nIWnrkj5KJMLw9dlN5WlW2JJHAm4HNPfudfV/c6CNUennWL51dUWBmoD70gIE jwBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706979859; x=1707584659; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TBi/Nc1i2t/W1SgnYyQ4Q7g6GmRkbvT5WO516nweNOI=; b=YCIgKXMTzpQ93VLnW+sjHPNOvVYYyQIfFUyAUHVuyh0gtEhft8pdJihbx8foU6TjDM AuaQnaXJW9iNBnLlgxG0klGVjbMS8QRarPYFLANuCrz8/m+VVsIgDN6b+tYbFjE1Db67 TSXFPOZyZfI3LmZAGtFjiJGxAsfWbLEb1ip/JzfUurrYYVAZR04Wyi1B7xn7uHuYo6B7 CBBGH56K9a+ksdL+WOYTB/nD+yfi6LW36bJqUdcUfoc/Lkn2NDdHhDOz+3fkWe1+Nlz6 lx32EhT0vAXv2p2BTiw6b7aWVoddczDuZRuhi1rFoaOokthGbF1g8oDwtRZOFcK/BG0H 6d2A== X-Gm-Message-State: AOJu0YyVsyTmkBeHf5lRkdQRaHT6YFTEv6Y1cTarCcoA6+41bCPWgPrW dB+SNJ6mXtBtANaJAtc4Nmuqk50pED3DfaXOQupjoFIzDtxLsdYb X-Google-Smtp-Source: AGHT+IE2sRCo9aMUzcE2BowU+Tg9+phzkpzCtpC1KXuZjX5RRJvtWkA1jPMnVFLoMJV9aMaBH3SvtQ== X-Received: by 2002:a5d:60ce:0:b0:33a:e838:7184 with SMTP id x14-20020a5d60ce000000b0033ae8387184mr6084806wrt.2.1706979858843; Sat, 03 Feb 2024 09:04:18 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVGozpBKo6LgmM9JZVgj2YEAGMNedxJBZwlTNFYAhUPsG0n+6pq8aoJapjkw7R3BhlcyLCsX212Kd9uL0dS6DvvjmuAs25FceMbBLR9AdHeZn031MgX9AoAxNA3ZTCXvAh2Z0APxJRXFPWCK4A9mUd1MHNQkCC10RKEZDtIs+1jO8HoCd+ZxAqZsMaMw7xeXQXd2XTRdpirPhIlKlTsZPHabuTJw4Ty8+5Wgrm66THEK9pxodQEA81OVs364lFchl/sfpW9JgNEXy0S2pZ5TkRQZT2SGV+P8WJm2GiT+BxPWtajWMl4aA== Received: from Ansuel-xps. (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.gmail.com with ESMTPSA id h13-20020a05600c260d00b0040fb0bf6abesm3380368wma.29.2024.02.03.09.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Feb 2024 09:04:18 -0800 (PST) Message-ID: <65be7212.050a0220.d2de9.e25c@mx.google.com> X-Google-Original-Message-ID: Date: Sat, 3 Feb 2024 18:04:14 +0100 From: Christian Marangi To: Andrew Lunn Cc: "Russell King (Oracle)" , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next] net: phy: constify phydev->drv References: <7f4f7fc2-6bf3-4ecb-9c13-763e2d4f176f@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7f4f7fc2-6bf3-4ecb-9c13-763e2d4f176f@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240203_090421_402882_E41761AE X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 03, 2024 at 05:56:19PM +0100, Andrew Lunn wrote: > On Fri, Feb 02, 2024 at 05:41:45PM +0000, Russell King (Oracle) wrote: > > Device driver structures are shared between all devices that they > > match, and thus nothing should never write to the device driver > > nothing should never ??? > > I guess the never should be ever? > > > diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c > > index 7fd9fe6a602b..7b1bc5fcef9b 100644 > > --- a/drivers/net/phy/xilinx_gmii2rgmii.c > > +++ b/drivers/net/phy/xilinx_gmii2rgmii.c > > @@ -22,7 +22,7 @@ > > > > struct gmii2rgmii { > > struct phy_device *phy_dev; > > - struct phy_driver *phy_drv; > > + const struct phy_driver *phy_drv; > > struct phy_driver conv_phy_drv; > > struct mdio_device *mdio; > > }; > > Did you build testing include xilinx_gmii2rgmii.c ? It does funky > things with phy_driver structures. > Looking at the probe function it seems they only swap phy_drv with conv_phy_drv but it doesn't seems they touch stuff in the phy_dev struct. Looks like the thing while hackish, seems clean enough to follow the rule of not touching the OPs and causing side effects. -- Ansuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel