From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 373ECC54FD0 for ; Mon, 27 Apr 2020 10:09:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08428206E2 for ; Mon, 27 Apr 2020 10:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TkGOi+46"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RjtiLI2E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08428206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GkWC8S8d5UBjpEIuyyEXbr5DiSOQJFaXyCkkwdrjyBo=; b=TkGOi+4650upY+ WNiXvqcz8nWw+jJ8uLxo8PETd2a7rsw+PSFPN58cBlN/zZXzyRP0oJHsHaFlfEhqj6SEI5wdCSh0z LWk9sni9p5wgXmWT7S4XmjgCVth1Piuak6ns/6xO+Vs6E5zS40tauPswFePWsulXErG0lrPPJKHli NT1VRrGP0SMzODlCyKF/0wgn+WEYQR8oS1/Yj8hHydbDxQ3YIk4S70ve1c8ypekpjeXlwAoxTwIx1 mEYacVRVUcTSkR7RbjKIjLuviICe2Ji1LJWCVYonpNlHBN3qQCOQoNz7ypY5g+lKj6LoqOM2HnMmv JhXL7xiQl+bQgDivJ6rQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT0hT-0002w4-C5; Mon, 27 Apr 2020 10:09:19 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT0hE-0002i1-Kn; Mon, 27 Apr 2020 10:09:06 +0000 Received: by mail-wr1-x442.google.com with SMTP id d17so19826110wrg.11; Mon, 27 Apr 2020 03:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qcspjBGVZxocuiJzSFh7wsE2tv0Go4/T/FP6I0OkrlE=; b=RjtiLI2EVZAssgGj2WwvJfJK2t7gOoC4qqSpkwvw+nPhFFUOdGmZ9yQBeCi+C4eb5h ECMtJBcnUK2P2u+QIT0lsViuUTDp7oMJwvbmLuvPZVHbxjYFZVERmkXD4WpAthgdvE3D 5YPP52pnEv9EBgUMGbsitayPEQ8dyLUGtmoB1chdsKgAiSXddnGXM8AqhQ+BU0uY93Ui Asx5nTXYz6FykQ5mS1ITFaomJgVOspO0a8SAPLfM6kNtzpOXZ8iC5G6hqp9fqABf9mBC 2CrIq0sl86Hy3bHx+pEfZt2t19YofrAWAvHzKnsI0G1Hw4V7+nkupeRRkPFHwnQam03N /JhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qcspjBGVZxocuiJzSFh7wsE2tv0Go4/T/FP6I0OkrlE=; b=b1FPVewbPffGBodhXQrC0GHpt/UWmlrWDJLFP8t1yxuSa19flML3HJfNd7cI6UemDd 11/X9C+R8WDAvlCIw7oYYDKcCUEzmYW6A8qDv3IomzeJgRjOL//RcSpWhiZ5qRhKWGYq 0DnvdnBLCNF5ZrZZbrnCFccfN+iiim8iaU4HaCbOEY6RcMcNYW7DaAAY8DmJuoy08YCn URYVyvAU/M/TgKskvqwoZ6YZaDS3AMsmVT61kxa8dHb9dHqlplINBqg18wMYnBEBKJP/ pDuFC1EziqBFyELcv395tix2dKJpPfeI2Oaib4XkBxKDIOaoUFCYfaVNt39+3Y1MdV3D pwnQ== X-Gm-Message-State: AGi0PuaOo4KtOBb2/WBtnd5wK8T2EO1oKfidERk6nUZnLVeR02F5paBM 0vfXpiwHrOFBUkvdQKZjymM= X-Google-Smtp-Source: APiQypJrScIJUNHBYR71zdqUyKpvYWTJM9XGtBmSKd7PelGVAfOJGGDlE5drsq3ChuDFkafv+oYaFQ== X-Received: by 2002:a5d:6a8b:: with SMTP id s11mr26135247wru.258.1587982141506; Mon, 27 Apr 2020 03:09:01 -0700 (PDT) Received: from [192.168.2.1] (ip51ccf9cd.speed.planet.nl. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id p16sm20013661wro.21.2020.04.27.03.09.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2020 03:09:00 -0700 (PDT) Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers To: Chen-Yu Tsai References: <20200427073132.29997-3-wens@kernel.org> <684132b8-4a84-8295-474b-38ccb992bba7@gmail.com> From: Johan Jonker Message-ID: <65d15254-08da-895c-1a0c-ef6ce231b620@gmail.com> Date: Mon, 27 Apr 2020 12:08:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_030904_748153_C76A8849 X-CRM114-Status: GOOD ( 32.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Pavel Machek , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, linux-arm-kernel , dmurphy@ti.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/27/20 11:17 AM, Chen-Yu Tsai wrote: > On Mon, Apr 27, 2020 at 4:57 PM Johan Jonker wrote: >> >> Hi Chen-Yu, >> >>> From: Chen-Yu Tsai >>> >>> With SDIO now enabled, the numbering of the existing MMC host controllers >>> gets incremented by 1, as the SDIO host is the first one. >>> >>> Increment the numbering of the MMC LED triggers to match. >>> >>> Fixes: cf3c5397835f ("arm64: dts: rockchip: Enable sdio0 and uart0 on rk3399-roc-pc-mezzanine") >>> Signed-off-by: Chen-Yu Tsai >>> --- >>> arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts | 8 ++++++++ >>> arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 4 ++-- >>> 2 files changed, 10 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts >>> index 2acb3d500fb9..f0686fc276be 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts >>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-mezzanine.dts >>> @@ -38,6 +38,10 @@ vcc3v3_pcie: vcc3v3-pcie { >>> }; >>> }; >>> >>> +&diy_led { >>> + linux,default-trigger = "mmc2"; If you decide to use a free form trigger that is not a 'standard' one, then it becomes a user property. User defined properties should not go in a generic dts. It's up to the user what function he/she gives to that led! >>> +}; >>> + >>> &pcie_phy { >>> status = "okay"; >>> }; >>> @@ -91,3 +95,7 @@ &uart0 { >>> pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>; >>> status = "okay"; >>> }; >>> + >>> +&yellow_led { >>> + linux,default-trigger = "mmc1"; >>> +}; >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >>> index 9f225e9c3d54..bc060ac7972d 100644 >>> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi >>> @@ -70,14 +70,14 @@ work-led { >>> linux,default-trigger = "heartbeat"; >>> }; >>> >> >>> - diy-led { >>> + diy_led: diy-led { >> >> This changes an existing nodename into something that is still not the Correction: It takes an existing nodename and adds a label. >> preferred way. In the current Rockchip dts there are nodenames like >> 'work', 'yellow' that causing warnings with the command: > > This doesn't change the node name at all. It only adds a label. > If it doesn't pass the check now, it didn't pass the check before. > > I just realized that the footnote I added before is gone because I > regenerated the patches. The original footnote was something along > the lines of: > > I opted to not change the node names nor the labels as the discussion > had not concluded. The other reason being that people may have scripts > or device tree overlays depending on the existing node names. > > Previously I asked the following but got no response: > > Is changing this after it has been in some kernel releases OK? Wouldn't > it be considered a break of sysfs ABI? > > Also, is there some guideline on how to name the labels? For sunxi we've > been doing "${vendor}:${color}:${function}" since forever. > > As far as I can tell, the hardware vendor [1] has no specific uses for > these two (red and yellow) LEDs designed in. And their GPIO lines are > simply labeled "DIY" (for the red one) and "YELLOW". So I'm not sure > if putting "our" interpretations and the default-trigger into the > label is wise. > > For reference, the green one has its GPIO line labeled "WORK", and their > intention from [1] is to have it as some sort of power / activity indicator. > Hence it is named / labeled "work". > > As for the node names, I think we can keep it as is for now. It's not > the preferred form, but there's really no need to change it either. > And some overlay or script might actually expect that name. > >> make -k ARCH=arm dtbs_check >> >> Could you give a generic guide line/example, so all these changes are >> treated the same way? As if the naming follows the preferred 'led-0' line. > > I'm not sure what you are asking for. Your nodename just happend to contain 'led' to pass the regex. There are many other names in use. 'If' the DT maintainer (=Heiko) decides the get rid of all the warnings for led nodes then that change would require all nodename to be handled to same (=preferred way): Change this: diy_led: diy-led yellow_led: yellow-led Into something like: led_0: led-0 led_1: led-1 > > ChenYu > >>> label = "red:diy"; >>> gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> linux,default-trigger = "mmc1"; >>> }; >>> >>> - yellow-led { >>> + yellow_led: yellow-led { >>> label = "yellow:yellow-led"; >>> gpios = <&gpio0 RK_PA2 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> -- >>> 2.26.0 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel