From: Matthias Brugger <matthias.bgg@gmail.com>
To: xinlei.lee@mediatek.com, chunkuang.hu@kernel.org,
p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
yongqiang.niu@mediatek.com, enric.balletbo@collabora.com
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
jitao.shi@mediatek.com
Subject: Re: [PATCH 1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186
Date: Wed, 6 Jul 2022 16:20:06 +0200 [thread overview]
Message-ID: <65d390ab-7f80-8bd4-66f5-442c46da4f00@gmail.com> (raw)
In-Reply-To: <1656645344-12062-2-git-send-email-xinlei.lee@mediatek.com>
On 01/07/2022 05:15, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add mmsys func to manipulate dpi output format config for MT8186.
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/soc/mediatek/mt8186-mmsys.h | 1 +
> drivers/soc/mediatek/mtk-mmsys.c | 8 ++++++++
> include/linux/soc/mediatek/mtk-mmsys.h | 2 ++
> 3 files changed, 11 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mt8186-mmsys.h b/drivers/soc/mediatek/mt8186-mmsys.h
> index eb1ad9c37a9c..0b450b00b829 100644
> --- a/drivers/soc/mediatek/mt8186-mmsys.h
> +++ b/drivers/soc/mediatek/mt8186-mmsys.h
> @@ -3,6 +3,7 @@
> #ifndef __SOC_MEDIATEK_MT8186_MMSYS_H
> #define __SOC_MEDIATEK_MT8186_MMSYS_H
>
> +#define MT8186_MMSYS_DUMMY0 0X400
I don't have access to the datasheet, but I really wonder if it's really called
dummy0. If so, you would need to explain in more detail in the commit message.
Regards,
Matthias
> #define MT8186_MMSYS_OVL_CON 0xF04
> #define MT8186_MMSYS_OVL0_CON_MASK 0x3
> #define MT8186_MMSYS_OVL0_2L_CON_MASK 0xC
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> index 2b0b805c65dd..de3f11cb931f 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -252,6 +252,14 @@ void mtk_mmsys_ddp_disconnect(struct device *dev,
> }
> EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect);
>
> +void mtk_mmsys_ddp_dpi_confing(struct device *dev, u32 mask, u32 val,
> + struct cmdq_pkt *cmdq_pkt)
> +{
> + mtk_mmsys_update_bits(dev_get_drvdata(dev), MT8186_MMSYS_DUMMY0, mask,
> + val, cmdq_pkt);
> +}
> +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_dpi_confing);
> +
> void mtk_mmsys_merge_async_config(struct device *dev, int idx, int width, int height,
> struct cmdq_pkt *cmdq_pkt)
> {
> diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h
> index 343e093f0fc3..40c538c0664b 100644
> --- a/include/linux/soc/mediatek/mtk-mmsys.h
> +++ b/include/linux/soc/mediatek/mtk-mmsys.h
> @@ -90,4 +90,6 @@ void mtk_mmsys_mixer_in_config(struct device *dev, int idx, bool alpha_sel, u16
> void mtk_mmsys_mixer_in_channel_swap(struct device *dev, int idx, bool channel_swap,
> struct cmdq_pkt *cmdq_pkt);
>
> +void mtk_mmsys_ddp_dpi_confing(struct device *dev, u32 mask, u32 val,
> + struct cmdq_pkt *cmdq_pkt);
> #endif /* __MTK_MMSYS_H */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-06 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 3:15 [PATCH 0/2] Add dpi output format control for MT8186 xinlei.lee
2022-07-01 3:15 ` [PATCH 1/2] soc: mediatek: Add mmsys func to adapt to dpi output " xinlei.lee
2022-07-06 14:20 ` Matthias Brugger [this message]
2022-07-12 4:17 ` xinlei.lee
2022-07-01 3:15 ` [PATCH 2/2] drm: mediatek: Adjust the dpi output format to MT8186 xinlei.lee
2022-07-01 6:33 ` Rex-BC Chen
2022-07-05 4:11 ` xinlei.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65d390ab-7f80-8bd4-66f5-442c46da4f00@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=xinlei.lee@mediatek.com \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).