From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DBBBC47074 for ; Wed, 3 Jan 2024 00:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HZgmsmpbl9zlXeq0SQwsaq8W1snq2VeBTxUV5DN2GcA=; b=tG/UzDej7lHwAy pq9CK2HMjNf1BQeEdjLLaT94YEz7afqJjy+R+cMC2zqXocbMFGouTDYISlwaLBKiJ2vBBIrzwHcBV x4wya3sxo0hXzGYj1wFN4Igf+4RvznuvfLEd5eOP2wMrMj1LYdDHeW1N5WzkB3PbSybHCUt7xsQXY FrWn7mc/jynL62U1t0uKsjINEI/94VOWxvMmx3/faNuxfCJDnIjigHFZqABvs5IBvrxZssFiCaUPe OASRpHHs2zsuVg7c12YUEBjRMD1SmgiXY5qRb6sKmDHsMlhhq6ZfzQTeQw+RacoML07iUKELjKf3G 5NiDixkW4dBK44aU78rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKpU3-009QAi-39; Wed, 03 Jan 2024 00:51:48 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKpU2-009Q8l-00; Wed, 03 Jan 2024 00:51:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A9789CE1284; Wed, 3 Jan 2024 00:51:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6563C433C7; Wed, 3 Jan 2024 00:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704243103; bh=k9n78YdF+0o39NnDck1txg5213yk2YnfbSg31If7lfM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Ixnmex/I2/V9aSGETjWrbJ2IR2/EPlYoNULE96nHZCmWjLRG2RGSGS0eCBvnTsblu HzUF8Mv6uyqx6kIKd7+NzC6Sm96Myz/m8KEEWWOhOZcCTsoHJjFzVPatCYwrNks+K1 jJoPfBUanOuD2FeymRj8w/F9M3xwSlMVCOcf2WrNaITxyO7TPld5+at3CyNTCTMazE JUok9I5M5tjc5pQfpA1+1Er4p9dTW93QDvjzrk90ucJvIfrpA8hI24VP40vRMKVKSC t6LQDRZZsl82133Z/sJwRqwx6ZvB3wnP0d7MzD2Nx2ukeZ/vKQoAwg0bFMDsUwzgsx P9u+nbl35D8GQ== Message-ID: <65e4793fc4aaeadbda9b422e1ac8cc0c.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20231103102533.69280-4-angelogioacchino.delregno@collabora.com> References: <20231103102533.69280-1-angelogioacchino.delregno@collabora.com> <20231103102533.69280-4-angelogioacchino.delregno@collabora.com> Subject: Re: [PATCH v3 3/3] clk: mediatek: mt8188-topckgen: Refactor parents for top_dp/edp muxes From: Stephen Boyd Cc: mturquette@baylibre.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, wenst@chromium.org, msp@baylibre.com, amergnat@baylibre.com, yangyingliang@huawei.com, u.kleine-koenig@pengutronix.de, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com To: AngeloGioacchino Del Regno Date: Tue, 02 Jan 2024 16:51:40 -0800 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240102_165146_250546_DC2915E0 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting AngeloGioacchino Del Regno (2023-11-03 03:25:33) > The top_dp and top_edp muxes can be both parented to either TVDPLL1 > or TVDPLL2, two identically specced PLLs for the specific purpose of > giving out pixel clock: this becomes a problem when the MediaTek > DisplayPort Interface (DPI) driver tries to set the pixel clock rate. > > In the usecase of two simultaneous outputs (using two controllers), > it was seen that one of the displays would sometimes display garbled > output (if any at all) and this was because: > - top_edp was set to TVDPLL1, outputting X GHz > - top_dp was set to TVDPLL2, outputting Y GHz > - mtk_dpi calls clk_set_rate(top_edp, Z GHz) > - top_dp is switched to TVDPLL1 > - TVDPLL1 changes its rate, top_edp outputs the wrong rate. > - eDP display is garbled > > To solve this issue, remove all TVDPLL1 parents from `top_dp` and > all TVDPLL2 parents from `top_edp`, plus, necessarily switch both > clocks to use the new MUX_GATE_CLR_SET_UPD_INDEXED() macro to be > able to use the right bit index for the new parents list. > > Signed-off-by: AngeloGioacchino Del Regno > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel