From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 027C3C07E9D for ; Thu, 29 Sep 2022 07:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OVIUayNVm4inTgm0Lajbw8kdyxxnI7B8gAu8xWFXqEc=; b=gCROJF27tQ4B2T i09KKpJXxIUyrKMvBnBR+TxY0ZzbnClbV7ijdKjXuA96sVF9ihOAW5DAhLlzVO+Wc0gW5F6LVOuPU /qos05yq8hPB8mATX+ZP4ktYIczIbMy3GWUgzm78Jr/dS4lwB6fpvYwh1QCgU/b8wCoZhdsHntsLu Q3n4C5baDgyWC6Wu/GifFJYjx1KQOPneBQZq8qbz/7eZMgzaXv334besEacTSUs1yOO5sN4rbL6OO ltNGknrkwjBFWIZ8Q5vaISroj3DEF6mUgPvETzcrS4SLMRGZRKJMhN4lWZluSuzBpuON4YjP2w0ay wXkiQ5xecKn3VX7P+55w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odo6n-001bZS-0Z; Thu, 29 Sep 2022 07:37:25 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odo6X-001bSa-Ft for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 07:37:10 +0000 Received: by mail-lf1-x12e.google.com with SMTP id k10so990119lfm.4 for ; Thu, 29 Sep 2022 00:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=C6HAcFRlUdRVNTmd1+LZDEckWRqIi/Jw90W8yfGFuaM=; b=qrePgKY/Y+Vm7/UZSq1RNCj98EF+ZGGgs4eAocWnvNy3OL+hbXXhm7/hlNBWZtmh+w HHpePbG503tmykGObV5MPrA42fKiouTwqXxUHeY6180cJ+hwMma60u7Mr31ZuIXyZjGk CB9Ko/qcwaZ/9bEzlE5LXclzRuAQ6M7MmVNiSzr1s1P7jPgaWG/x39v200VI0dx3K5Uh QgCNllL/mAQ2nJttbLYW4lxDr/Ce783BOmFE/L4c+jovVnoqxtcBGniMStFJUiG3+JhX b3+WuUBiZHWhsY0POKuA/irYlQuOJ0S2R9kBBDhWDQIDWbm887eHhwRtrapD53VfNVdN mzxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=C6HAcFRlUdRVNTmd1+LZDEckWRqIi/Jw90W8yfGFuaM=; b=AssrEhRfQwlQ910V130OLsZQkRO/a9V1RZBywcloZG705/jl3sXi1dM7fgNuGoiS4T BaUr2kXr2frATdGX+yhZyfCM5nZPR/9ZB2qmKj25V/n+Sl6fQC4vqfRDHiW/ETZwsm9V hV5GCZ/YXSo+C9HpKsKACFsz5V4XtusEUOx70UDQ6Us7iHs4IrG0CdF2mp3tGRtrIzZu LqVbfY34g0F1qeF7ZeBcheGM8qXeMHo5iZtlRKQQzcefFLbR1ck/u9zhw2j4QUENRF6r pcUOvIQFB3f/m0vHmvVzQp7gXkskMK0841kMsFTa++GyQ88Ctc+7DvrYyvY098KAOwhE cKOQ== X-Gm-Message-State: ACrzQf2kz6uyNv2CIOXk33UR3gPAjkcMQIAIg2/mELU6lkCy/hoLvjZY 7ILm6ym1bwHS/xQyf/gFuB/CebdYiIkPTA== X-Google-Smtp-Source: AMsMyM6auO7zd9V9y6sVWvoa5lOsJCgLzgjIBXw3FHxLXWyMNv86MEkFtRVwKPJbJmzPknh6BFI9cQ== X-Received: by 2002:a05:6512:511:b0:4a1:d9f3:ea10 with SMTP id o17-20020a056512051100b004a1d9f3ea10mr863530lfb.555.1664437025680; Thu, 29 Sep 2022 00:37:05 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id 10-20020ac25f0a000000b004979e1ff641sm704286lfq.115.2022.09.29.00.37.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 00:37:05 -0700 (PDT) Message-ID: <65ef5f40-f8bd-045c-a9d7-6a74ceacc8e2@linaro.org> Date: Thu, 29 Sep 2022 09:37:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] dt-bindings: media: st,stmipid02: Convert the text bindings to YAML Content-Language: en-US To: Marek Vasut , linux-arm-kernel@lists.infradead.org Cc: Alexandre Torgue , Benjamin Mugnier , Mauro Carvalho Chehab , Maxime Coquelin , Rob Herring , Sylvain Petinot , devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20220927184657.291714-1-marex@denx.de> From: Krzysztof Kozlowski In-Reply-To: <20220927184657.291714-1-marex@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_003709_571447_EBD2321B X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/09/2022 20:46, Marek Vasut wrote: > Convert the text STMIPID02 DT bindings to YAML DT format to permit > validation of DTs using this I2C CSI-2 to CPI bridge. > > Signed-off-by: Marek Vasut > --- Thank you for your patch. There is something to discuss/improve. > +properties: > + compatible: > + const: st,st-mipid02 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + Reference to the xclk input clock. This usually goes to "clocks", but on the other hand it does not bring any value (xclk is obvious from clock-names), so I propose to skip entire description. > + items: > + - const: xclk > + > + VDDE-supply: > + description: > + Sensor digital IO supply. Must be 1.8 volts. > + > + VDDIN-supply: > + description: > + Sensor internal regulator supply. Must be 1.8 volts. > + > + reset-gpios: > + description: > + Reference to the GPIO connected to the xsdn pin, if any. > + This is an active low signal to the mipid02. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI-2 first input port > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: > + Single-lane operation shall be <1> or <2> . > + Dual-lane operation shall be <1 2> or <2 1> . > + minItems: 1 > + maxItems: 2 Blank line > + lane-polarity: The property is "lane-polarities" > + description: > + Any lane can be inverted or not. > + minItems: 1 > + maxItems: 2 > + > + required: > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: CSI-2 second input port > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: > + Single-lane operation shall be <1> or <2> . > + maxItems: 1 Blank line > + lane-polarity: lane-polarities > + description: > + Any lane can be inverted or not. > + maxItems: 1 > + > + required: > + - data-lanes > + > + port@2: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: Output port > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-width: > + enum: [6, 7, 8, 10, 12] Blank line > + hsync-active: true > + vsync-active: true You do not need these two - they come from video-interfaces.yaml > + > + required: > + - bus-width > + > + anyOf: > + - required: > + - port@0 > + - required: > + - port@1 > + > + required: > + - port@2 > + Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel