From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 820ADC3A5A0 for ; Mon, 20 Apr 2020 16:28:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD189206B8 for ; Mon, 20 Apr 2020 16:28:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EnkjbVWF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="O6RsVzYp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD189206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=db2F1DFIB8dgtAj8JiYD4EnFEzvLVbC8glXLVYlIbQg=; b=EnkjbVWFWXWRg5Wu3ZxPCIlfo 6UyX2km5E6QHircX2nnlRRMLFcZdzRpBsfPMMvxpRXtKrOo5W7prQTxWNsv6g/dq1Gkq7hwgCHw4G DVnFxaWpBhHam4UcXFUbIumTGOa9uE+Wi8j+8Ez+dGS5Fm4sgQJxUt9FO6KQmpbpiQPUndZbHxnao /w4FMm1vSOo6z7JGodaNb1+xwo7lm3hWgOeIHWdU8AhXHHhCKuZZLwf5Oa8pqGaA5UvyPsdefh53Q ZiyLBCNS/a/0+5p1d0Kas5EREQsYMf0h/HcDtONldPu6w9YMshwTZo5gN+7eOJ/72I3XhYSRhrQP7 gOuB8SVHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQZHq-0000tA-0l; Mon, 20 Apr 2020 16:28:46 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQZHd-0000ga-On for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2020 16:28:38 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587400116; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=QA9CZuPAM8s1GI09MkFEN/LL8wgIB+Q0f+qXwJ/VpWg=; b=O6RsVzYpwLJb5RvzPgFWTepVi3lbYdNgfuuZCb75HdsVy/SUm2rTIDpR1d6UAN48fQ7yzs9T +QpBm37COQOpJmN/kHqHMSKbPeH9azflz/5TmfTHEVGg4iavHhFqjctQ1Hhhw1efHc9dqzwO o1ydJgOquyIeNo96f7kVkKqCwUM= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e9dcdad.7f832c654d18-smtp-out-n01; Mon, 20 Apr 2020 16:28:29 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D9349C433D2; Mon, 20 Apr 2020 16:28:27 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3245DC433D2; Mon, 20 Apr 2020 16:28:26 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 20 Apr 2020 21:58:26 +0530 From: Sai Prakash Ranjan To: Robin Murphy Subject: Re: [PATCHv2 2/6] iommu/arm-smmu: Allow client devices to select direct mapping In-Reply-To: References: <14539e787e6d8b7bd0a6d8f8a001baae6f691988.1587392905.git.saiprakash.ranjan@codeaurora.org> Message-ID: <65f21f15b90f73e16c0bb5bb75e835e6@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200420_092836_571074_587B73A0 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Joerg Roedel , Jordan Crouse , Evan Green , Bjorn Andersson , Rob Clark , iommu@lists.linux-foundation.org, Sibi Sankar , Stephen Boyd , Will Deacon , Matthias Kaehlcke , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-04-20 21:27, Robin Murphy wrote: > On 2020-04-20 3:37 pm, Sai Prakash Ranjan wrote: >> From: Jordan Crouse >> >> Some client devices want to directly map the IOMMU themselves instead >> of using the DMA domain. Allow those devices to opt in to direct >> mapping by way of a list of compatible strings. >> >> Signed-off-by: Jordan Crouse >> Co-developed-by: Sai Prakash Ranjan >> Signed-off-by: Sai Prakash Ranjan >> --- >> drivers/iommu/arm-smmu-qcom.c | 19 +++++++++++++++++++ >> drivers/iommu/arm-smmu.h | 1 + >> 2 files changed, 20 insertions(+) >> >> diff --git a/drivers/iommu/arm-smmu-qcom.c >> b/drivers/iommu/arm-smmu-qcom.c >> index 64a4ab270ab7..0b3f159065aa 100644 >> --- a/drivers/iommu/arm-smmu-qcom.c >> +++ b/drivers/iommu/arm-smmu-qcom.c >> @@ -3,6 +3,7 @@ >> * Copyright (c) 2019, The Linux Foundation. All rights reserved. >> */ >> +#include >> #include >> #include "arm-smmu.h" >> @@ -11,6 +12,23 @@ struct qcom_smmu { >> struct arm_smmu_device smmu; >> }; >> +static const struct of_device_id qcom_smmu_client_of_match[] = { >> + { .compatible = "qcom,adreno" }, >> + { .compatible = "qcom,mdp4" }, >> + { .compatible = "qcom,mdss" }, >> + { .compatible = "qcom,sc7180-mdss" }, >> + { .compatible = "qcom,sdm845-mdss" }, >> + { } >> +}; >> + >> +static int qcom_smmu_request_domain(struct device *dev) >> +{ >> + const struct of_device_id *match = >> + of_match_device(qcom_smmu_client_of_match, dev); >> + >> + return match ? IOMMU_DOMAIN_IDENTITY : 0; >> +} >> + >> static int qcom_sdm845_smmu500_reset(struct arm_smmu_device *smmu) >> { >> int ret; >> @@ -41,6 +59,7 @@ static int qcom_smmu500_reset(struct arm_smmu_device >> *smmu) >> } >> static const struct arm_smmu_impl qcom_smmu_impl = { >> + .req_domain = qcom_smmu_request_domain, >> .reset = qcom_smmu500_reset, >> }; >> diff --git a/drivers/iommu/arm-smmu.h b/drivers/iommu/arm-smmu.h >> index 8d1cd54d82a6..662fdb4dccd2 100644 >> --- a/drivers/iommu/arm-smmu.h >> +++ b/drivers/iommu/arm-smmu.h >> @@ -386,6 +386,7 @@ struct arm_smmu_impl { >> int (*init_context)(struct arm_smmu_domain *smmu_domain); >> void (*tlb_sync)(struct arm_smmu_device *smmu, int page, int sync, >> int status); >> + int (*req_domain)(struct device *dev); > > Nit: since the point is to implement the full > iommu_ops::def_domain_type interface, can we call it def_domain_type > please? > Sure, will send the next version shortly. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel