From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy@kernel.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers
Date: Wed, 04 Oct 2023 10:00:38 +1030 [thread overview]
Message-ID: <6608b6ea673454672fb5930b57e9e7a5570d96d5.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20231003145114.21637-9-brgl@bgdev.pl>
On Tue, 2023-10-03 at 16:50 +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Replace the pinctrl helpers taking the global GPIO number as argument
> with the improved variants that instead take a pointer to the GPIO chip
> and the controller-relative offset.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/gpio/gpio-aspeed.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> index da33bbbdacb9..d3aa1cfd4ace 100644
> --- a/drivers/gpio/gpio-aspeed.c
> +++ b/drivers/gpio/gpio-aspeed.c
> @@ -750,12 +750,12 @@ static int aspeed_gpio_request(struct gpio_chip *chip, unsigned int offset)
> if (!have_gpio(gpiochip_get_data(chip), offset))
> return -ENODEV;
>
> - return pinctrl_gpio_request(chip->base + offset);
> + return pinctrl_gpio_request_new(chip, offset);
> }
>
> static void aspeed_gpio_free(struct gpio_chip *chip, unsigned int offset)
> {
> - pinctrl_gpio_free(chip->base + offset);
> + pinctrl_gpio_free_new(chip, offset);
> }
>
> static int usecs_to_cycles(struct aspeed_gpio *gpio, unsigned long usecs,
> @@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset,
> else if (param == PIN_CONFIG_BIAS_DISABLE ||
> param == PIN_CONFIG_BIAS_PULL_DOWN ||
> param == PIN_CONFIG_DRIVE_STRENGTH)
> - return pinctrl_gpio_set_config(offset, config);
> + return pinctrl_gpio_set_config_new(chip, offset, config);
Ah, this looks like it removes a bug too. Nice.
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN ||
> param == PIN_CONFIG_DRIVE_OPEN_SOURCE)
> /* Return -ENOTSUPP to trigger emulation, as per datasheet */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-03 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231003145114.21637-1-brgl@bgdev.pl>
2023-10-03 14:50 ` [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers Bartosz Golaszewski
2023-10-03 23:30 ` Andrew Jeffery [this message]
2023-10-04 7:13 ` Bartosz Golaszewski
2023-10-09 9:45 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6608b6ea673454672fb5930b57e9e7a5570d96d5.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).