From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B133E8FDBF for ; Tue, 3 Oct 2023 23:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yxDlFwFpGL3vg9gNE4fHnnatDc59RgUTjzGXnBy1WUs=; b=q0CZsW6lWii84H aCG3J42iszEL/I9LL3xLB0At4ikH1VM3uWDct549+8Tyb9neSwO9n2GW4iEBE5DV3K4NaDP8YCdD8 kClvqFCrlNQLWjulFMao03+paEY1GpDFJnN/1KBVWO0pOu8D/9aghYLlBwmylMj7xsHDxxHJqAk17 O9KcuTroggN2pkjjYZenU3+Jec6JeFt3qn3PhpGHxz1MgGVqU36L+0McivWHtNjPepU4vtjdsgTly zUVQCk3TY5y9n9IGIQECWBknQ7emOkCdcucEBLni9n4VvgsllVGUYzd8g+No9t+nEGkFdIzriIlq/ QqVKGr2NuK08IEDSPxTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnoqw-00FZJI-18; Tue, 03 Oct 2023 23:30:58 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnoqt-00FZI5-22 for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 23:30:57 +0000 Received: from [192.168.68.112] (ppp118-210-175-196.adl-adc-lon-bras34.tpg.internode.on.net [118.210.175.196]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 799B620059; Wed, 4 Oct 2023 07:30:39 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1696375842; bh=0DwoPwHtvsNHshbiX0L5U/GGpl/naUYap0pFgc5OoPg=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=fup1rsQjI6vuo9F7ghDudR0GDrJtiWkokCJjW2gEiNomV9EFA+PifQ1z6X65JDVkd eu3Qv/lLuC/Xq/QAnP32VuWQAfPKFpJzXS1H3PihTjA39WDeswTe+PKzcqmiz2KxQZ dVzI57qBkV+WXOLxQrBqfh2lCBko/TlO9vs3XiGBTOHyVN+JSmU7EGD4s//VaOyqxM TZAkCouYeQyfBDttjPDWLxV/mAlDk6DJTwDKfVpd1jW7I8HzH+qC6odtOmBLtUwjkR Sk68RYBMauvX7fA7NrjYc0l1MWfywAoOQYP1prkTO/rCRRoGP2GBox5XhfvIaCqSen 26vRJ1Qd4NMKQ== Message-ID: <6608b6ea673454672fb5930b57e9e7a5570d96d5.camel@codeconstruct.com.au> Subject: Re: [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers From: Andrew Jeffery To: Bartosz Golaszewski , Linus Walleij , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Joel Stanley , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Date: Wed, 04 Oct 2023 10:00:38 +1030 In-Reply-To: <20231003145114.21637-9-brgl@bgdev.pl> References: <20231003145114.21637-1-brgl@bgdev.pl> <20231003145114.21637-9-brgl@bgdev.pl> User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231003_163055_866787_95B5B02D X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2023-10-03 at 16:50 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Replace the pinctrl helpers taking the global GPIO number as argument > with the improved variants that instead take a pointer to the GPIO chip > and the controller-relative offset. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/gpio/gpio-aspeed.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > index da33bbbdacb9..d3aa1cfd4ace 100644 > --- a/drivers/gpio/gpio-aspeed.c > +++ b/drivers/gpio/gpio-aspeed.c > @@ -750,12 +750,12 @@ static int aspeed_gpio_request(struct gpio_chip *chip, unsigned int offset) > if (!have_gpio(gpiochip_get_data(chip), offset)) > return -ENODEV; > > - return pinctrl_gpio_request(chip->base + offset); > + return pinctrl_gpio_request_new(chip, offset); > } > > static void aspeed_gpio_free(struct gpio_chip *chip, unsigned int offset) > { > - pinctrl_gpio_free(chip->base + offset); > + pinctrl_gpio_free_new(chip, offset); > } > > static int usecs_to_cycles(struct aspeed_gpio *gpio, unsigned long usecs, > @@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset, > else if (param == PIN_CONFIG_BIAS_DISABLE || > param == PIN_CONFIG_BIAS_PULL_DOWN || > param == PIN_CONFIG_DRIVE_STRENGTH) > - return pinctrl_gpio_set_config(offset, config); > + return pinctrl_gpio_set_config_new(chip, offset, config); Ah, this looks like it removes a bug too. Nice. Reviewed-by: Andrew Jeffery > else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN || > param == PIN_CONFIG_DRIVE_OPEN_SOURCE) > /* Return -ENOTSUPP to trigger emulation, as per datasheet */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel