* [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers [not found] <20231003145114.21637-1-brgl@bgdev.pl> @ 2023-10-03 14:50 ` Bartosz Golaszewski 2023-10-03 23:30 ` Andrew Jeffery 2023-10-09 9:45 ` Uwe Kleine-König 0 siblings, 2 replies; 4+ messages in thread From: Bartosz Golaszewski @ 2023-10-03 14:50 UTC (permalink / raw) To: Linus Walleij, Andy Shevchenko Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Replace the pinctrl helpers taking the global GPIO number as argument with the improved variants that instead take a pointer to the GPIO chip and the controller-relative offset. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- drivers/gpio/gpio-aspeed.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index da33bbbdacb9..d3aa1cfd4ace 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -750,12 +750,12 @@ static int aspeed_gpio_request(struct gpio_chip *chip, unsigned int offset) if (!have_gpio(gpiochip_get_data(chip), offset)) return -ENODEV; - return pinctrl_gpio_request(chip->base + offset); + return pinctrl_gpio_request_new(chip, offset); } static void aspeed_gpio_free(struct gpio_chip *chip, unsigned int offset) { - pinctrl_gpio_free(chip->base + offset); + pinctrl_gpio_free_new(chip, offset); } static int usecs_to_cycles(struct aspeed_gpio *gpio, unsigned long usecs, @@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset, else if (param == PIN_CONFIG_BIAS_DISABLE || param == PIN_CONFIG_BIAS_PULL_DOWN || param == PIN_CONFIG_DRIVE_STRENGTH) - return pinctrl_gpio_set_config(offset, config); + return pinctrl_gpio_set_config_new(chip, offset, config); else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN || param == PIN_CONFIG_DRIVE_OPEN_SOURCE) /* Return -ENOTSUPP to trigger emulation, as per datasheet */ -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers 2023-10-03 14:50 ` [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers Bartosz Golaszewski @ 2023-10-03 23:30 ` Andrew Jeffery 2023-10-04 7:13 ` Bartosz Golaszewski 2023-10-09 9:45 ` Uwe Kleine-König 1 sibling, 1 reply; 4+ messages in thread From: Andrew Jeffery @ 2023-10-03 23:30 UTC (permalink / raw) To: Bartosz Golaszewski, Linus Walleij, Andy Shevchenko Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, Joel Stanley, linux-arm-kernel, linux-aspeed On Tue, 2023-10-03 at 16:50 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Replace the pinctrl helpers taking the global GPIO number as argument > with the improved variants that instead take a pointer to the GPIO chip > and the controller-relative offset. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > drivers/gpio/gpio-aspeed.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > index da33bbbdacb9..d3aa1cfd4ace 100644 > --- a/drivers/gpio/gpio-aspeed.c > +++ b/drivers/gpio/gpio-aspeed.c > @@ -750,12 +750,12 @@ static int aspeed_gpio_request(struct gpio_chip *chip, unsigned int offset) > if (!have_gpio(gpiochip_get_data(chip), offset)) > return -ENODEV; > > - return pinctrl_gpio_request(chip->base + offset); > + return pinctrl_gpio_request_new(chip, offset); > } > > static void aspeed_gpio_free(struct gpio_chip *chip, unsigned int offset) > { > - pinctrl_gpio_free(chip->base + offset); > + pinctrl_gpio_free_new(chip, offset); > } > > static int usecs_to_cycles(struct aspeed_gpio *gpio, unsigned long usecs, > @@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset, > else if (param == PIN_CONFIG_BIAS_DISABLE || > param == PIN_CONFIG_BIAS_PULL_DOWN || > param == PIN_CONFIG_DRIVE_STRENGTH) > - return pinctrl_gpio_set_config(offset, config); > + return pinctrl_gpio_set_config_new(chip, offset, config); Ah, this looks like it removes a bug too. Nice. Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au> > else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN || > param == PIN_CONFIG_DRIVE_OPEN_SOURCE) > /* Return -ENOTSUPP to trigger emulation, as per datasheet */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers 2023-10-03 23:30 ` Andrew Jeffery @ 2023-10-04 7:13 ` Bartosz Golaszewski 0 siblings, 0 replies; 4+ messages in thread From: Bartosz Golaszewski @ 2023-10-04 7:13 UTC (permalink / raw) To: Andrew Jeffery Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel, Bartosz Golaszewski, Joel Stanley, linux-arm-kernel, linux-aspeed On Wed, Oct 4, 2023 at 1:30 AM Andrew Jeffery <andrew@codeconstruct.com.au> wrote: > > On Tue, 2023-10-03 at 16:50 +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Replace the pinctrl helpers taking the global GPIO number as argument > > with the improved variants that instead take a pointer to the GPIO chip > > and the controller-relative offset. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > drivers/gpio/gpio-aspeed.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > > index da33bbbdacb9..d3aa1cfd4ace 100644 > > --- a/drivers/gpio/gpio-aspeed.c > > +++ b/drivers/gpio/gpio-aspeed.c > > @@ -750,12 +750,12 @@ static int aspeed_gpio_request(struct gpio_chip *chip, unsigned int offset) > > if (!have_gpio(gpiochip_get_data(chip), offset)) > > return -ENODEV; > > > > - return pinctrl_gpio_request(chip->base + offset); > > + return pinctrl_gpio_request_new(chip, offset); > > } > > > > static void aspeed_gpio_free(struct gpio_chip *chip, unsigned int offset) > > { > > - pinctrl_gpio_free(chip->base + offset); > > + pinctrl_gpio_free_new(chip, offset); > > } > > > > static int usecs_to_cycles(struct aspeed_gpio *gpio, unsigned long usecs, > > @@ -973,7 +973,7 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset, > > else if (param == PIN_CONFIG_BIAS_DISABLE || > > param == PIN_CONFIG_BIAS_PULL_DOWN || > > param == PIN_CONFIG_DRIVE_STRENGTH) > > - return pinctrl_gpio_set_config(offset, config); > > + return pinctrl_gpio_set_config_new(chip, offset, config); > > Ah, this looks like it removes a bug too. Nice. > > Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au> > > > else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN || > > param == PIN_CONFIG_DRIVE_OPEN_SOURCE) > > /* Return -ENOTSUPP to trigger emulation, as per datasheet */ > I sent a separate patch that fixes this issue for backporting, once the other one is in next, we can update this series. Bart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers 2023-10-03 14:50 ` [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers Bartosz Golaszewski 2023-10-03 23:30 ` Andrew Jeffery @ 2023-10-09 9:45 ` Uwe Kleine-König 1 sibling, 0 replies; 4+ messages in thread From: Uwe Kleine-König @ 2023-10-09 9:45 UTC (permalink / raw) To: Bartosz Golaszewski Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel, Bartosz Golaszewski, Joel Stanley, Andrew Jeffery, linux-arm-kernel, linux-aspeed [-- Attachment #1.1: Type: text/plain, Size: 644 bytes --] On Tue, Oct 03, 2023 at 04:50:46PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Replace the pinctrl helpers taking the global GPIO number as argument > with the improved variants that instead take a pointer to the GPIO chip > and the controller-relative offset. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> LGTM, Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-09 9:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20231003145114.21637-1-brgl@bgdev.pl>
2023-10-03 14:50 ` [PATCH 08/36] gpio: aspeed: use new pinctrl GPIO helpers Bartosz Golaszewski
2023-10-03 23:30 ` Andrew Jeffery
2023-10-04 7:13 ` Bartosz Golaszewski
2023-10-09 9:45 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).