From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE14FE77197 for ; Tue, 7 Jan 2025 13:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GElU6cjJhq95GdewWgaZ+SpQ3fWSL5+ChShOnRqXHIM=; b=JOEYOVqyyEZjdnjXEnJdwKZS5R KSRzRrtIg4L+uIjHXxoLkGpWKEpvNDhjVeBI18Uz+eAi1UrxkNHBeNUps9cEHeUhStE/90DnmHSxr qYtY+M/cVGLTZnHkrGjazGdFWFJ5jSnfuqFMpJT0wfYdnGzwM1ouWV6/2LhhfEqTOrZv2BygpCyCt ur7fXeazSpo24LGJTeRWB3cL628Nwgg2MKXhdz1TfUu3ow/AbOZa/ltDg3NSb4uIm9gAnQdhtWnI6 liE2IHL2IttBnmw6w0n5VrhtIT6lA3BjaRCTW12M4XWP/CA4Jv0aEX8WIte8Uu5+qHs0IHeYrspRU H1el0QjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tV9K9-00000004w5E-2DCH; Tue, 07 Jan 2025 13:08:45 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tV9G5-00000004ttN-3ebt; Tue, 07 Jan 2025 13:04:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736255072; bh=hrjBwILl03AMkuILxv5+UdH95HodZymkjLogKmN18wU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EBq9vu3U2s/KXM8+fmdhQS19ZZHkZCHSg9o8Y0Vn+zh4LodJlHCBBH18k28zi+oxO v8+xrNdrb+I8J/XG6IUxDDU7hBE6HKuGwUzHEjeATlcIwa+ijCgqZtiHZ9j82P2lv9 ecioGCWeNvi5BdjaXIP2nyS/GBMa5tD4BE2kYuV5bOYlAoHgiS+j4LFEBJBT1Q9dCr S5U0qu+H7k3j/9l6jjC4a48LbfoNS2oXTUNUZE06JDAvPJ6JMpyzEZtAprFN6oD47X KU1oh/XbQU1CcjSPfcihPTJagNa4D9jk+rIzJATH0N9JVtmzgg7674/8kK7LYnuhx7 QH3Epgb8e39gg== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 5F26B17E154C; Tue, 7 Jan 2025 14:04:31 +0100 (CET) Message-ID: <660e3bbb-4b16-49ad-82d1-a2c3e3ef76bb@collabora.com> Date: Tue, 7 Jan 2025 14:04:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] dt-bindings: PCI: mediatek-gen3: Add MT8196 support To: =?UTF-8?B?Smlhbmp1biBXYW5nICjnjovlu7rlhpsp?= , "manivannan.sadhasivam@linaro.org" , "conor+dt@kernel.org" , "robh@kernel.org" , "kw@linux.com" , "bhelgaas@google.com" , "matthias.bgg@gmail.com" , "krzk+dt@kernel.org" , "lpieralisi@kernel.org" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , Ryder Lee , "devicetree@vger.kernel.org" , =?UTF-8?B?WGF2aWVyIENoYW5nICjlvLXnjbvmlocp?= References: <20250103060035.30688-1-jianjun.wang@mediatek.com> <20250103060035.30688-2-jianjun.wang@mediatek.com> <0555fb64-312d-4490-9b03-89fca580c602@collabora.com> <8269f5fb280d0847ceba288a83a64c99bbf92cb7.camel@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <8269f5fb280d0847ceba288a83a64c99bbf92cb7.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250107_050434_055872_A1C3ED2E X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 06/01/25 10:19, Jianjun Wang (王建军) ha scritto: > On Fri, 2025-01-03 at 10:26 +0100, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> Il 03/01/25 07:00, Jianjun Wang ha scritto: >>> Add compatible string and clock definition for MT8196. It has 6 >>> clocks like >>> the MT8195, but 2 of them are different. >>> >>> Signed-off-by: Jianjun Wang >>> --- >>> .../bindings/pci/mediatek-pcie-gen3.yaml | 29 >>> +++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie- >>> gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- >>> gen3.yaml >>> index f05aab2b1add..b4158a666fb6 100644 >>> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml >>> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml >>> @@ -51,6 +51,7 @@ properties: >>> - mediatek,mt7986-pcie >>> - mediatek,mt8188-pcie >>> - mediatek,mt8195-pcie >>> + - mediatek,mt8196-pcie >>> - const: mediatek,mt8192-pcie >>> - const: mediatek,mt8192-pcie >>> - const: airoha,en7581-pcie >>> @@ -197,6 +198,34 @@ allOf: >>> minItems: 1 >>> maxItems: 2 >>> >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - mediatek,mt8196-pcie >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 6 >>> + >>> + clock-names: >>> + items: >>> + - const: pl_250m >>> + - const: tl_26m >>> + - const: peri_26m >>> + - const: peri_mem >>> + - const: ahb_apb >> >> ahb_apb is a bus clock, so you can set it as >> >> - const: bus > > Agree, I'll change it to "bus" in the next version, thanks. > >> >> >>> + - const: low_power >> >> Can you please clarify what the LP clock is for? > > This is a power-saving clock. Its clock source consumes less power than > a regular clock, we need to keep this clock on if when entering L1.2 > during suspend. > In the driver, you are keeping all clocks ON instead. Is this clock required to be ON when the full power ones are enabled and the SoC is not in suspend state? Can you please add handling for this "special" clock so that we can save power during suspend? Cheers, Angelo > Thanks. > >> >> Thanks, >> Angelo >> >>> + >>> + resets: >>> + minItems: 1 >>> + maxItems: 2 >>> + >>> + reset-names: >>> + minItems: 1 >>> + maxItems: 2 >>> + >>> - if: >>> properties: >>> compatible: >> >>