From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0422AC4345F for ; Fri, 26 Apr 2024 09:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7hZWygF5RllTTS/Jo2Ej9+7YSqsd3NSZTvzijwGV8us=; b=M3j99iXUW8HV4l 8lc7mwPbDeQeV8nMzHXUvGGjnD+HxjBm0woLWR9Ey8X5g9BskOkAbFexFbgByAheopwkBkZucDRij rR7+WoYXgo3zA+KSfOVtpvxkNew6zbt19YzIhMwDjlPQLdPHRKnkIoP9J2DESNnl71U4X2kTdy6D4 +lADql1IW/1UGD6ZJ0xBzsSTc01vCX1kQLWHy+cPAoqabXn2OlMasod5ltbT1RKqdgc6bXDaFUH4X aV3Cm/t9hn6SUOARjhgqdur6HDK8OZuLYQNQy7aKBnEXe5AIbOE8wn930lznBgAxu9dhY/0wVQFhy OXdzgSMrGqi8vV+9+oQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0Hqd-0000000BuOM-1c6G; Fri, 26 Apr 2024 09:26:27 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0HqZ-0000000BuMV-31kY for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 09:26:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 92E34CE1BFF; Fri, 26 Apr 2024 09:26:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06114C113CD; Fri, 26 Apr 2024 09:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714123580; bh=66P7ey8YBHqn+j6ITUbLuM7XN8SoUg14umgmGAm1O8k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OSTnxrBwgHRZ4CaDE8Aascm0bJMZ4I91EpEazyO3InSyYA0pWKIUnuXiWhDrdcAWh m7MmQ4VxcG6JNRmWe08ef0Hu7Qt2lpWwOKslEdWwZxER2aOHbu5THcNNomMmN9qfDD yaa9Glto0MfCA9jgLYOGiPwSANdjGhGYLvIU6ncg+45cTyu8r5/aHU2Im847oAJaOf GMWWFIMwXrWGBtPiwfGPzOKmDemeZcdxIQ7NSb6js9DfuHzZocD0oPkenkb5TN0lj6 r792y8V+ChnU+4xFN61aodobTMLDzo7UMC8SggwK0Hw+f3MogKpCh6Nb4rJOpvhdNe NtJrQD8bCdhAA== Message-ID: <6615daa1-6bb5-4da0-84b4-e84e7e0699c1@kernel.org> Date: Fri, 26 Apr 2024 11:26:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: samsung: exynos-clkout: Remove misleading of_match_table/MODULE_DEVICE_TABLE To: Marek Szyprowski , William McVicker Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Rob Herring , David Lechner , Bjorn Andersson , Dmitry Baryshkov References: <20240425091429.948467-1-m.szyprowski@samsung.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240426_022624_162544_1E414D3D X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/04/2024 11:21, Marek Szyprowski wrote: > On 26.04.2024 11:02, Krzysztof Kozlowski wrote: >> On 26/04/2024 07:24, Marek Szyprowski wrote: >>> On 26.04.2024 02:24, William McVicker wrote: >>>> On 04/25/2024, Marek Szyprowski wrote: >>>>> Since commit 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to >>>>> module driver") this driver is instantiated as MFD-cell (matched by >>>>> platform device name) not as a real platform device created by OF code. >>>>> Remove then of_match_table and related MODULE_DEVICE_TABLE to avoid >>>>> further confusion. >>>>> >>>>> Signed-off-by: Marek Szyprowski >>>>> --- >>>>> drivers/clk/samsung/clk-exynos-clkout.c | 2 -- >>>>> 1 file changed, 2 deletions(-) >>>>> >>>>> diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c >>>>> index 503c6f5b20d5..0c7f4e2aa366 100644 >>>>> --- a/drivers/clk/samsung/clk-exynos-clkout.c >>>>> +++ b/drivers/clk/samsung/clk-exynos-clkout.c >>>>> @@ -75,7 +75,6 @@ static const struct of_device_id exynos_clkout_ids[] = { >>>>> .data = &exynos_clkout_exynos5, >>>>> }, { } >>>>> }; >>>>> -MODULE_DEVICE_TABLE(of, exynos_clkout_ids); >>>> I understand these are duplicates of the exynos-pmu driver, but was wondering >>>> if this will impact the exynos-clkout module from getting auto-loaded? Without >>>> the MODULE_DEVICE_TABLE() defined, the aliases won't be created that trigger >>>> udev to load this module and the mfd driver is obviously not going to load it. >>> This driver loaded and matched only against the platform device name >> Matched yes, but "loaded"? As in module loaded? Are you sure? There is >> no MODULE_ALIAS, no platform_id_table with MODULE_DEVICE_TABLE, so with >> this patch all aliases are gone. >> >> The old aliases indeed could have been used to load the clkout, even if >> not used for matching. > > Right, the proper solution is to add: > > MODULE_ALIAS("platform:exynos-clkout"); > > I was convinced that the module_platform_driver() macro adds simple > module alias based on the driver name, but it looks that's not true. > Thanks for pointing this out. I will send v2 with the above alias then. So just add simple platform ID table and MODULE_DEVICE_TABLE. It still allows growing and in general is preferred than spreading aliases manually. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel