From: Zenghui Yu <yuzenghui@huawei.com>
To: huangguanrui.hgr <huangguanrui.hgr@alibaba-inc.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <maz@kernel.org>,
<shannon.zhao@linux.alibaba.com>, <tglx@linutronix.de>
Subject: Re: [PATCH] irqchip/gic-v3-its: Fix double free on error
Date: Tue, 26 Mar 2024 17:43:39 +0800 [thread overview]
Message-ID: <661a577c-b4bb-e438-6ba5-6ed90b08649f@huawei.com> (raw)
In-Reply-To: <20240322023810.62914-1-huangguanrui.hgr@alibaba-inc.com>
On 2024/3/22 10:38, huangguanrui.hgr wrote:
> We notice that:
> In its_vpe_irq_domain_alloc, its_vm is from args, But in its_vpe_irq_domain_free,
> its_vm is from domain->host_data.
They *should* point to the same its_vm structure.
> Will these two values be different? For example, when other bugs occur?
Of course they can be different if there are *bugs* but I guess you
won't get any further (e.g., you hit BUG_ON(vm != vpe->its_vm) in
its_vpe_irq_domain_free()). The right thing to do is fixing the bug
rather than papering over it.
Zenghui
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-03-26 9:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 11:04 [PATCH] irqchip/gic-v3-its: Fix double free on error Guanrui Huang
2024-03-21 12:43 ` Zenghui Yu
2024-03-22 2:38 ` huangguanrui.hgr
2024-03-26 9:43 ` Zenghui Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661a577c-b4bb-e438-6ba5-6ed90b08649f@huawei.com \
--to=yuzenghui@huawei.com \
--cc=huangguanrui.hgr@alibaba-inc.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shannon.zhao@linux.alibaba.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox