From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms
Date: Mon, 26 May 2014 15:39:15 +0200 [thread overview]
Message-ID: <6624276.NBS809VbNB@wuerfel> (raw)
In-Reply-To: <5013253.K6sZTxep7b@wuerfel>
On Friday 23 May 2014 17:35:34 Arnd Bergmann wrote:
> On Friday 23 May 2014 16:10:17 Daniel Thompson wrote:
> > Only a small handful of platforms support DEBUG_LL_UART_NONE but it
> > lurks in the menus of every single platform config ready to break the
> > build. This is an especial problem for defconfigs since it is often
> > selected by default.
> >
> > This patch limit this choice only to platforms capable of supporting it.
> >
> > Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> > ---
> > arch/arm/Kconfig.debug | 13 ++++++++++++-
> > 1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index eab8ecb..4c8d7db 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -842,7 +842,18 @@ choice
> >
> > config DEBUG_LL_UART_NONE
> > bool "No low-level debugging UART"
> > - depends on !ARCH_MULTIPLATFORM
> > + depends on ARCH_AT91 || \
> > + ARCH_CLPS711X || \
> > + ARCH_FOOTBRIDGE || \
> > + ARCH_KS8695 || \
> > + ARCH_NETX || \
> > + ARCH_OMAP1 || \
> > + ARCH_SA1100 || \
> > + ARCH_S3C24XX || \
> > + ARCH_S3C64XX || \
> > + ARCH_S5P64X0 || \
> > + ARCH_S5PC100 || \
> > + ARCH_S5PV210
> > help
> > Say Y here if your platform doesn't provide a UART option
> > above. This relies on your platform choosing the right UART
>
> ARCH_S3C24XX has been moved over in linux-next to use debug/s3c24xx.S.
> A few others will likely move soon (AT91, CLPS711x, S5PV210), as the
> platforms get moved to ARCH_MULTIPLATFORM.
>
> As an alternative to your patch, we could decide to move the remaining
> files as well.
Follow-up: I also noticed that AT91, CLPS711X, FOOTBRIDGE and all the SAMSUNG
platforms already have an entry in the list, so DEBUG_LL_UART_NONE is redundant
for them. The below change should be enough.
For AT91 this is actually better because the old AT91X40 support doesn't
have working DEBUG_LL support. This gets handled correctly by
AT91_DEBUG_LL_DBGU0/AT91_DEBUG_LL_DBGU1, but not DEBUG_LL_UART_NONE.
Arnd
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index fd127d6..cae828a 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -864,7 +864,8 @@ choice
config DEBUG_LL_UART_NONE
bool "No low-level debugging UART"
- depends on !ARCH_MULTIPLATFORM
+ depends on ARCH_KS8695 || ARCH_NETX || ARCH_OMAP1 || ARCH_SA1100
help
Say Y here if your platform doesn't provide a UART option
above. This relies on your platform choosing the right UART
next prev parent reply other threads:[~2014-05-26 13:39 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 11:17 [PATCH] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-04-04 11:39 ` Arnd Bergmann
2014-04-04 14:02 ` Daniel Thompson
2014-04-04 14:14 ` Paul Bolle
2014-04-04 14:52 ` Paul Bolle
2014-04-04 14:41 ` Russell King - ARM Linux
2014-04-04 15:18 ` Daniel Thompson
2014-04-04 14:47 ` [PATCH v2] " Daniel Thompson
2014-04-04 15:41 ` [PATCH v3] " Daniel Thompson
2014-04-07 12:48 ` Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 0/5] " Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 2/5] ARM: ep93xx: " Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-04-07 15:54 ` [PATCH v4 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 0/5] " Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 2/5] ARM: ep93xx: " Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-04-24 16:00 ` [RESEND PATCH v5 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 0/5] " Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 2/5] ARM: ep93xx: " Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-05-23 15:35 ` Arnd Bergmann
2014-05-26 13:39 ` Arnd Bergmann [this message]
2014-05-27 13:13 ` Daniel Thompson
2014-05-27 13:37 ` Arnd Bergmann
2014-05-27 13:52 ` Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-05-23 15:10 ` [RESEND PATCH v5 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 0/5] " Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 2/5] ARM: ep93xx: " Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 3/5] ARM: Hide DEBUG_LL_UART_NONE from unsupported platforms Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-05-27 16:00 ` [PATCH v6 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 0/4] " Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 1/4] ARM: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 2/4] ARM: ep93xx: " Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 3/4] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-06-30 11:30 ` [PATCH v7 4/4] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-06-30 13:20 ` [PATCH v7 0/4] " Arnd Bergmann
2014-07-12 10:16 ` Russell King - ARM Linux
2014-07-12 11:10 ` Russell King - ARM Linux
2014-07-14 9:05 ` Daniel Thompson
2014-07-14 10:39 ` Daniel Thompson
2014-07-14 15:27 ` Arnd Bergmann
2014-07-15 10:32 ` Arnd Bergmann
2014-07-15 10:54 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 0/9] " Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 1/9] arm: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 2/9] arm: ep93xx: " Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 3/9] arm: Remove DEBUG_LL_UART_NONE Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 4/9] arm: ks8695: Migrate debug_ll macros to shared directory Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 6/9] arm: netx: Migrate DEBUG_LL macros to shared directory Daniel Thompson
2014-09-15 16:34 ` Paul Bolle
2014-09-15 21:47 ` Daniel Thompson
2014-09-16 22:37 ` Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 7/9] arm: sa1100: " Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 8/9] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-08-19 14:48 ` [PATCH v8 9/9] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 0/9] " Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 1/9] arm: versatile: Enable DEBUG_LL_UART_PL01X Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 2/9] arm: ep93xx: " Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 3/9] arm: Remove DEBUG_LL_UART_NONE Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 4/9] arm: ks8695: Migrate debug_ll macros to shared directory Daniel Thompson
2014-08-21 11:46 ` Greg Ungerer
2014-09-01 9:04 ` Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 5/9] arm: omap1: Migrate debug_ll macros to use 8250.S Daniel Thompson
2014-09-08 23:04 ` Tony Lindgren
2014-08-19 15:16 ` [PATCH v9 6/9] arm: netx: Migrate DEBUG_LL macros to shared directory Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 7/9] arm: sa1100: " Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 8/9] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX Daniel Thompson
2014-08-19 15:16 ` [PATCH v9 9/9] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6624276.NBS809VbNB@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox