From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC087C2BD09 for ; Tue, 9 Jul 2024 18:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4XakQBCUThKIgAd6g7XJcPEgP4QfvHTsozqgmWIzOG0=; b=MIjwfXHZ+YEHVghPrZsZJP9iU6 Tve7q+tvHAQRIqSQdQ5g3Es1WX+CarUFwTjD1POa34s+/MoSMIsW8JY7YwcB55UUMKvkui2QciqIm GAN44HSYyerkAvmVczTbeYrCcoTebFekFU0T+Wzh+U4XKXtQFIbuKDyH+VM2oi1X8K+NxQNJNL3qu Ww4vzKUoLe7pT5YdNfgyIl1De0wyvYEjlzsH8gs9MpJIkL4wNvnwlHCneo/yKAQK2PSwhudbxbqoM mobO/nNpqHCgy4wfc936ec8UAH0Wk65tzjFmO4Y+HdlvYL4guC6+nSx3lb9yYVRC8YL01V6rMXhdG XtRHgOdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRFs3-00000008KN1-143I; Tue, 09 Jul 2024 18:47:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRFrn-00000008KLd-0t4i; Tue, 09 Jul 2024 18:47:08 +0000 Received: from i5e860d18.versanet.de ([94.134.13.24] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sRFrS-0003Ie-CH; Tue, 09 Jul 2024 20:46:46 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-arm-kernel@lists.infradead.org, Alexander Shiyan Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, Alexander Shiyan Subject: Re: [PATCH] clk: rockchip: clk-rk3588: Fix 32k clock name for pmu_24m_32k_100m_src_p Date: Tue, 09 Jul 2024 20:46:45 +0200 Message-ID: <6645351.tM3a2QDmDi@diego> In-Reply-To: <20240709175715.1317538-1-eagle.alexander923@gmail.com> References: <20240709175715.1317538-1-eagle.alexander923@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_114707_279748_D11239CE X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Dienstag, 9. Juli 2024, 19:57:15 CEST schrieb Alexander Shiyan: It is customary and expected that you provide a commit description. While it is somewhat obvious here that the expected name does not match the expectations, this should still be noted here. Heiko > Signed-off-by: Alexander Shiyan > --- > drivers/clk/rockchip/clk-rk3588.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk-rk3588.c b/drivers/clk/rockchip/clk-rk3588.c > index b30279a96dc8..3027379f2fdd 100644 > --- a/drivers/clk/rockchip/clk-rk3588.c > +++ b/drivers/clk/rockchip/clk-rk3588.c > @@ -526,7 +526,7 @@ PNAME(pmu_200m_100m_p) = { "clk_pmu1_200m_src", "clk_pmu1_100m_src" }; > PNAME(pmu_300m_24m_p) = { "clk_300m_src", "xin24m" }; > PNAME(pmu_400m_24m_p) = { "clk_400m_src", "xin24m" }; > PNAME(pmu_100m_50m_24m_src_p) = { "clk_pmu1_100m_src", "clk_pmu1_50m_src", "xin24m" }; > -PNAME(pmu_24m_32k_100m_src_p) = { "xin24m", "32k", "clk_pmu1_100m_src" }; > +PNAME(pmu_24m_32k_100m_src_p) = { "xin24m", "xin32k", "clk_pmu1_100m_src" }; > PNAME(hclk_pmu1_root_p) = { "clk_pmu1_200m_src", "clk_pmu1_100m_src", "clk_pmu1_50m_src", "xin24m" }; > PNAME(hclk_pmu_cm0_root_p) = { "clk_pmu1_400m_src", "clk_pmu1_200m_src", "clk_pmu1_100m_src", "xin24m" }; > PNAME(mclk_pdm0_p) = { "clk_pmu1_300m_src", "clk_pmu1_200m_src" }; >