From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB3EBC433F5 for ; Tue, 8 Feb 2022 11:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+gpzEs0XPxjcq/n1rea7bGdbvYxth02Fu7OxFqMz3PY=; b=wjdbQhoZ2IfSlyPhdi7hp2PyoM OvoeRkE4I39vmg1z2o/mwJ0ACi+eVKn0FMm3/xKzSNr1vN7IHSkF22mc+lxyDyJTna8WPJqwVGPBp 8V4xPKmkEAwqzA1OwT1dNplzCyNnfG5B49EbM58IfLxa2zW9IRqyBa+1HOsWtlPLpCOJEycZoshuG TFQIS13//OrU8BvwNxNf2pBMZyumpee4dDZMsvOd5dM5qquVAeXpqKOQPR3hI6wKrPO2suH0mETgi Ar1e7ZEGtZx+Nsf/XgYyw2wndNUTnwhjd4oTa3vfOWFz1fYxYE17cJrZ/LF0uM27B7Z1YJJmuRxP2 G1WahUCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHOPZ-00DWqp-5m; Tue, 08 Feb 2022 11:11:53 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHOPV-00DWp1-QC for linux-arm-kernel@lists.infradead.org; Tue, 08 Feb 2022 11:11:51 +0000 Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 08 Feb 2022 20:11:46 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id B20DD2006F53; Tue, 8 Feb 2022 20:11:46 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Tue, 8 Feb 2022 20:11:46 +0900 Received: from [10.212.182.146] (unknown [10.212.182.146]) by kinkan2.css.socionext.com (Postfix) with ESMTP id A4949C1E22; Tue, 8 Feb 2022 20:11:45 +0900 (JST) Subject: Re: [PATCH 2/3] PCI: uniphier-ep: Add support for non-legacy SoC To: Bjorn Helgaas Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Masami Hiramatsu , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220204160616.GA183849@bhelgaas> From: Kunihiko Hayashi Message-ID: <664a23d0-7646-3c50-fe4d-d29b6ce99a35@socionext.com> Date: Tue, 8 Feb 2022 20:11:45 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20220204160616.GA183849@bhelgaas> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_031150_030702_021135CE X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bjorn, Thank you for your comment. On 2022/02/05 1:06, Bjorn Helgaas wrote: > On Thu, Feb 03, 2022 at 11:36:25AM +0900, Kunihiko Hayashi wrote: >> Define SoC data that includes pci_epc_features and boolean 'is_legacy' >> to distinguish between legacy SoC (ex. Pro5) and non-legacy SoC. > > I'm not a big fan of "legacy" as a description because it conveys very > little information. You're adding support for a "non-legacy" SoC, so > now there are "legacy" ones and "non-legacy" ones. Next year there > will be another new SoC, and then there will be *two* kinds of > "legacy" ones that must be distinguished plus the next "non-legacy" > one. Make sense. There will be multiple different "legacy", so it isn't desirable to distinguish SoCs by legacy and non-legacy. > You mentioned "Pro5" as an example of "legacy," which is a good start. > Are there any others? If Pro5 is the only one, you could just use > "pro5" where you now use "legacy." I see. In consideration of the future, I'll define callback functions and prepare functions for each SoC. And the "gio" clocks/resets are distinguished by the flag "has_gio". Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel