From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50DDBC369B1 for ; Wed, 25 Sep 2024 09:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/5harUdMUkYHv3S3CeApCGPIZ01UQZtvlqOHYBc4mQY=; b=dfBa4PXdLqqk74JrQLyU/wBD4D HvfudOHFIPjCYWg66wuTLvKfXNp+F6VaSZzyNjLJ4tiG/kEBzO9+KiGioXOLaOzoahi9vcaq/9hNh Q3SIAaygoFhE6W9e8C9Kvu6k2tz94ySSIBB/iY8MbLAaKRnDvghh8f5Fs8pmMyKVGlxjrjJoLQshs 4ONLTQYZzZlNfLbqKM0IDsq7Cg4H8McQtUHa8/q4EdTd3QQ+/ftnhCuct7gNh0ntiAQg8eu3tc1o8 Ekvj3qHiBq4jmkMJilQj5mPAs9BEPYtdpdugrlBR9SA5xvQjOYyc8XJpp4Rmt4LYaq229F8XSlrN9 S3l6RdUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stOGm-00000004boN-24FR; Wed, 25 Sep 2024 09:25:12 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stOFc-00000004bb9-0f9V for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 09:24:01 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-42cd74c0d16so62063395e9.1 for ; Wed, 25 Sep 2024 02:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727256238; x=1727861038; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/5harUdMUkYHv3S3CeApCGPIZ01UQZtvlqOHYBc4mQY=; b=ntX0NSUN8lfcR/uiZkkMo2xA4ISopJ7no9iFCW9QnFH4A/8teBBbk85pG+MGqCExFV Nt/RoE+4z9aUEueobD6m38Hq4RcwsqB2yApnkSB6Jj288Nh+cs87t8JjyPlhr0hs/Nql KFBJ1V4DTIav4cShMOteq+bLOpgW+UW8D8jKHa6r3ZYXo6SOQgOSvCdGEjFGo1DYJhsk 0+sNQx58ZBOucg0aAvbg3jgBcbDPbCCatv8IJ6oPeywjs9pra5cBsp/CbxdjgCCu9sec CVnY7NL8pOszShzoKVFC+V1IXRJS1E2JLH9blMa9bp7eWvH7JEwaPJN5/uL8SAHLiD4t Ffbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727256238; x=1727861038; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/5harUdMUkYHv3S3CeApCGPIZ01UQZtvlqOHYBc4mQY=; b=HwSuts0D24dn9Tuz7LY8mwLZYE5QPwz+oMyaJ2nva9+vySFzppScsj2gW4+PmObKsG Ilv8nIzuRIRkYghTmO1iUvwXUuFhnglFzo6kSxsy2ALStonttMGTYUuHRJfabUi7vk2f pQpgW1kS5A7oC69t74G8+Neo41RC4Te9h18jayMNpQH/N+G+20t4OuYqsp8RvrAPO9G1 fXFmecjlS234GakouljtUeSwYDY+C74LZF023PqHsTHBwfP2F4DWqhh0drWzlOWs28NY Q8Y0thtA6hSedrECoOSceVHdUTRr9ZVcvFHhcR+j/ipbhUGjIhRSOJHl5VCoaIjFdYBl lZQA== X-Forwarded-Encrypted: i=1; AJvYcCWHk8rp7KJpQAgfioZVmzVCcEK0uhPgL53KGdQll1Q+cSVP2T2EpwL5SyOf9VciktVOg/ncvsDHet3WxpYZL4qt@lists.infradead.org X-Gm-Message-State: AOJu0YxINkkdnYx0PfDRbocFoRWT1trXqC+0wpftetqNQ52G4dcRB/YT oGEYPQBf5fdZvySEJ92yxliuqgeF1oYpj9Eme1Y8i/LdVIe5b7fq+Jid6nKV3GQ= X-Google-Smtp-Source: AGHT+IH76Pa8fJCQoDjA+iSkOMmtEE9IAbNSBuTosKzgLhAPo+74/va/yq/CBvMkCkqWCNLwm1hnrg== X-Received: by 2002:a05:600c:45d0:b0:42c:e0da:f155 with SMTP id 5b1f17b1804b1-42e96109f23mr16269685e9.11.1727256238210; Wed, 25 Sep 2024 02:23:58 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e969f90absm12239255e9.12.2024.09.25.02.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 02:23:57 -0700 (PDT) Date: Wed, 25 Sep 2024 12:23:53 +0300 From: Dan Carpenter To: Umang Jain Cc: Greg Kroah-Hartman , Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Kieran Bingham , Stefan Wahren Subject: Re: [PATCH 0/3] staging: vchiq_core: Consolidate bulk xfer helper Message-ID: <6661b2d5-b439-46e1-b240-9fe436db4e67@stanley.mountain> References: <20240919142130.1331495-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240919142130.1331495-1-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_022400_219526_4D371C38 X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 19, 2024 at 07:51:27PM +0530, Umang Jain wrote: > Few functions were identified were their declaration, definition > and usage were spread (incorrectly) across vchiq_core and vchiq_arm. > > These are being consolidated into vchiq_core in this series. > Please look at individual patches for details. > > 2/3 is in particular a big one. The code is just a move, but > seems big - as it was diffcult to split it into smaller, compilable > hunks of individual patches. > > Umang Jain (3): > staging: vchiq_core: Move remote_event_signal() vchiq_core > staging: vchiq_core: Move bulk data functions in vchiq_core > staging: vchiq_core: Drop vchiq_pagelist.h > Reviewed-by: Dan Carpenter But next time, if you're just moving code around, just ignore checkpatch. Do the white space changes as a separate patch. regards, dan carpenter +- memcpy_to_page(pages[0], +- pagelist->offset, +- fragments, +- head_bytes); ++ memcpy_to_page(pages[0], pagelist->offset, ++ fragments, head_bytes); } + if ((actual >= 0) && (head_bytes < actual) && + (tail_bytes != 0)) + memcpy_to_page(pages[num_pages - 1], +- (pagelist->offset + actual) & +- (PAGE_SIZE - 1) & ~(drv_mgmt->info->cache_line_size - 1), +- fragments + drv_mgmt->info->cache_line_size, +- tail_bytes); ++ (pagelist->offset + actual) & ++ (PAGE_SIZE - 1) & ~(drv_mgmt->info->cache_line_size - 1), ++ fragments + drv_mgmt->info->cache_line_size, ++ tail_bytes);